Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf: Reduce allocations (#2045) 

I found a few places where some allocations could be avoided.
This commit is contained in:
Dmitry Dygalo 2023-01-21 02:06:48 +01:00 committed by GitHub
parent 608b2191aa
commit babe1eb7be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/flake8_to_ruff/converter.rs
View File

@ -104,7 +104,7 @@ pub fn convert(
"builtins" => {
options.builtins = Some(parser::parse_strings(value.as_ref()));
}
"max-line-length" | "max_line_length" => match value.clone().parse::<usize>() {
"max-line-length" | "max_line_length" => match value.parse::<usize>() {
Ok(line_length) => options.line_length = Some(line_length),
Err(e) => {
warn_user!("Unable to parse '{key}' property: {e}");
@ -241,7 +241,7 @@ pub fn convert(
}
},
// mccabe
"max-complexity" | "max_complexity" => match value.clone().parse::<usize>() {
"max-complexity" | "max_complexity" => match value.parse::<usize>() {
Ok(max_complexity) => mccabe.max_complexity = Some(max_complexity),
Err(e) => {
warn_user!("Unable to parse '{key}' property: {e}");
@ -249,7 +249,7 @@ pub fn convert(
},
// flake8-errmsg
"errmsg-max-string-length" | "errmsg_max_string_length" => {
match value.clone().parse::<usize>() {
match value.parse::<usize>() {
Ok(max_string_length) => {
flake8_errmsg.max_string_length = Some(max_string_length);
}

8
src/rules/flake8_annotations/rules.rs
View File

@ -119,7 +119,7 @@ pub fn definition(checker: &mut Checker, definition: &Definition, visibility: &V
.rules
.enabled(&Rule::DynamicallyTypedExpression)
{
let name = arg.node.arg.to_string();
let name = &arg.node.arg;
check_dynamically_typed(checker, expr, || format!("*{name}"));
}
}
@ -146,7 +146,7 @@ pub fn definition(checker: &mut Checker, definition: &Definition, visibility: &V
.rules
.enabled(&Rule::DynamicallyTypedExpression)
{
let name = arg.node.arg.to_string();
let name = &arg.node.arg;
check_dynamically_typed(checker, expr, || format!("**{name}"));
}
}
@ -266,7 +266,7 @@ pub fn definition(checker: &mut Checker, definition: &Definition, visibility: &V
.rules
.enabled(&Rule::DynamicallyTypedExpression)
{
let name = arg.node.arg.to_string();
let name = &arg.node.arg;
check_dynamically_typed(checker, expr, || format!("*{name}"));
}
}
@ -294,7 +294,7 @@ pub fn definition(checker: &mut Checker, definition: &Definition, visibility: &V
.rules
.enabled(&Rule::DynamicallyTypedExpression)
{
let name = arg.node.arg.to_string();
let name = &arg.node.arg;
check_dynamically_typed(checker, expr, || format!("**{name}"));
}
}

4
src/rules/flake8_pytest_style/rules/fixture.rs
View File

@ -217,10 +217,10 @@ fn check_fixture_returns(checker: &mut Checker, func: &Stmt, func_name: &str, bo
/// PT019
fn check_test_function_args(checker: &mut Checker, args: &Arguments) {
args.args.iter().chain(&args.kwonlyargs).for_each(|arg| {
let name = arg.node.arg.to_string();
let name = &arg.node.arg;
if name.starts_with('_') {
checker.diagnostics.push(Diagnostic::new(
violations::FixtureParamWithoutValue(name),
violations::FixtureParamWithoutValue(name.to_string()),
Range::from_located(arg),
));
}