From bf88fee428b26ab343b08bc46da063ab5a1c04cc Mon Sep 17 00:00:00 2001 From: GiGaGon <107241144+MeGaGiGaGon@users.noreply.github.com> Date: Thu, 3 Jul 2025 06:57:35 -0700 Subject: [PATCH] [`flake8-simplify`] Make example error out-of-the-box (`SIM110`) (#19113) ## Summary Part of #18972 This PR makes [reimplemented-builtin (SIM110)](https://docs.astral.sh/ruff/rules/reimplemented-builtin/#reimplemented-builtin-sim110)'s example error out-of-the-box [Old example](https://play.ruff.rs/1c192e8b-13f8-4f07-8c35-9dcd516a4a02) ```py for item in iterable: if predicate(item): return True return False ``` [New example](https://play.ruff.rs/f77393ad-20b1-436f-a872-d3bccec7c829) ```py def foo(): for item in iterable: if predicate(item): return True return False ``` The "Use instead" section was also updated to reflect the change. ## Test Plan N/A, no functionality/tests affected --- .../flake8_simplify/rules/reimplemented_builtin.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs index 67f70ecb35..0483742463 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs @@ -23,15 +23,17 @@ use crate::{Edit, Fix, FixAvailability, Violation}; /// /// ## Example /// ```python -/// for item in iterable: -/// if predicate(item): -/// return True -/// return False +/// def foo(): +/// for item in iterable: +/// if predicate(item): +/// return True +/// return False /// ``` /// /// Use instead: /// ```python -/// return any(predicate(item) for item in iterable) +/// def foo(): +/// return any(predicate(item) for item in iterable) /// ``` /// /// ## Fix safety