Use inline snapshots in `# noqa` unit tests (#16687)

## Summary

Follow-up to #16677.

This change converts all unit tests (69 of them) in `noqa.rs` to use
inline snapshots instead. It extends the file by more than 1000 lines,
but the tests are now much easier to read and reason about.

## Test Plan

`cargo insta test`.
This commit is contained in:
InSync 2025-03-13 01:16:27 +07:00 committed by Micha Reiser
parent 16b0902e28
commit c605ce6fe2
72 changed files with 1081 additions and 1292 deletions

File diff suppressed because it is too large Load Diff

View File

@ -1,6 +1,5 @@
--- ---
source: crates/ruff_linter/src/linter.rs source: crates/ruff_linter/src/linter.rs
snapshot_kind: text
--- ---
undefined_name.ipynb:cell 3:1:7: F821 Undefined name `undefined` undefined_name.ipynb:cell 3:1:7: F821 Undefined name `undefined`
| |

View File

@ -1,6 +1,5 @@
--- ---
source: crates/ruff_linter/src/linter.rs source: crates/ruff_linter/src/linter.rs
snapshot_kind: text
--- ---
unused_variable.ipynb:cell 1:2:5: F841 [*] Local variable `foo1` is assigned to but never used unused_variable.ipynb:cell 1:2:5: F841 [*] Local variable `foo1` is assigned to but never used
| |

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..14,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..14,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..12,
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..26,
codes: [
Code {
code: "F401",
range: 16..20,
},
Code {
code: "F841",
range: 22..26,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
MissingCodes,
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..22,
codes: [
Code {
code: "RUF001",
range: 16..22,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
InvalidCodeSuffix,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
MissingCodes,
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..14,
codes: [
Code {
code: "RUF001",
range: 8..14,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
InvalidCodeSuffix,
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..6,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..6,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 35..41,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..7,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..5,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..6,
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..12,
codes: [
Code {
code: "F401",
range: 8..12,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..12,
codes: [
Code {
code: "F401",
range: 8..12,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
InvalidCodeSuffix,
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 35..47,
codes: [
Code {
code: "F401",
range: 43..47,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 2..13,
codes: [
Code {
code: "F401",
range: 9..13,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 6..18,
codes: [
Code {
code: "F401",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..13,
codes: [
Code {
code: "F401",
range: 9..13,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..10,
codes: [
Code {
code: "F401",
range: 6..10,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..12,
codes: [
Code {
code: "F401",
range: 8..12,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 8..12,
},
Code {
code: "F841",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 8..12,
},
Code {
code: "F841",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 35..53,
codes: [
Code {
code: "F401",
range: 43..47,
},
Code {
code: "F841",
range: 49..53,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..20,
codes: [
Code {
code: "F401",
range: 9..13,
},
Code {
code: "F841",
range: 16..20,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..15,
codes: [
Code {
code: "F401",
range: 6..10,
},
Code {
code: "F841",
range: 11..15,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 8..12,
},
Code {
code: "F841",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,30 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [
MissingItem(
13..13,
),
],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 8..12,
},
Code {
code: "F841",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,30 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [
MissingItem(
13..14,
),
],
directive: Codes(
Codes {
range: 0..19,
codes: [
Code {
code: "F401",
range: 8..12,
},
Code {
code: "F841",
range: 15..19,
},
],
},
),
},
),
)

View File

@ -1,8 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: "Directive::try_extract(source, TextSize::default())"
snapshot_kind: text
---
Err(
MissingCodes,
)

View File

@ -1,8 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: "Directive::try_extract(source, TextSize::default())"
snapshot_kind: text
---
Err(
InvalidSuffix,
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 4..16,
codes: [
Code {
code: "F401",
range: 12..16,
},
],
},
),
},
),
)

View File

@ -1,20 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: lex_codes(&source)
---
Ok(
[
Code {
code: "F401",
range: 1..5,
},
Code {
code: "F402",
range: 7..11,
},
Code {
code: "F403",
range: 11..15,
},
],
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: "Directive::try_extract(source, TextSize::default())"
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: "Directive::try_extract(source, TextSize::default())"
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: "Directive::try_extract(source, TextSize::default())"
---
Err(
MissingCodes,
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..12,
codes: [
Code {
code: "F401",
range: 8..12,
},
],
},
),
},
),
)

View File

@ -1,30 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [
MissingDelimiter(
12..12,
),
],
directive: Codes(
Codes {
range: 0..16,
codes: [
Code {
code: "F401",
range: 8..12,
},
Code {
code: "F841",
range: 12..16,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..12,
codes: [
Code {
code: "F401",
range: 8..12,
},
],
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..12,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..12,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 18..30,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..10,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..12,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..12,
},
),
},
),
)

View File

@ -1,16 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: All(
All {
range: 0..12,
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 18..36,
codes: [
Code {
code: "F401",
range: 32..36,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..18,
codes: [
Code {
code: "F401",
range: 14..18,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..24,
codes: [
Code {
code: "F401",
range: 14..18,
},
Code {
code: "F841",
range: 20..24,
},
],
},
),
},
),
)

View File

@ -1,26 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 3..27,
codes: [
Code {
code: "F401",
range: 17..21,
},
Code {
code: "F841",
range: 23..27,
},
],
},
),
},
),
)

View File

@ -1,30 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [
MissingItem(
19..19,
),
],
directive: Codes(
Codes {
range: 0..24,
codes: [
Code {
code: "F401",
range: 14..18,
},
Code {
code: "F841",
range: 20..24,
},
],
},
),
},
),
)

View File

@ -1,30 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [
MissingItem(
19..20,
),
],
directive: Codes(
Codes {
range: 0..25,
codes: [
Code {
code: "F401",
range: 14..18,
},
Code {
code: "F841",
range: 21..25,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
InvalidCodeSuffix,
)

View File

@ -1,30 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Ok(
Some(
NoqaLexerOutput {
warnings: [
MissingDelimiter(
18..18,
),
],
directive: Codes(
Codes {
range: 0..22,
codes: [
Code {
code: "F401",
range: 14..18,
},
Code {
code: "F841",
range: 18..22,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
MissingCodes,
)

View File

@ -1,22 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Ok(
Some(
NoqaLexerOutput {
warnings: [],
directive: Codes(
Codes {
range: 0..20,
codes: [
Code {
code: "RUF001",
range: 14..20,
},
],
},
),
},
),
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: directive
---
Err(
InvalidCodeSuffix,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
MissingCodes,
)

View File

@ -1,7 +0,0 @@
---
source: crates/ruff_linter/src/noqa.rs
expression: exemption
---
Err(
MissingCodes,
)