Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[red-knot] Fix some instance-attribute TODOs around `ModuleType` (#15974)

This commit is contained in:
Alex Waygood 2025-02-05 15:33:37 +00:00 committed by GitHub
parent 3f958a9d4c
commit c816542704
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/red_knot_python_semantic/resources/mdtest/scopes/moduletype_attrs.md
View File

@ -56,10 +56,10 @@ inside the module:
import typing import typing
reveal_type(typing.__name__) # revealed: str reveal_type(typing.__name__) # revealed: str
reveal_type(typing.__init__) # revealed: Literal[__init__] reveal_type(typing.__init__) # revealed: @Todo(bound method)
# These come from `builtins.object`, not `types.ModuleType`: # These come from `builtins.object`, not `types.ModuleType`:
reveal_type(typing.__eq__) # revealed: Literal[__eq__] reveal_type(typing.__eq__) # revealed: @Todo(bound method)
reveal_type(typing.__class__) # revealed: Literal[ModuleType] reveal_type(typing.__class__) # revealed: Literal[ModuleType]

7
crates/red_knot_python_semantic/src/types.rs
View File

@ -264,9 +264,7 @@ pub(crate) fn global_symbol<'db>(db: &'db dyn Db, file: File, name: &str) -> Sym
.iter() .iter()
.any(|module_type_member| &**module_type_member == name) .any(|module_type_member| &**module_type_member == name)
{ {
// TODO: this should use `.to_instance(db)`. but we don't understand attribute access KnownClass::ModuleType.to_instance(db).member(db, name)
// on instance types yet.
KnownClass::ModuleType.to_class_literal(db).member(db, name)
} else { } else {
Symbol::Unbound Symbol::Unbound
} }
@ -3810,8 +3808,7 @@ impl<'db> ModuleLiteralType<'db> {
if name == "__getattr__" { if name == "__getattr__" {
Symbol::Unbound Symbol::Unbound
} else { } else {
// TODO: this should use `.to_instance()`, but we don't understand instance attribute yet KnownClass::ModuleType.to_instance(db).member(db, name)
KnownClass::ModuleType.to_class_literal(db).member(db, name)
} }
}) })
} }