Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-09 07:34:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

[syntax-errors] Limit except* range to * (#16473)

Browse Source 
Summary
--
This is a follow-up to #16446 to fix the diagnostic range to point to
the `*` like `pyright` does
(https://github.com/astral-sh/ruff/pull/16446#discussion_r1976900643).

Storing the range in the `ExceptClauseKind::Star` variant feels slightly
awkward, but we don't store the star itself anywhere on the
`ExceptHandler`. And we can't just take `ExceptHandler.start() +
"except".text_len()` because this code appears to be valid:

```python
try: ...
except    *    Error: ...
```

Test Plan
--
Existing tests.
This commit is contained in:
Brent Westbrook
2025-03-04 11:50:09 -05:00
committed by GitHub
parent 1977dda079
commit c8a06a9be8
3 changed files with 94 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ruff_python_parser/resources/inline/err/except_star_py310.py
View File

@@ -1,3 +1,5 @@
# parse_options: {"target-version": "3.10"}
try: ...
except* ValueError: ...
except* KeyError: ...
except * Error: ...