From c8c80e054efacdcd043996356dbb0141c5a4bbf9 Mon Sep 17 00:00:00 2001
From: UnboundVariable <unbound@peoplelike.ai>
Date: Thu, 24 Jul 2025 16:26:14 -0700
Subject: [PATCH] [ty] Fix bug #879 in signature help (#19542)

This PR fixes bug [#879](https://github.com/astral-sh/ty/issues/879)
where the signature help popup remains visible after typing the closing
paren in a call expression.

Co-authored-by: UnboundVariable <unbound@gmail.com>
---
 crates/ty_ide/src/signature_help.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/crates/ty_ide/src/signature_help.rs b/crates/ty_ide/src/signature_help.rs
index b8232ebff2..3cf5980236 100644
--- a/crates/ty_ide/src/signature_help.rs
+++ b/crates/ty_ide/src/signature_help.rs
@@ -66,6 +66,10 @@ pub fn signature_help(db: &dyn Db, file: File, offset: TextSize) -> Option<Signa
     // Get the call expression at the given position.
     let (call_expr, current_arg_index) = get_call_expr(&parsed, offset)?;
 
+    if offset >= call_expr.end() {
+        return None;
+    }
+
     // Get signature details from the semantic analyzer.
     let signature_details: Vec<CallSignatureDetails<'_>> =
         call_signature_details(db, file, call_expr);