diff --git a/src/check_ast.rs b/src/check_ast.rs index 8e64785589..8d398cd399 100644 --- a/src/check_ast.rs +++ b/src/check_ast.rs @@ -2594,7 +2594,7 @@ impl<'a> Checker<'a> { if !scope.import_starred && !self.path.ends_with("__init__.py") { if let Some(all_binding) = all_binding { if let Some(names) = &all_names { - for name in names { + for &name in names { if !scope.values.contains_key(name) { checks.push(Check::new( CheckKind::UndefinedExport(name.to_string()), @@ -2622,7 +2622,7 @@ impl<'a> Checker<'a> { } from_list.sort(); - for name in names { + for &name in names { if !scope.values.contains_key(name) { checks.push(Check::new( CheckKind::ImportStarUsage( diff --git a/src/pyflakes/checks.rs b/src/pyflakes/checks.rs index f7a2b1c921..e4d323a747 100644 --- a/src/pyflakes/checks.rs +++ b/src/pyflakes/checks.rs @@ -63,13 +63,13 @@ pub fn unused_variables(scope: &Scope, dummy_variable_rgx: &Regex) -> Vec return checks; } - for (name, binding) in scope.values.iter() { + for (&name, binding) in scope.values.iter() { if binding.used.is_none() && matches!(binding.kind, BindingKind::Assignment) && !dummy_variable_rgx.is_match(name) - && name != &"__tracebackhide__" - && name != &"__traceback_info__" - && name != &"__traceback_supplement__" + && name != "__tracebackhide__" + && name != "__traceback_info__" + && name != "__traceback_supplement__" { checks.push(Check::new( CheckKind::UnusedVariable(name.to_string()), diff --git a/src/pyupgrade/plugins/deprecated_unittest_alias.rs b/src/pyupgrade/plugins/deprecated_unittest_alias.rs index 52b3f366ee..53f807221e 100644 --- a/src/pyupgrade/plugins/deprecated_unittest_alias.rs +++ b/src/pyupgrade/plugins/deprecated_unittest_alias.rs @@ -30,7 +30,7 @@ static DEPRECATED_ALIASES: Lazy> = Lazy::n /// U005 pub fn deprecated_unittest_alias(checker: &mut Checker, expr: &Expr) { if let ExprKind::Attribute { value, attr, .. } = &expr.node { - if let Some(target) = DEPRECATED_ALIASES.get(attr.as_str()) { + if let Some(&target) = DEPRECATED_ALIASES.get(attr.as_str()) { if let ExprKind::Name { id, .. } = &value.node { if id == "self" { let mut check = Check::new( diff --git a/src/pyupgrade/plugins/use_pep585_annotation.rs b/src/pyupgrade/plugins/use_pep585_annotation.rs index f56e0c3585..c54cf119b9 100644 --- a/src/pyupgrade/plugins/use_pep585_annotation.rs +++ b/src/pyupgrade/plugins/use_pep585_annotation.rs @@ -7,7 +7,7 @@ use crate::checks::{Check, CheckKind}; /// U006 pub fn use_pep585_annotation(checker: &mut Checker, expr: &Expr, id: &str) { - let replacement = checker.import_aliases.get(id).unwrap_or(&id); + let replacement = *checker.import_aliases.get(id).unwrap_or(&id); let mut check = Check::new( CheckKind::UsePEP585Annotation(replacement.to_string()), Range::from_located(expr),