From d1cf0ee52b861c87d708e80a9d13d83e97de7090 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Skytt=C3=A4?= Date: Mon, 13 Feb 2023 16:43:35 +0200 Subject: [PATCH] Remove "blanket" from RUF100 README message (#2844) --- README.md | 2 +- crates/ruff/src/rules/ruff/rules/unused_noqa.rs | 2 +- docs/rules/if-with-same-arms.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 798bcc4b30..29c5907873 100644 --- a/README.md +++ b/README.md @@ -1477,7 +1477,7 @@ For more, see [flake8-self](https://pypi.org/project/flake8-self/) on PyPI. | RUF003 | ambiguous-unicode-character-comment | Comment contains ambiguous unicode character '{confusable}' (did you mean '{representant}'?) | 🛠 | | RUF004 | keyword-argument-before-star-argument | Keyword argument `{name}` must come after starred arguments | | | RUF005 | unpack-instead-of-concatenating-to-collection-literal | Consider `{expr}` instead of concatenation | 🛠 | -| RUF100 | unused-noqa | Unused blanket `noqa` directive | 🛠 | +| RUF100 | unused-noqa | Unused `noqa` directive | 🛠 | diff --git a/crates/ruff/src/rules/ruff/rules/unused_noqa.rs b/crates/ruff/src/rules/ruff/rules/unused_noqa.rs index f70d3115ee..cf80378d83 100644 --- a/crates/ruff/src/rules/ruff/rules/unused_noqa.rs +++ b/crates/ruff/src/rules/ruff/rules/unused_noqa.rs @@ -21,7 +21,6 @@ impl AlwaysAutofixableViolation for UnusedNOQA { fn message(&self) -> String { let UnusedNOQA { codes } = self; match codes { - None => format!("Unused blanket `noqa` directive"), Some(codes) => { let mut codes_by_reason = vec![]; if !codes.unmatched.is_empty() { @@ -60,6 +59,7 @@ impl AlwaysAutofixableViolation for UnusedNOQA { format!("Unused `noqa` directive ({})", codes_by_reason.join("; ")) } } + None => format!("Unused blanket `noqa` directive"), } } diff --git a/docs/rules/if-with-same-arms.md b/docs/rules/if-with-same-arms.md index dc8ad20380..4fecf4251f 100644 --- a/docs/rules/if-with-same-arms.md +++ b/docs/rules/if-with-same-arms.md @@ -21,4 +21,4 @@ Use instead: ```python if x = 1 or x = 2: print("Hello") -``` +``` \ No newline at end of file