Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] Fix rendering of unused suppression diagnostic (#21580)

This commit is contained in:
Micha Reiser 2025-11-22 18:42:56 +01:00 committed by GitHub
parent 859f9ec21a
commit d24c891a4b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/ty_python_semantic/resources/mdtest/snapshots/mro.md_-_Method_Resolution_Or…_-_`__bases__`_lists_wi…_(ea7ebc83ec359b54).snap
View File

@ -303,13 +303,13 @@ info: rule `duplicate-base` is enabled by default
``` ```
``` ```
info[unused-ignore-comment] info[unused-ignore-comment]: Unused blanket `type: ignore` directive
--> src/mdtest_snippet.py:72:9 --> src/mdtest_snippet.py:72:9
| |
70 | A, 70 | A,
71 | # error: [unused-ignore-comment] 71 | # error: [unused-ignore-comment]
72 | A, # type: ignore[duplicate-base] 72 | A, # type: ignore[duplicate-base]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unused blanket `type: ignore` directive | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
73 | ): ... 73 | ): ...
| |
@ -346,13 +346,13 @@ info: rule `duplicate-base` is enabled by default
``` ```
``` ```
info[unused-ignore-comment] info[unused-ignore-comment]: Unused blanket `type: ignore` directive
--> src/mdtest_snippet.py:81:13 --> src/mdtest_snippet.py:81:13
| |
79 | ): 79 | ):
80 | # error: [unused-ignore-comment] 80 | # error: [unused-ignore-comment]
81 | x: int # type: ignore[duplicate-base] 81 | x: int # type: ignore[duplicate-base]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unused blanket `type: ignore` directive | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
82 | 82 |
83 | # fmt: on 83 | # fmt: on
| |

4
crates/ty_python_semantic/src/suppression.rs
View File

@ -297,10 +297,10 @@ impl<'a> CheckSuppressionsContext<'a> {
}; };
let id = DiagnosticId::Lint(lint.name()); let id = DiagnosticId::Lint(lint.name());
let mut diag = Diagnostic::new(id, severity, ""); let mut diag = Diagnostic::new(id, severity, message);
diag.set_documentation_url(Some(lint.documentation_url())); diag.set_documentation_url(Some(lint.documentation_url()));
let span = Span::from(self.file).with_range(range); let span = Span::from(self.file).with_range(range);
diag.annotate(Annotation::primary(span).message(message)); diag.annotate(Annotation::primary(span));
self.diagnostics.push(diag); self.diagnostics.push(diag);
} }
} }