Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow `ctypes.WinError()` in flake8-raise (#6731) 

Closes https://github.com/astral-sh/ruff/issues/6730.
This commit is contained in:
Charlie Marsh 2023-08-21 10:57:34 -04:00 committed by GitHub
parent 83f68891e0
commit d5a51b4e45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/ruff/resources/test/fixtures/flake8_raise/RSE102.py vendored
View File

@ -52,3 +52,10 @@ class Class:
# OK # OK
raise Class.error() raise Class.error()
import ctypes
# OK
raise ctypes.WinError(1)

10
crates/ruff/src/rules/flake8_raise/rules/unnecessary_paren_on_raise_exception.rs
View File

@ -71,6 +71,16 @@ pub(crate) fn unnecessary_paren_on_raise_exception(checker: &mut Checker, expr:
return; return;
} }
// `ctypes.WinError()` is a function, not a class. It's part of the standard library, so
// we might as well get it right.
if checker
.semantic()
.resolve_call_path(func)
.is_some_and(|call_path| matches!(call_path.as_slice(), ["ctypes", "WinError"]))
{
return;
}
let range = match_parens(func.end(), checker.locator(), checker.source_type) let range = match_parens(func.end(), checker.locator(), checker.source_type)
.expect("Expected call to include parentheses"); .expect("Expected call to include parentheses");
let mut diagnostic = Diagnostic::new(UnnecessaryParenOnRaiseException, range); let mut diagnostic = Diagnostic::new(UnnecessaryParenOnRaiseException, range);