Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-05 21:54:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

[ty] Improve diagnostic range for non-subscriptable diagnostics (#21461)

Browse Source 
## Summary

Currently our diagnostic only covers the range of the thing being
subscripted:

<img width="1702" height="312" alt="image"
src="https://github.com/user-attachments/assets/7e630431-e846-46ca-93c1-139f11aaba11"
/>

But it should probably cover the _whole_ subscript expression (arguably
the more "incorrect" bit is the `["foo"]` part of this expression, not
the `x` part of this expression!)

## Test Plan

Added a snapshot

Co-authored-by: Brent Westbrook
<36778786+ntBre@users.noreply.github.com>
This commit is contained in:
Alex Waygood
2025-11-14 21:15:14 +00:00
committed by GitHub
parent c5d654bce8
commit d63b4b0383
6 changed files with 54 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/ty_python_semantic/resources/mdtest/subscript/instance.md
View File

@@ -2,10 +2,12 @@
## `__getitem__` unbound
<!-- snapshot-diagnostics -->
```py
class NotSubscriptable: ...
a = NotSubscriptable()[0] # error: "Cannot subscript object of type `NotSubscriptable` with no `__getitem__` method"
a = NotSubscriptable()[0] # error: [non-subscriptable]
```
## `__getitem__` not callable