From dc09f529bcd19b4a31a6caec82b6e563efe6b843 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Thu, 25 Apr 2024 15:06:47 -0400 Subject: [PATCH] Build a separate ARM wheel for macOS (#11149) ## Summary Since we already build an x86 wheel, we can just build an ARM wheel rather than cross-compiling to universal. The build time is ~3 minutes vs. > 20 minutes and the resulting artifact is much smaller, which is also a win for users. --- .github/workflows/release.yaml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 97bba8bc87..629916fb78 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -97,8 +97,8 @@ jobs: *.tar.gz *.sha256 - macos-universal: - runs-on: macos-12 + macos-aarch64: + runs-on: macos-14 steps: - uses: actions/checkout@v4 with: @@ -106,16 +106,17 @@ jobs: - uses: actions/setup-python@v5 with: python-version: ${{ env.PYTHON_VERSION }} - architecture: x64 + architecture: arm64 - name: "Prep README.md" run: python scripts/transform_readme.py --target pypi - - name: "Build wheels - universal2" + - name: "Build wheels - aarch64" uses: PyO3/maturin-action@v1 with: - args: --release --locked --target universal2-apple-darwin --out dist - - name: "Test wheel - universal2" + target: aarch64 + args: --release --locked --out dist + - name: "Test wheel - aarch64" run: | - pip install dist/${{ env.PACKAGE_NAME }}-*universal2.whl --force-reinstall + pip install dist/${{ env.PACKAGE_NAME }}-*.whl --force-reinstall ruff --help python -m ruff --help - name: "Upload wheels" @@ -451,7 +452,7 @@ jobs: name: Upload to PyPI runs-on: ubuntu-latest needs: - - macos-universal + - macos-aarch64 - macos-x86_64 - windows - linux