Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix false positive for `IfTuple` (#96)

This commit is contained in:
Harutaka Kawamura 2022-09-04 11:56:55 +09:00 committed by GitHub
parent 97cc30768d
commit e2f46537fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
resources/test/fixtures/F634.py vendored
View File

@ -6,3 +6,5 @@ for _ in range(5):
pass pass
elif (3, 4): elif (3, 4):
pass pass
elif ():
pass

4
src/check_ast.rs
View File

@ -241,7 +241,8 @@ impl Visitor for Checker<'_> {
} }
StmtKind::If { test, .. } => { StmtKind::If { test, .. } => {
if self.settings.select.contains(CheckKind::IfTuple.code()) { if self.settings.select.contains(CheckKind::IfTuple.code()) {
if let ExprKind::Tuple { .. } = test.node { if let ExprKind::Tuple { elts, .. } = &test.node {
if !elts.is_empty() {
self.checks.push(Check { self.checks.push(Check {
kind: CheckKind::IfTuple, kind: CheckKind::IfTuple,
location: stmt.location, location: stmt.location,
@ -249,6 +250,7 @@ impl Visitor for Checker<'_> {
} }
} }
} }
}
StmtKind::Raise { exc, .. } => { StmtKind::Raise { exc, .. } => {
if self if self
.settings .settings