Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update crates/ruff/src/rules/pylint/rules/useless_return.rs 

Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
This commit is contained in:
tomecki 2023-02-25 12:59:13 +01:00 committed by GitHub
parent 02ae14037b
commit e556fb4c77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
crates/ruff/src/rules/pylint/rules/useless_return.rs
View File

@ -62,25 +62,26 @@ pub fn useless_return(checker: &mut Checker, stmt: &Stmt) {
None => true,
Some(loc_expr) => is_const_none(loc_expr),
};
if is_bare_return_or_none {
let mut diagnostic = Diagnostic::new(UselessReturn, Range::from_located(stmt));
if checker.patch(diagnostic.kind.rule()) {
match delete_stmt(
stmt,
None,
&[],
checker.locator,
checker.indexer,
checker.stylist,
) {
Ok(fix) => {
diagnostic.amend(fix);
}
Err(e) => {
error!("Failed to delete `return` statement: {}", e);
}
};
}
checker.diagnostics.push(diagnostic);
if !is_bare_return_or_none {
return;
}
let mut diagnostic = Diagnostic::new(UselessReturn, Range::from_located(stmt));
if !checker.patch(diagnostic.kind.rule()) {
match delete_stmt(
stmt,
None,
&[],
checker.locator,
checker.indexer,
checker.stylist,
) {
Ok(fix) => {
diagnostic.amend(fix);
}
Err(e) => {
error!("Failed to delete `return` statement: {}", e);
}
};
}
checker.diagnostics.push(diagnostic);
}