From eb8c0ad87c4e10e2d66ada5e4bb7f436214ca9a8 Mon Sep 17 00:00:00 2001
From: Micha Reiser <micha@reiser.io>
Date: Fri, 24 Oct 2025 18:00:00 +0200
Subject: [PATCH] [ty] Add `--no-progress` option (#21063)

---
 crates/ty/docs/cli.md    |  2 ++
 crates/ty/src/args.rs    | 20 ++++++++++++++++----
 crates/ty/src/lib.rs     |  2 +-
 crates/ty/src/printer.rs |  5 ++---
 4 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/crates/ty/docs/cli.md b/crates/ty/docs/cli.md
index 4c44f523d7..97a9a1c2d9 100644
--- a/crates/ty/docs/cli.md
+++ b/crates/ty/docs/cli.md
@@ -58,6 +58,8 @@ over all configuration files.</p>
 <p>This is an advanced option that should usually only be used for first-party or third-party modules that are not installed into your Python environment in a conventional way. Use <code>--python</code> to point ty to your Python environment if it is in an unusual location.</p>
 </dd><dt id="ty-check--help"><a href="#ty-check--help"><code>--help</code></a>, <code>-h</code></dt><dd><p>Print help (see a summary with '-h')</p>
 </dd><dt id="ty-check--ignore"><a href="#ty-check--ignore"><code>--ignore</code></a> <i>rule</i></dt><dd><p>Disables the rule. Can be specified multiple times.</p>
+</dd><dt id="ty-check--no-progress"><a href="#ty-check--no-progress"><code>--no-progress</code></a></dt><dd><p>Hide all progress outputs.</p>
+<p>For example, spinners or progress bars.</p>
 </dd><dt id="ty-check--output-format"><a href="#ty-check--output-format"><code>--output-format</code></a> <i>output-format</i></dt><dd><p>The format to use for printing diagnostic messages</p>
 <p>Possible values:</p>
 <ul>
diff --git a/crates/ty/src/args.rs b/crates/ty/src/args.rs
index f1be98ea46..f6a52a3c8c 100644
--- a/crates/ty/src/args.rs
+++ b/crates/ty/src/args.rs
@@ -34,6 +34,7 @@ pub(crate) enum Command {
 }
 
 #[derive(Debug, Parser)]
+#[expect(clippy::struct_excessive_bools)]
 pub(crate) struct CheckCommand {
     /// List of files or directories to check.
     #[clap(
@@ -117,10 +118,6 @@ pub(crate) struct CheckCommand {
     #[arg(long)]
     pub(crate) output_format: Option<OutputFormat>,
 
-    /// Control when colored output is used.
-    #[arg(long, value_name = "WHEN")]
-    pub(crate) color: Option<TerminalColor>,
-
     /// Use exit code 1 if there are any warning-level diagnostics.
     #[arg(long, conflicts_with = "exit_zero", default_missing_value = "true", num_args=0..1)]
     pub(crate) error_on_warning: Option<bool>,
@@ -152,6 +149,21 @@ pub(crate) struct CheckCommand {
     /// Supports patterns like `tests/`, `*.tmp`, `**/__pycache__/**`.
     #[arg(long, help_heading = "File selection")]
     exclude: Option<Vec<String>>,
+
+    /// Control when colored output is used.
+    #[arg(
+        long,
+        value_name = "WHEN",
+        help_heading = "Global options",
+        display_order = 1000
+    )]
+    pub(crate) color: Option<TerminalColor>,
+
+    /// Hide all progress outputs.
+    ///
+    /// For example, spinners or progress bars.
+    #[arg(global = true, long, value_parser = clap::builder::BoolishValueParser::new(), help_heading = "Global options")]
+    pub no_progress: bool,
 }
 
 impl CheckCommand {
diff --git a/crates/ty/src/lib.rs b/crates/ty/src/lib.rs
index 66a85870b2..2b28329f3f 100644
--- a/crates/ty/src/lib.rs
+++ b/crates/ty/src/lib.rs
@@ -71,7 +71,7 @@ fn run_check(args: CheckCommand) -> anyhow::Result<ExitStatus> {
     let verbosity = args.verbosity.level();
     let _guard = setup_tracing(verbosity, args.color.unwrap_or_default())?;
 
-    let printer = Printer::default().with_verbosity(verbosity);
+    let printer = Printer::new(verbosity, args.no_progress);
 
     tracing::debug!("Version: {}", version::version());
 
diff --git a/crates/ty/src/printer.rs b/crates/ty/src/printer.rs
index 94c5286d35..1c86095c21 100644
--- a/crates/ty/src/printer.rs
+++ b/crates/ty/src/printer.rs
@@ -12,11 +12,10 @@ pub(crate) struct Printer {
 }
 
 impl Printer {
-    #[must_use]
-    pub(crate) fn with_verbosity(self, verbosity: VerbosityLevel) -> Self {
+    pub(crate) fn new(verbosity: VerbosityLevel, no_progress: bool) -> Self {
         Self {
             verbosity,
-            no_progress: self.no_progress,
+            no_progress,
         }
     }