Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] Tweaks tests to use clearer language 

A completion lacking a module reference doesn't necessarily mean that
the symbol is defined within the current module. I believe the intent
here is that it means that no import is required to use it.
This commit is contained in:
Andrew Gallant 2025-12-04 09:13:17 -05:00 committed by Andrew Gallant
parent e154efa229
commit f054e7edf8
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
crates/ty_ide/src/completion.rs
View File

@ -4350,7 +4350,7 @@ from os.<CURSOR>
.build() .build()
.snapshot(); .snapshot();
assert_snapshot!(snapshot, @r" assert_snapshot!(snapshot, @r"
Kadabra :: Literal[1] :: Current module Kadabra :: Literal[1] :: <no import required>
AbraKadabra :: Unavailable :: package AbraKadabra :: Unavailable :: package
"); ");
} }
@ -5534,7 +5534,7 @@ def foo(param: s<CURSOR>)
// Even though long_namea is alphabetically before long_nameb, // Even though long_namea is alphabetically before long_nameb,
// long_nameb is currently imported and should be preferred. // long_nameb is currently imported and should be preferred.
assert_snapshot!(snapshot, @r" assert_snapshot!(snapshot, @r"
long_nameb :: Literal[1] :: Current module long_nameb :: Literal[1] :: <no import required>
long_namea :: Unavailable :: foo long_namea :: Unavailable :: foo
"); ");
} }
@ -5804,7 +5804,7 @@ from .imp<CURSOR>
#[test] #[test]
fn typing_extensions_excluded_from_import() { fn typing_extensions_excluded_from_import() {
let builder = completion_test_builder("from typing<CURSOR>").module_names(); let builder = completion_test_builder("from typing<CURSOR>").module_names();
assert_snapshot!(builder.build().snapshot(), @"typing :: Current module"); assert_snapshot!(builder.build().snapshot(), @"typing :: <no import required>");
} }
#[test] #[test]
@ -5823,8 +5823,8 @@ from .imp<CURSOR>
.completion_test_builder() .completion_test_builder()
.module_names(); .module_names();
assert_snapshot!(builder.build().snapshot(), @r" assert_snapshot!(builder.build().snapshot(), @r"
typing :: Current module typing :: <no import required>
typing_extensions :: Current module typing_extensions :: <no import required>
"); ");
} }
@ -5849,8 +5849,8 @@ from .imp<CURSOR>
.completion_test_builder() .completion_test_builder()
.module_names(); .module_names();
assert_snapshot!(builder.build().snapshot(), @r" assert_snapshot!(builder.build().snapshot(), @r"
typing :: Current module typing :: <no import required>
typing_extensions :: Current module typing_extensions :: <no import required>
"); ");
} }
@ -5883,7 +5883,7 @@ foo.ZQ<CURSOR>
.module_names() .module_names()
.build() .build()
.snapshot(); .snapshot();
assert_snapshot!(snapshot, @"ZQZQ :: Current module"); assert_snapshot!(snapshot, @"ZQZQ :: <no import required>");
} }
#[test] #[test]
@ -5925,7 +5925,7 @@ foo.ZQ<CURSOR>
.module_names() .module_names()
.build() .build()
.snapshot(); .snapshot();
assert_snapshot!(snapshot, @"ZQZQ :: Current module"); assert_snapshot!(snapshot, @"ZQZQ :: <no import required>");
} }
#[test] #[test]
@ -6241,7 +6241,7 @@ ZQ<CURSOR>
let module_name = c let module_name = c
.module_name .module_name
.map(ModuleName::as_str) .map(ModuleName::as_str)
.unwrap_or("Current module"); .unwrap_or("<no import required>");
snapshot = format!("{snapshot} :: {module_name}"); snapshot = format!("{snapshot} :: {module_name}");
} }
snapshot snapshot