Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[red-knot] Minor followup on str.startswith (#17362) 

## Summary

Minor follow-up to https://github.com/astral-sh/ruff/pull/17351, thank
you @AlexWaygood.
This commit is contained in:
David Peter 2025-04-11 20:40:08 +02:00 committed by GitHub
parent e5026c0877
commit f0c3abd198
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
crates/red_knot_python_semantic/src/types.rs
View File

@ -3131,12 +3131,16 @@ impl<'db> Type<'db> {
],
)),
Parameter::positional_only(Some(Name::new_static("start")))
// TODO: SupportsIndex | None
.with_annotated_type(Type::object(db))
.with_annotated_type(UnionType::from_elements(
db,
[KnownClass::SupportsIndex.to_instance(db), Type::none(db)],
))
.with_default_type(Type::none(db)),
Parameter::positional_only(Some(Name::new_static("end")))
// TODO: SupportsIndex | None
.with_annotated_type(Type::object(db))
.with_annotated_type(UnionType::from_elements(
db,
[KnownClass::SupportsIndex.to_instance(db), Type::none(db)],
))
.with_default_type(Type::none(db)),
]),
Some(KnownClass::Bool.to_instance(db)),
@ -6188,7 +6192,11 @@ pub enum MethodWrapperKind<'db> {
PropertyDunderGet(PropertyInstanceType<'db>),
/// Method wrapper for `some_property.__set__`
PropertyDunderSet(PropertyInstanceType<'db>),
/// Method wrapper for `str.startswith`
/// Method wrapper for `str.startswith`.
/// We treat this method specially because we want to be able to infer precise Boolean
/// literal return types if the instance and the prefix are both string literals, and
/// this allows us to understand statically known branches for common tests such as
/// `if sys.platform.startswith("freebsd")`.
StrStartswith(StringLiteralType<'db>),
}