Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

minimize more

This commit is contained in:
Douglas Creager 2025-10-17 09:54:36 -04:00
parent a79ba2036b
commit f33ca3a622
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
crates/ty_python_semantic/src/types/constraints.rs
View File

@ -1080,15 +1080,30 @@ impl<'db> InteriorNode<'db> {
#[salsa::tracked(returns(ref), heap_size=ruff_memory_usage::heap_size)] #[salsa::tracked(returns(ref), heap_size=ruff_memory_usage::heap_size)]
fn minimizations(self, db: &'db dyn Db) -> Box<[Node<'db>]> { fn minimizations(self, db: &'db dyn Db) -> Box<[Node<'db>]> {
let constraint = self.constraint(db); let constraint = self.constraint(db);
let if_true = self.if_true(db).minimizations(db); let if_true = self.if_true(db);
let if_false = self.if_false(db).minimizations(db); let if_true_minimizations = if_true.minimizations(db);
let mut minimizations = let if_false = self.if_false(db);
Vec::with_capacity(if_true.as_slice().len() * if_false.as_slice().len()); let if_false_minimizations = if_false.minimizations(db);
for if_true in if_true.as_slice() {
for if_false in if_false.as_slice() { // This node's potential minimizations include each of the minimizations of its true and
// false branches, combined back together into an interior node.
let mut minimizations = Vec::with_capacity(
if_true_minimizations.as_slice().len() * if_false_minimizations.as_slice().len(),
);
for if_true in if_true_minimizations.as_slice() {
for if_false in if_false_minimizations.as_slice() {
minimizations.push(Node::new(db, constraint, *if_true, *if_false)); minimizations.push(Node::new(db, constraint, *if_true, *if_false));
} }
} }
// If either of the original outgoing edges are impossible, we can also skip checking this
// node's variable entirely, and just use the result of the possible edge.
if matches!(if_true, Node::Impossible) {
minimizations.extend_from_slice(if_false_minimizations.as_slice());
} else if matches!(if_false, Node::Impossible) {
minimizations.extend_from_slice(if_true_minimizations.as_slice());
}
minimizations.sort_by_key(|node| node.interior_node_count(db)); minimizations.sort_by_key(|node| node.interior_node_count(db));
minimizations.into_boxed_slice() minimizations.into_boxed_slice()
} }