Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-21 21:40:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

[ty] Make the implicit shadowing message on invalid assignment diagnostic info (#22219)

Browse Source
This commit is contained in:
Matthew Mckee
2025-12-29 09:30:48 +00:00
committed by GitHub
parent 8efa14ae1b
commit fde33baaa5
7 changed files with 17 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
crates/ty_python_semantic/src/types/diagnostic.rs
View File

@@ -2452,29 +2452,25 @@ fn report_invalid_assignment_with_message<'db, 'ctx: 'db, T: Ranged>(
message: std::fmt::Arguments,
) -> Option<LintDiagnosticGuard<'db, 'ctx>> {
let builder = context.report_lint(&INVALID_ASSIGNMENT, node)?;
let mut diag = builder.into_diagnostic(message);
match target_ty {
Type::ClassLiteral(class) => {
let mut diag = builder.into_diagnostic(format_args!(
"Implicit shadowing of class `{}`",
diag.info(format_args!(
"Implicit shadowing of class `{}`, add an annotation to make it explicit if this is intentional",
class.name(context.db()),
));
diag.info("Annotate to make it explicit if this is intentional");
Some(diag)
}
Type::FunctionLiteral(function) => {
let mut diag = builder.into_diagnostic(format_args!(
"Implicit shadowing of function `{}`",
diag.info(format_args!(
"Implicit shadowing of function `{}`, add an annotation to make it explicit if this is intentional",
function.name(context.db()),
));
diag.info("Annotate to make it explicit if this is intentional");
Some(diag)
}
_ => {
let diag = builder.into_diagnostic(message);
Some(diag)
}
_ => {}
}
Some(diag)
}
pub(super) fn report_invalid_assignment<'db>(