976 Commits

Author	SHA1	Message	Date
Charlie Marsh	e0bccfd2d9	Allow legacy C and T selectors in JSON schema (#3889)	2023-04-05 17:58:36 +00:00
Tom Kuson	7b6e55a2e0	Add documentation for `flake8-type-checking` (#3886)	2023-04-05 17:30:25 +00:00
Charlie Marsh	255b094b33	Bump version to 0.0.261 (#3881)	2023-04-04 22:31:01 -04:00
Dhruv Manilawala	b6155232ac	Consider logger candidate from `logging` module only (#3878)	2023-04-04 19:52:57 +00:00
kyoto7250	390d7dcf39	Supports more cases in `SIM112` (#3876)	2023-04-04 15:49:24 -04:00
Charlie Marsh	d919adc13c	Introduce a `ruff_python_semantic` crate (#3865)	2023-04-04 16:50:47 +00:00
kyoto7250	46bcb1f725	[`flake8-simplify`] Implement `dict-get-with-none-default` (`SIM910`) (#3874)	2023-04-04 03:52:10 +00:00
Dhruv Manilawala	2b21effa77	fixup! Support mutually exclusive branches for `B031` (#3844) (#3875)	2023-04-03 23:34:11 -04:00
Chris Chan	10504eb9ed	Generate `ImportMap` from module path to imported dependencies (#3243)	2023-04-04 03:31:37 +00:00
Dhruv Manilawala	76e111c874	Support mutually exclusive branches for `B031` (#3844)	2023-04-04 02:33:17 +00:00
Charlie Marsh	60f6a8571a	Allow starred arguments in B030 (#3871)	2023-04-03 23:20:34 +00:00
Charlie Marsh	f4173b2a93	Move shadow tracking into `Scope` directly (#3854)	2023-04-03 15:33:44 -04:00
Charlie Marsh	449e08ed08	Rename `autofix::helpers` to `autofix::actions` (#3866)	2023-04-03 13:34:49 -04:00
Charlie Marsh	5625410936	Remove `uses_magic_variable_access` dependence on `Checker` (#3864)	2023-04-03 12:22:06 -04:00
Charlie Marsh	3744e9ab3f	Remove `contains_effect`'s dependency on `Context` (#3855)	2023-04-03 12:08:13 -04:00
Nazia Povey	849091d846	When checking module visibility, don't check entire ancestry (#3835)	2023-04-03 11:38:41 -04:00
Ran Benita	d2f2544f6e	flake8-pyi: fix PYI015 false positive on assignment of TypeVar & friends (#3861)	2023-04-03 11:28:46 -04:00
Charlie Marsh	25771cd4b9	Use references for `Export` binding type (#3853)	2023-04-03 15:26:42 +00:00
Charlie Marsh	924bebbb4a	Change "indexes" to "indices" in various contexts (#3856)	2023-04-02 23:08:03 +00:00
Charlie Marsh	08e5b3fa61	Make `collect_call_path` return an `Option` (#3849)	2023-04-01 22:29:32 -04:00
Charlie Marsh	d822e08111	Move `CallPath` into its own module (#3847)	2023-04-01 11:25:04 -04:00
Charlie Marsh	2f90157ce2	Move logging resolver into `logging.rs` (#3843)	2023-04-01 03:50:44 +00:00
Charlie Marsh	88308ef9cc	Move `Binding` structs out of `scope.rs` (#3842)	2023-03-31 23:49:48 -04:00
Charlie Marsh	6d80c79bac	Combine `operations.rs` and `helpers.rs` (#3841)	2023-04-01 03:40:34 +00:00
Charlie Marsh	2fbc620ad3	Move `__all__` utilities to `all.rs` (#3840)	2023-04-01 03:31:15 +00:00
Charlie Marsh	27e40e9b31	Remove `helpers.rs` dependency on `Binding` (#3839)	2023-04-01 03:19:45 +00:00
Charlie Marsh	b6276e2d95	Move f-string identification into rule module (#3838)	2023-03-31 23:10:11 -04:00
Charlie Marsh	66d72b1c7b	Move keyword checks into `is_identifier` (#3834)	2023-03-31 16:56:33 -04:00
Jonathan Plasse	968c7df770	Fix `is_module_name()` and improve perf of `is_identifier()` (#3795)	2023-03-31 15:15:36 -04:00
Jonathan Plasse	fe38597279	Fix `SIM222` and `SIM223` false positive (#3832)	2023-03-31 14:50:35 -04:00
Micha Reiser	48d8680e71	Ambiguous unicode, only test unicode characters (#3814)	2023-03-31 18:03:00 +01:00
Charlie Marsh	82584ad101	Extend `unncessary-generator-any-all` to set comprehensions (#3824)	2023-03-31 16:29:25 +00:00
Charlie Marsh	dfc872c9a0	Track star imports on `Scope` directly (#3822)	2023-03-31 15:01:12 +00:00
Charlie Marsh	cf7e1ddd08	Remove some `usize` references (#3819)	2023-03-30 17:35:42 -04:00
Charlie Marsh	9de1f82658	Avoid `unnecessary-comprehension-any-all` for async generators (#3823)	2023-03-30 18:43:59 +00:00
Charlie Marsh	54ad9397e5	Flag non-`Name` expressions in `duplicate-isinstance-call` (#3817)	2023-03-30 12:19:53 -04:00
Jonathan Plasse	29c8b75fd4	Ignore `collapsible-if` violations for `if False:` and `if True:` (#3732)	2023-03-30 15:52:43 +00:00
Charlie Marsh	0b586d5451	Use `panic` instead of `unreachable` for invalid arguments (#3816)	2023-03-30 15:40:53 +00:00
Charlie Marsh	01357f62e5	Add import insertion support to autofix capabilities (#3787)	2023-03-30 15:33:46 +00:00
Micha Reiser	d7113d3995	refactor: `StateMachine` use `match` statement (#3811)	2023-03-30 15:55:54 +02:00
Charlie Marsh	f79506f5a4	Move some generic structs out of `isort` (#3788)	2023-03-30 08:58:01 -04:00
Dhruv Manilawala	44ae3237b8	Additional simple magic return types (#3805)	2023-03-30 08:57:49 -04:00
konstin	f4cda31708	Use crates.io version of pep440_rs (#3812) ... * Use crates.io version of pep440_rs * Update Cargo.lock	2023-03-30 12:47:07 +00:00
Charlie Marsh	4328448a2f	Use multi-fix semantics for `inplace` removal (#3804)	2023-03-30 00:16:43 +00:00
Charlie Marsh	88298759ce	Misc. follow-up changes to #3802 (#3803)	2023-03-29 19:18:36 -04:00
Charlie Marsh	3c0e789b19	Improve robustness of argument removal for `encode` calls (#3802)	2023-03-29 23:07:13 +00:00
Charlie Marsh	8601dcc09b	Add import name resolution to `Context` (#3777)	2023-03-29 21:47:50 +00:00
Charlie Marsh	134fdd1609	Remove star-import handling from `sys-exit-alias` (#3776)	2023-03-29 21:33:50 +00:00
Charlie Marsh	2e6eddc7bd	Improve top-of-file insertions for required imports (#3779)	2023-03-29 21:25:39 +00:00
Jonathan Plasse	cb588d1d6d	Allow `TID252` to fix all valid module paths (#3796)	2023-03-29 15:13:12 -04:00
Charlie Marsh	9d3b8eb67b	Bump version to v0.0.260 (#3799)	2023-03-29 14:51:50 -04:00
Andy Freeland	7d962bf80c	[`flake8-bugbear`] Allow `pathlib.Path()` in `B008` (#3794)	2023-03-29 15:42:43 +00:00
Micha Reiser	595cd065f3	Reduce explcit clones (#3793)	2023-03-29 15:15:14 +02:00
Anže Starič	b6f1fed424	[`isort`]: support submodules in known_(first|third)_party config options (#3768)	2023-03-29 03:53:38 +00:00
Jonathan Plasse	5501fc9572	Exempt return with side effects for TRY300 (#3780)	2023-03-28 19:52:05 -04:00
Leiser Fernández Gallo	224e85c6d7	Implement `flake8-gettext` (#3785)	2023-03-28 23:32:02 +00:00
Charlie Marsh	f322bcd2bd	Minor nits on reference names (#3786)	2023-03-28 22:18:19 +00:00
Charlie Marsh	22d5b0071d	Rename `end_of_statement` to `end_of_last_statement` (#3775)	2023-03-28 12:31:06 -04:00
Charlie Marsh	990b378c4d	Set parents even in same-line cases (#3773)	2023-03-28 12:09:30 -04:00
Charlie Marsh	e88fbae926	Use import alias locations for `pep8-naming` import rules (#3772)	2023-03-28 11:41:23 -04:00
Charlie Marsh	81de3a16bc	Include `with` statements in complexity calculation (#3771)	2023-03-28 15:20:22 +00:00
Andy Freeland	bfecf684ce	[`flake8-bugbear`] Add more immutable functions for `B008` (#3764)	2023-03-28 10:50:05 -04:00
konstin	756e9956a2	Fix `cargo test --doc` (#3766)	2023-03-28 11:36:07 +00:00
Micha Reiser	f68c26a506	perf(pycodestyle): Initialize Stylist from tokens (#3757)	2023-03-28 11:53:35 +02:00
Micha Reiser	000394f428	perf(pycodestyle): Introduce TokenKind (#3745)	2023-03-28 11:22:39 +02:00
Micha Reiser	2fdf98ef4e	perf(pycodestyle): Refactor checks to iterate over tokens insteadof text (#3736)	2023-03-28 10:37:13 +02:00
Micha Reiser	1d724b1495	perf(pycodestyle): Remove regex captures (#3735)	2023-03-28 09:50:34 +02:00
Micha Reiser	113a8b8fda	perf(pycodestyle): Reduce allocations when computing logical lines (#3715)	2023-03-28 09:09:27 +02:00
Charlie Marsh	c3917eab38	Revert "Implement `flake8-i18n` (#3741)" (#3765)	2023-03-27 21:14:38 +00:00
JBLDSKY	0eb5a22dd1	[`flake8-pyi`] Implement `PYI012` (#3743)	2023-03-27 18:27:24 +00:00
Charlie Marsh	450c6780ff	Avoid `useless-import alias` (`C0414`) in `.pyi` files (#3761)	2023-03-27 18:27:03 +00:00
Leiser Fernández Gallo	5cb120327c	Implement `flake8-i18n` (#3741)	2023-03-27 18:03:39 +00:00
trag1c	8dbffb576d	Removed unnecessary pipe escape (#3760)	2023-03-27 13:49:47 -04:00
Charlie Marsh	31fff4b10e	Disallow some restriction lints (#3754)	2023-03-26 23:20:20 +00:00
Jonathan Plasse	2326335f5c	Improve performance of statistics (#3751)	2023-03-26 18:46:44 -04:00
Charlie Marsh	6ed6da3e82	Move `fix::FixMode` to `flags::FixMode` (#3753)	2023-03-26 21:40:06 +00:00
Jonathan Plasse	cd75b57036	Sort statistics by count (#3748)	2023-03-26 16:45:35 -04:00
Charlie Marsh	e603382cf0	Allow diagnostics to generate multi-edit fixes (#3709)	2023-03-26 16:45:19 -04:00
Charlie Marsh	32be63fd1e	Avoid overlong-line errors for lines that end with URLs (#3663)	2023-03-26 18:17:35 +00:00
Jonathan Plasse	d594179275	Fix `SIM222` and `SIM223` false negatives (#3740)	2023-03-26 18:09:11 +00:00
Agriya Khetarpal	c0befb4670	Use `wild::args()` and add `wild` as a dependency (#3739)	2023-03-26 14:32:45 +00:00
Charlie Marsh	a66481ed28	Rename setter methods on `Diagnostic` (#3738)	2023-03-26 10:28:30 -04:00
Charlie Marsh	5c7898124f	Traverse over nested string type annotations (#3724)	2023-03-25 21:56:09 -04:00
Jonathan Plasse	50a7916e84	[`pydocstyle`] Implement autofix for `D403` (#3731)	2023-03-25 19:21:45 +00:00
Dhruv Manilawala	2659336ed1	Add support for `.log(level, msg)` calls in `flake8-logging-format` (#3726)	2023-03-25 15:55:53 +00:00
Jonathan Plasse	8ac7584756	[`flake8-pyi`] Implement `PYI015` (#3728)	2023-03-25 15:48:11 +00:00
Jonathan Plasse	4a1740a4c4	[`flake8-pyi`] Add autofix for `PYI014` (#3729)	2023-03-25 15:41:11 +00:00
Charlie Marsh	2083134a96	Rename `Fix` to `Edit` (#3702)	2023-03-24 19:29:14 -04:00
Charlie Marsh	c721eedc37	Remove `'b` lifetime from `Checker` (#3723)	2023-03-24 21:42:18 +00:00
Dhruv Manilawala	c1d89d8c93	[`flake8-bugbear`]: Implement rule `B031` (#3680)	2023-03-24 17:26:11 -04:00
Dhruv Manilawala	63adf9f5e8	Allow aliased `logging` module as a logger candidate (#3718)	2023-03-24 17:19:09 -04:00
Micha Reiser	7af83460ce	Use unicode-width to determine line-length instead of character count (#3714)	2023-03-24 17:17:05 -04:00
Jonathan Plasse	dc4d7619ee	Add `Diagnostic.try_amend()` to simplify error handling (#3701)	2023-03-24 17:10:11 -04:00
Jonathan Plasse	1bac206995	Revert "Replace `logical_lines` feature with `debug_assertions` (#3648)" (#3708)	2023-03-23 23:42:56 -04:00
Jonathan Plasse	efc6e8cb39	Exempt `PLR1711` and `RET501` if non-`None` annotation (#3705)	2023-03-24 03:11:58 +00:00
Jonathan Plasse	7da06b9741	Allow simple container literals as default values (#3703)	2023-03-23 22:51:36 -04:00
Charlie Marsh	0f95056f13	Avoid panics for implicitly concatenated forward references (#3700)	2023-03-23 19:13:50 -04:00
Charlie Marsh	028329854b	Avoid parsing f-strings in type annotations (#3699)	2023-03-23 18:51:44 -04:00
Charlie Marsh	ba43d6bd0b	Avoid parsing `ForwardRef` contents as type references (#3698)	2023-03-23 18:44:02 -04:00
Charlie Marsh	e8d17d23cb	Expand the scope of useless-expression (B018) (#3455)	2023-03-23 18:33:58 -04:00
Jonathan Plasse	aea925a898	Fix SIM118 auto-fix (#3695)	2023-03-23 17:14:56 -04:00
Charlie Marsh	f58345dee3	Bump version to v0.0.259 (#3691)	2023-03-23 14:52:42 -04:00
Charlie Marsh	71c0da27bb	Avoid nested loops in missing_whitespace (#3688)	2023-03-23 14:18:59 -04:00
Charlie Marsh	8a2d1a3029	Respect all rule-exemption sources when suppressing parser errors (#3665)	2023-03-23 13:36:48 -04:00
Micha Reiser	6161e56ea4	Fix RuleSet.remove (#3685)	2023-03-23 17:01:37 +00:00
Charlie Marsh	189c9d4683	Add dedicated structs for `BindingKind` variants (#3672)	2023-03-22 19:08:48 -04:00
Charlie Marsh	615887a7fe	Bump version to v0.0.258 (#3671)	2023-03-22 15:02:57 -04:00
Charlie Marsh	07808a58f2	Refactor out common exemption-parsing logic (#3670)	2023-03-22 15:02:07 -04:00
Ran Benita	fe568c08d2	isort: fix bad interaction between `force-sort-within-sections` and `force-to-top` (#3645)	2023-03-22 14:00:00 -04:00
Charlie Marsh	7741d43ae5	Allow `pairwise` diagnostics for `zip(..., strict=True)` (#3669)	2023-03-22 13:03:43 -04:00
Charlie Marsh	1b3e54231c	Flag, but don't fix, unused imports in `ModuleNotFoundError` blocks (#3658)	2023-03-22 13:03:30 -04:00
Charlie Marsh	3a8e98341b	Enable autofix for annotations within 'simple' string literals (#3657)	2023-03-22 12:45:51 -04:00
kyoto7250	8593739f88	Check indentation level when executing `E231` (#3668)	2023-03-22 12:32:00 -04:00
Charlie Marsh	242dd3dae1	Rename remaining `use-*` rules (#3661)	2023-03-22 11:36:01 -04:00
Charlie Marsh	875f61cb62	Rename `pathlib` rules to match updated naming convention (#3660)	2023-03-22 11:35:45 -04:00
Dhruv Manilawala	9e61956711	[`flake8-django`]: Implement rule DJ012 (#3659)	2023-03-22 03:07:58 +00:00
Jonathan Plasse	5eae3fbbfb	Avoid `RUF007` fixes for more than two arguments (#3654)	2023-03-21 22:17:31 +00:00
Colin Delahunty	41e38ffa98	[`flake8-bandit`]: Implement deny-list rules for suspicious member calls (#3239)	2023-03-21 15:11:52 -04:00
Charlie Marsh	27903cdb11	Replace `logical_lines` feature with `debug_assertions` (#3648)	2023-03-21 12:16:41 -04:00
Charlie Marsh	3b1709ba1e	Avoid attempting infinite open fix with re-bound builtin (#3650)	2023-03-21 15:32:31 +00:00
Dhruv Manilawala	33394e4a69	docs: all `flake8-comprehension` rules (#3631)	2023-03-21 14:28:19 +00:00
Charlie Marsh	7b9bdc494a	Consider same-site fixes to be overlapping (#3638)	2023-03-21 10:09:47 -04:00
Micha Reiser	f59a22b6e5	Remove unused dependencies (#3644)	2023-03-21 11:02:41 +01:00
Jonathan Plasse	b5edc6dfc9	Add autofix functionality for `F523` (#3613)	2023-03-21 03:55:23 +00:00
Charlie Marsh	626169e2ef	Avoid raising PEP 604 errors with forward-referenced members (#3640)	2023-03-20 23:49:41 -04:00
Charlie Marsh	e9f359ac5e	Convert single-argument %-style format calls (#3600)	2023-03-21 03:35:10 +00:00
Jacob Latonis	318c2c80e2	`pylint`: Implement `binary-op-exception` (`PLW0711`) (#3639)	2023-03-21 03:33:40 +00:00
Jonathan Plasse	22a4ab51f9	Handle `UP032` autofix with adjacent keywords (#3636)	2023-03-21 00:17:45 +00:00
Jonathan Plasse	f70a49ed8b	Add autofix for magic methods (`ANN204`) (#3633)	2023-03-20 19:19:20 -04:00
Charlie Marsh	f039bf36a2	Avoid trimming escaped whitespace in D210 (#3635)	2023-03-20 17:17:42 -04:00
Jonathan Plasse	169dd72328	Fix TRY300 false positive (#3634)	2023-03-20 20:55:28 +00:00
Jonathan Plasse	fd39ec4bdd	Merge Availability and AutofixKind (#3629)	2023-03-20 16:45:33 +00:00
Charlie Marsh	7c0f17279c	Flag PEP 585 and PEP 604 violations in quoted annotations (#3593)	2023-03-20 11:15:44 -04:00
konstin	81d0884974	Add basic jupyter notebook support (#3440) ... * Add basic jupyter notebook support behind a feature flag * Address review comments * Rename in separate commit to make both git and clippy happy * cfg(feature = "jupyter_notebook") another test * Address more review comments * Address more review comments * and clippy and windows * More review comment	2023-03-20 12:06:01 +01:00
Jacob Latonis	a45753f462	[`pylint`]: Implement `assert-on-string-literal` (`W0129`) (#3610)	2023-03-19 23:45:51 -04:00
Zhengbo Wang	b08326162b	Doc/CLN: pass pre-commit (#3604)	2023-03-19 19:20:11 +00:00
Dhruv Manilawala	3a65af4dae	feat: update C416 with dict comprehension (autofixable) (#3605)	2023-03-19 18:37:28 +00:00
Ville Lindholm	474aa0b196	Fix infinite loop due to rules `D207` & `W605` (#3609)	2023-03-19 18:29:13 +00:00
Charlie Marsh	4892167217	Avoid panics for implicitly-concatenated docstrings (#3584) ... ## Summary In the rare event that a docstring contains an implicit string concatenation, we currently have the potential to panic, because we assume that if a string starts with triple quotes, it _ends_ with triple quotes. But with implicit concatenation, that's not the case: a single `Expr` could start and end with different quote styles, because it can contain multiple string tokens. Supporting these "properly" is pretty hard. In some cases it's hard to even know what the "right" behavior is. So for now, I'm just detecting and warning, which is better than a panic. Closes #3543. Closes #3585.	2023-03-19 14:16:50 -04:00
Micha Reiser	a5494b8541	Bitflag based RuleSet (#3606)	2023-03-19 17:09:06 +01:00
Micha Reiser	9ac9a1c69e	Gracefully handle lint panics (#3509)	2023-03-19 17:08:38 +01:00
Rogdham	f06dff8af8	Change broken links in README to beta.ruff.rs (#3607)	2023-03-19 15:17:44 +00:00
Charlie Marsh	fe7443ce2f	Use `any_enabled` in AST checker (#3601)	2023-03-19 10:44:33 -04:00
Charlie Marsh	4ffcd8366a	Rename a variety of rules to match updated conventions (#3283)	2023-03-18 17:35:59 -04:00
Charlie Marsh	dfb772c6f1	Avoid removing comment hash for noqa's with trailing content (#3589)	2023-03-18 18:48:52 +00:00
Jonathan Plasse	c21eb06922	Fix D417 false positive (#3596)	2023-03-18 13:14:03 -04:00
Charlie Marsh	fa04861724	Check exclusions prior to resolving `pyproject.toml` files (#3588)	2023-03-18 13:12:49 -04:00
Charlie Marsh	0c4926ff7b	Bump version to v0.0.257 (#3591)	2023-03-17 22:34:10 -04:00
tomecki	61653b9f27	[`pylint`] Implement `useless-return` (`R1711`) (#3116)	2023-03-17 18:30:32 -04:00
Charlie Marsh	8dd3959e74	Update output in `resources/test/project/README.md` (#3587)	2023-03-17 21:51:03 +00:00
Charlie Marsh	50f9db21da	Enable ANSI colors on Windows 10 (#3583)	2023-03-17 17:34:39 -04:00
Tomer Chachamu	1dd3cbd047	[`pylint`] invalid-characters-* (#3552)	2023-03-17 19:30:41 +00:00
Johan	bd935cbd49	[`flake8-bugbear`] Add `no-explicit-stacklevel` (`B028`) (#3550)	2023-03-17 19:20:08 +00:00
Charlie Marsh	babd0a05ac	Avoid adding dashed line outside of docstring (#3581)	2023-03-17 14:40:32 -04:00
Micha Reiser	87fab4a2e1	Benchmark all rules (#3570)	2023-03-17 19:29:39 +01:00
Charlie Marsh	2e21920adf	Respect `type` overrides in E721 (#3582)	2023-03-17 14:29:05 -04:00
Micha Reiser	dedf4cbdeb	refactor: Move scope and binding types to `scope.rs` (#3573)	2023-03-17 17:31:33 +01:00
Micha Reiser	92179e6369	Scope and Binding IDs (#3572)	2023-03-17 17:12:27 +01:00
Evan Rittenhouse	33d2457909	Prefer `itertools.pairwise()` over `zip()` for successive pairs (`RUF007`) (#3501)	2023-03-16 23:50:45 -04:00
Charlie Marsh	373a77e8c2	Avoid C1901 violations within subscripts (#3517)	2023-03-17 02:52:05 +00:00
Jacob Latonis	73df267635	[`pylint`]: Implement `continue-in-finally` (`E0116`) (#3541)	2023-03-17 02:47:49 +00:00
Jonathan Plasse	f5e5caaa25	Fix autofix conflict between `D209` and `D400` (#3564)	2023-03-17 02:36:25 +00:00
Charlie Marsh	e0df62b841	Rewrite mock import with starred imports (#3566)	2023-03-16 20:54:29 -04:00
Micha Reiser	eff84442bc	refactor: Add Copy implementation to Rule (#3556)	2023-03-16 17:50:18 +01:00
Edgar R. M	9ae9cc9d2f	Use `value > max` style in pylint and mccabe messages (#3553)	2023-03-16 01:37:25 -04:00
Charlie Marsh	e636c5fcf0	Avoid unused argument violations in .pyi files (#3533)	2023-03-15 03:17:19 +00:00
Charlie Marsh	12dfd57211	Bump version to v0.0.256 (#3531)	2023-03-14 22:52:21 -04:00
Charlie Marsh	d188d242a0	Avoid tracking as-imports separately with force-single-line (#3530)	2023-03-15 02:26:01 +00:00
Charlie Marsh	57796c5e59	Add last remaining deprecated typing imports (#3529)	2023-03-15 00:08:09 +00:00
Charlie Marsh	2545869797	Avoid PEP 604 isinstance errors for starred tuples (#3527)	2023-03-14 22:08:43 +00:00
Charlie Marsh	58353a4bf4	Avoid PEP 604 panic with empty tuple (#3526)	2023-03-14 22:02:15 +00:00
Charlie Marsh	a36139ae21	Replicate inline comments when splitting single-line imports (#3521)	2023-03-14 14:48:12 -04:00
Jonathan Plasse	7e904111b1	Fix PYI011 and add auto-fix (#3492)	2023-03-14 14:43:09 -04:00
Charlie Marsh	344daebb1b	Refine complexity rules for try-except-else-finally (#3519)	2023-03-14 14:40:33 -04:00
Charlie Marsh	432059de35	Allow `# ruff:` prefix for isort action comments (#3493)	2023-03-14 14:34:28 -04:00
Charlie Marsh	c50d6da8b4	Allow string percent formatting in os.getenv (#3518)	2023-03-14 14:27:21 -04:00
Charlie Marsh	1b738f88c4	Allow f-strings and concatenations in os.getenv (#3516)	2023-03-14 17:46:34 +00:00
Charlie Marsh	1eff3dffa5	Ensure that redirect warnings appear exactly once per code (#3500)	2023-03-14 15:22:14 +00:00
Charlie Marsh	106a93eab0	Make Clap an optional feature for ruff crate (#3498)	2023-03-14 11:02:05 -04:00
Micha Reiser	d5700d7c69	Add Micro Benchmark (#3466)	2023-03-14 08:35:07 +01:00
Grzegorz Bokota	a82fe4a139	Fix lack of `not` in `PLC1901` error message (#3497)	2023-03-13 19:19:41 -04:00
Charlie Marsh	62ff3b62e3	Add `requires-python` inference to docs (#3495)	2023-03-13 18:14:39 -04:00
Charlie Marsh	1e5db58b7b	Include individual path checks in --verbose logging (#3489)	2023-03-13 17:13:47 -04:00
Charlie Marsh	a6e998d639	Remove Wasm-specific Rayon workarounds (#3490)	2023-03-13 16:48:43 -04:00
Charlie Marsh	a8c1915e2e	Remove erroneous C4-to-C40 redirect (#3488)	2023-03-13 19:52:05 +00:00
Xuehai Pan	c515a1b31a	PYI011: allow `math` constants in defaults (#3484)	2023-03-13 14:23:00 -04:00
Charlie Marsh	aa97a092bd	Bump version to v0.0.255 (#3485)	2023-03-13 14:06:51 -04:00
Micha Reiser	685c242761	refactor(ruff_python_ast): Split `get_argument` (#3478)	2023-03-13 18:18:25 +01:00
Jonathan Plasse	b540407b74	Infer target-version from project metadata (#3470) ... * Infer target-version from project metadata * Fix requires-python with ">=3.8.16" * Load requires-python at runtime * Use upstream VersionSpecifiers * Add debug information when parsing ruff.toml * Display debug only if target_version is not set * Bump pep440-rs to add impl Error for Pep440Error	2023-03-13 18:16:01 +01:00
Charlie Marsh	3a5fbd6d74	Upgrade RustPython to fix Serde dependency (#3481)	2023-03-13 12:29:31 -04:00
Charlie Marsh	227679b5cb	Re-enable the T and C linter prefix selectors (#3452)	2023-03-13 08:20:30 -04:00
Charlie Marsh	c2750a59ab	Implement an iterator for universal newlines (#3454) ... # Summary We need to support CR line endings (as opposed to LF and CRLF line endings, which are already supported). They're rare, but they do appear in Python code, and we tend to panic on any file that uses them. Our `Locator` abstraction now supports CR line endings. However, Rust's `str#lines` implementation does _not_. This PR adds a `UniversalNewlineIterator` implementation that respects all of CR, LF, and CRLF line endings, and plugs it into most of the `.lines()` call sites. As an alternative design, it could be nice if we could leverage `Locator` for this. We've already computed all of the line endings, so we could probably iterate much more efficiently? # Test Plan Largely relying on automated testing, however, also ran over some known failure cases, like #3404.	2023-03-13 00:01:29 -04:00
Charlie Marsh	2a4d6ab3b2	Remove unnecessary `Path::new` from `fs` calls (#3476)	2023-03-12 23:18:23 -04:00
Charlie Marsh	7a80bcec58	Output GitLab paths relative to `CI_PROJECT_DIR` (#3475)	2023-03-13 03:03:37 +00:00
Charlie Marsh	8955e32b5c	Respect ignores for runtime-import-in-type-checking-block (TCH004) (#3474)	2023-03-13 02:23:26 +00:00
Jacob Latonis	675227db5c	pylint: E1507 invalid-envvar-value (#3467)	2023-03-12 21:43:06 +00:00
Charlie Marsh	a65c6806a6	Avoid respecting noqa directives when RUF100 is enabled (#3469)	2023-03-12 14:37:35 -04:00
Xuehai Pan	9858df1ac9	[FIX] PYI011: recognize `Bool` / `Float` / `Complex` numbers as simple defaults (#3459)	2023-03-12 17:34:09 +00:00
Charlie Marsh	7fb7268e8a	Use a hash to fingerprint GitLab CI output (#3456)	2023-03-12 00:22:39 -05:00
Jacob Latonis	0f78f27713	pylint: W1508 invalid-envvar-default (#3449)	2023-03-11 16:44:42 -05:00
Charlie Marsh	12a6fc7041	Avoid removing un-aliased exceptions in `OSError`-aliased handlers (#3451)	2023-03-11 15:24:11 -05:00
Micha Reiser	d2988043af	perf: Optimize UTF8/ASCII byte offset index (#3439)	2023-03-11 13:12:10 +01:00
Micha Reiser	cc8b13d3a7	refactor: Replace `Vec` in options metadata with static array (#3433)	2023-03-11 09:03:56 +00:00
Charlie Marsh	1e081cf9a6	Flag deprecated (but renamed) imports in UP035 (#3448)	2023-03-11 01:06:32 -05:00
Charlie Marsh	841bcf1cdd	Remove unnecessary Serde derives (#3447)	2023-03-11 00:16:51 -05:00
Jonathan Plasse	8b561313aa	Remove empty line after RUF100 auto-fix (#3414)	2023-03-10 22:57:13 +00:00
Florian Best	a3aeec6377	docs(pycodestyle): document rules (#3407)	2023-03-10 22:36:38 +00:00
Micha Reiser	b983d5eb3f	fix: method `red` not found in release builds (#3434)	2023-03-10 10:17:35 +01:00
kyoto7250	bb3bb24b59	Autofix PIE810 rule violations (#3411)	2023-03-10 05:17:22 +00:00
Charlie Marsh	872829ca72	When "Args" and "Parameters" are present, prefer NumPy style (#3430)	2023-03-10 02:58:05 +00:00
Charlie Marsh	2383228709	Respect `--show-fixes` with `--fix-only` (#3426)	2023-03-09 21:37:39 +00:00
Aryaman Marathe	952307d39d	[`pylint`] C1901: compare-to-empty-string (#3405)	2023-03-09 21:33:34 +00:00
Charlie Marsh	024caca233	Introduce a `ruff_diagnostics` crate (#3409) ... ## Summary This PR moves `Diagnostic`, `DiagnosticKind`, and `Fix` into their own crate, which will enable us to further split up Ruff, since sub-linter crates (which need to implement functions that return `Diagnostic`) can now depend on `ruff_diagnostics` rather than Ruff.	2023-03-09 20:48:57 +00:00
DanCardin	08ec11a31e	fix: Emit a more useful error if an `extend` points at a non-existent ruff.toml file. (#3417)	2023-03-09 19:55:09 +00:00
Micha Reiser	bd05a8a74d	fix: WASM tests (#3415)	2023-03-09 11:27:59 +01:00
Micha Reiser	229f1c34cb	refactor: Extract `ruff_wasm` (#3401)	2023-03-09 10:07:39 +00:00
Charlie Marsh	a7f3532395	Ignore multiply-assigned variables in RET504 (#3393)	2023-03-08 19:11:55 -05:00
Aaron Cunningham	3349ceb969	[`flake8-bugbear`] Add `flake8-bugbear`'s B030 rule (#3400)	2023-03-08 20:41:29 +00:00
Charlie Marsh	da1f83fe32	Remove `core` module from `ruff_python_formatter` (#3373)	2023-03-08 19:11:39 +00:00
Charlie Marsh	0a9d259f9c	Remove copied `core` modules from `ruff_python_formatter` (#3371)	2023-03-08 19:03:40 +00:00
Charlie Marsh	130e733023	Implement `From<Located>` for `Range` (#3377)	2023-03-08 18:50:20 +00:00
Charlie Marsh	ff2c0dd491	Use shared `leading_quote` implementation in ruff_python_formatter (#3396)	2023-03-08 18:21:59 +00:00
Charlie Marsh	dfe1cad928	Rename `DiagnosticKind#commit` to `DiagnosticKind#suggestion` (#3397)	2023-03-08 18:06:19 +00:00
Charlie Marsh	ffad0bcdaa	Decouple `Diagnostic` from "all violations" enumeration (#3352)	2023-03-08 17:51:37 +00:00
Jonathan Plasse	bc869d4f52	Fix PIE802 broken auto-fix with trailing comma (#3402)	2023-03-08 12:49:01 -05:00
Micha Reiser	a3de791f0a	Make `ruff_cli` binary a small wrapper around `lib` (#3398)	2023-03-08 12:11:55 +01:00
Charlie Marsh	d9dfec30eb	Catch RET504 usages via decorators (#3395)	2023-03-08 00:38:01 +00:00
Charlie Marsh	3f04def3a5	Remap ChainMap, Counter, and OrderedDict imports to collections (#3392)	2023-03-07 23:53:35 +00:00
Charlie Marsh	98177754de	Handle multi-line fixes for byte-string prefixing (#3391)	2023-03-07 23:33:47 +00:00
Charlie Marsh	bad6bdda1f	Create a `rust_python_ast` crate (#3370) ... This PR productionizes @MichaReiser's suggestion in https://github.com/charliermarsh/ruff/issues/1820#issuecomment-1440204423, by creating a separate crate for the `ast` module (`rust_python_ast`). This will enable us to further split up the `ruff` crate, as we'll be able to create (e.g.) separate sub-linter crates that have access to these common AST utilities. This was mostly a straightforward copy (with adjustments to module imports), as the few dependencies that _did_ require modifications were handled in #3366, #3367, and #3368.	2023-03-07 15:18:40 +00:00
Charlie Marsh	a5d302fcbf	Pass `Range` struct by value (#3376)	2023-03-07 09:53:31 -05:00
Charlie Marsh	bced58ce40	Rename `runtime-evaluated-baseclasses` to `runtime-evaluated-base-classes` (#3379)	2023-03-07 09:51:12 -05:00
Aaron Cunningham	10e252e2fb	Updated forced-separate type from Rust to abstract (#3380)	2023-03-07 09:35:39 -05:00
Sasan Jacob Rasti	4dead7541f	Implement configuration options `runtime-evaluated-decorators` and `runtime-evaluated-baseclasses` for `flake8-type-checking` (#3292)	2023-03-06 23:34:19 -05:00
Charlie Marsh	fea1af5a63	Include entire prefix when reporting rule selector errors (#3375)	2023-03-07 00:04:52 +00:00
Charlie Marsh	c0ad875339	Remove unnecessary quote-stripping method (#3372)	2023-03-06 18:28:20 -05:00
Charlie Marsh	8437399496	Remove AST checker's dependency on resolver (#3368)	2023-03-06 21:45:09 +00:00
StefanBRas	074f5634a5	Remove duplicate info in azure format (#3369)	2023-03-06 16:40:03 -05:00
Charlie Marsh	694d41897a	Move `visibility` module into `ast` crate (#3367)	2023-03-06 20:14:47 +00:00
Charlie Marsh	e1ebd9130d	Don't enforce typing-import rules in .pyi files (#3362)	2023-03-06 15:03:34 -05:00
Charlie Marsh	fc8ca6edd2	Remove source_code's dependency on pydocstyle (#3366)	2023-03-06 15:01:01 -05:00
konstin	709dba2e71	Remove old `define_violation!` (in favor of `#[violation]`) (#3310)	2023-03-06 17:00:29 +00:00
Charlie Marsh	d1c48016eb	Rename `ruff_python` crate to `ruff_python_stdlib` (#3354) ... In hindsight, `ruff_python` is too general. A good giveaway is that it's actually a prefix of some other crates. The intent of this crate is to reimplement pieces of the Python standard library and CPython itself, so `ruff_python_stdlib` feels appropriate.	2023-03-06 13:43:22 +00:00
konstin	348a38d261	Deprecate define violation (#3358) ... * Add `#[violation]` proc macro as a replacement for `define_violation!` * Switch all rules to #[violation]	2023-03-06 10:59:06 +00:00
konstin	22e6778e17	Add `cargo dev generate-all --check` and catch outdated docs in `cargo test` (#3320)	2023-03-06 11:28:38 +01:00
StefanBRas	30c71dc59a	Add Azure Devops as a `-format` option. (#3335)	2023-03-06 02:48:39 +00:00
Charlie Marsh	5d8591fec4	Skip byte-order-mark at start of file (#3343)	2023-03-05 21:37:14 -05:00
Carlos Gonçalves	673aa6e90f	feat(e231): add rule + autofix (#3344)	2023-03-05 20:09:35 +00:00
Charlie Marsh	51fe9f7d4b	Treat unary operations on constants as constant-like (#3348)	2023-03-04 16:30:33 -05:00
Charlie Marsh	d7767b2bad	Use u8 to represent ambiguous representants (#3345)	2023-03-04 16:01:05 -05:00
Charlie Marsh	40d3b40c14	Move binding and scope tracking into a separate `ast::Context` struct (#3298)	2023-03-04 14:01:20 -05:00
Jonathan Plasse	8828e12283	Bump dependencies and move more shared dependencies into workspace (#3340)	2023-03-04 12:36:26 -05:00
Charlie Marsh	f13633cc9f	Avoid panicking in invalid_escape_sequence (#3338)	2023-03-04 12:14:33 -05:00
Evan Rittenhouse	889c05c87e	Explicitly put `Path(...)` in Pathlib violations (#3333)	2023-03-04 04:33:12 +00:00
Charlie Marsh	bbbc44336e	Bump version to 0.0.254 (#3331)	2023-03-03 19:11:07 -05:00
Charlie Marsh	d216b2aaa8	Treat callables within type definitions as default-non-types (#3329)	2023-03-03 23:07:30 +00:00
Charlie Marsh	367cc43c42	Un-gate PEP 604 isinstance rewrites from keep_runtime_typing checks (#3328)	2023-03-03 17:29:41 -05:00
Charlie Marsh	b5b26d5a3e	Gate PEP604 isinstance rewrites behind Python 3.10+ (#3327)	2023-03-03 22:22:14 +00:00
Charlie Marsh	dedf8aa5cc	Use presence of convention-specific sections during docstring inference (#3325)	2023-03-03 17:13:11 -05:00
Charlie Marsh	eb42ce9319	Extend `RET503` autofixes to "end of statement", including comments (#3324)	2023-03-03 19:15:55 +00:00
Micha Reiser	cdbe2ee496	refactor: Introduce `CacheKey` trait (#3323) ... This PR introduces a new `CacheKey` trait for types that can be used as a cache key. I'm not entirely sure if this is worth the "overhead", but I was surprised to find `HashableHashSet` and got scared when I looked at the time complexity of the `hash` function. These implementations must be extremely slow in hashed collections. I then searched for usages and quickly realized that only the cache uses these `Hash` implementations, where performance is less sensitive. This PR introduces a new `CacheKey` trait to communicate the difference between a hash and computing a key for the cache. The new trait can be implemented for types that don't implement `Hash` for performance reasons, and we can define additional constraints on the implementation: For example, we'll want to enforce portability when we add remote caching support. Using a different trait further allows us not to implement it for types without stable identities (e.g. pointers) or use other implementations than the standard hash function.	2023-03-03 18:29:49 +00:00
konstin	3bcffb5bdd	Add flake-pyi PYI033 "Do not use type comments in stubs" (#3302)	2023-03-03 10:45:34 -05:00
Martin Packman	98209be8aa	Detect quote style ignoring docstrings (#3306) ... Currently the quote style of the first string in a file is used for autodetecting what to use when rewriting code for fixes. This is an okay heuristic, but often the first line in a file is a docstring, rather than a string constant, and it's not uncommon for pre-Black code to have different quoting styles for those. For example, in the Google style guide: https://google.github.io/styleguide/pyguide.html > Be consistent with your choice of string quote character within a file. Pick ' or " and stick with it. ... Docstrings must use """ regardless. This branch adjusts the logic to instead skip over any `"""` triple doublequote string tokens. The default, if there are no single quoted strings, is still to use double quote as the style.	2023-03-02 23:59:33 -05:00
Charlie Marsh	a03fa93c3a	Abort when unable to fix relative imports past module root (#3319)	2023-03-03 04:38:51 +00:00
Charlie Marsh	4de3882088	Upgrade RustPython (#3316)	2023-03-02 22:59:29 -05:00
Charlie Marsh	3a98b68dc0	Always include `@classmethod` and `@staticmethod` in decorator lists (#3314)	2023-03-03 03:49:04 +00:00
Carlos Gonçalves	7e291e542d	feat(e225,226,227,228): add rules (#3300)	2023-03-02 22:54:45 +00:00
Carlos Gonçalves	6f649d6579	feat(E211): add rule + autofix (#3313)	2023-03-02 22:48:04 +00:00
Yaroslav Chvanov	508bc605a5	Implement `property-decorators` configuration option for pydocstyle (#3311)	2023-03-02 16:59:56 -05:00
Charlie Marsh	ffdf6e35e6	Treat function type annotations within classes as runtime-required (#3312)	2023-03-02 16:45:26 -05:00
Martin Lehoux	886992c6c2	Replace tuples with type union in isinstance or issubclass calls (#3280)	2023-03-02 15:59:15 -05:00
Charlie Marsh	3ed539d50e	Add a CLI flag to force-ignore noqa directives (#3296)	2023-03-01 22:28:13 -05:00
Charlie Marsh	4a70a4c323	Ignore unused imports in `ModuleNotFoundError` blocks (#3288)	2023-03-01 18:08:37 -05:00
Charlie Marsh	310f13c7db	Redirect `RUF004` to `B026` (#3293)	2023-03-01 13:00:02 -05:00
konstin	2168404fc2	flake8-pyi PYI006 bad version info comparison (#3291) ... Implement PYI006 "bad version info comparison" ## What it does Ensures that you only `<` and `>=` for version info comparisons with `sys.version_info` in `.pyi` files. All other comparisons such as `<`, `<=` and `==` are banned. ## Why is this bad? ```python >>> import sys >>> print(sys.version_info) sys.version_info(major=3, minor=8, micro=10, releaselevel='final', serial=0) >>> print(sys.version_info > (3, 8)) True >>> print(sys.version_info == (3, 8)) False >>> print(sys.version_info <= (3, 8)) False >>> print(sys.version_info in (3, 8)) False ``` Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2023-03-01 18:58:57 +01:00
Charlie Marsh	a032b66c2e	Avoid PEP 585 rewrites when builtins are shadowed (#3286)	2023-02-28 23:25:42 +00:00
Charlie Marsh	af5f7dbd83	Avoid pluralization for single `--add-noqa` result (#3282)	2023-02-28 15:41:18 -05:00
Carlos Gonçalves	074a343a63	feat(E251,E252): add rules (#3274)	2023-02-28 12:02:36 -05:00
Charlie Marsh	c7e09b54b0	Use expression span for yoda-conditions fixes (#3276)	2023-02-28 16:59:02 +00:00
Charlie Marsh	67d1f74587	Avoid raising TRY200 violations within new scopes (#3275)	2023-02-28 11:56:29 -05:00
Matthew Lloyd	1c79dff3bd	Improve the message for PLW2901: use "outer" and "inner" judiciously (#3263)	2023-02-28 16:33:01 +00:00
Charlie Marsh	f5f09b489b	Introduce dedicated CST tokens for other operator kinds (#3267)	2023-02-27 23:54:57 -05:00
Charlie Marsh	061495a9eb	Make BoolOp its own located token (#3265)	2023-02-28 03:43:28 +00:00
Charlie Marsh	470e1c1754	Preserve comments on non-defaulted arguments (#3264)	2023-02-27 23:41:40 +00:00
Charlie Marsh	16be691712	Enable more non-panicking formatter tests (#3262)	2023-02-27 18:21:53 -05:00
Charlie Marsh	270015865b	Don't flag keyword-based logging format strings (#3261)	2023-02-27 23:11:13 +00:00
Charlie Marsh	ccfa9d5b20	Deduplicate SIM116 errors (#3260)	2023-02-27 18:08:45 -05:00
Charlie Marsh	2261e194a0	Create dedicated `Body` nodes in the formatter CST (#3223)	2023-02-27 22:55:05 +00:00
Ville Skyttä	cd6413ca09	Match non-lowercase with S105 again (#3258)	2023-02-27 16:38:23 -05:00
Charlie Marsh	c65585e14a	Use `identifier_range` for a few more rules (#3254)	2023-02-27 18:23:33 +00:00
Charlie Marsh	16e2dae0c2	Handle empty NamedTuple and TypedDict conversions (#3251)	2023-02-27 11:18:34 -05:00
Carlos Gonçalves	e8ba9c9e21	feat(W191): add indentation_contains_tabs (#3249)	2023-02-27 10:36:03 -05:00
Jonathan Plasse	d285f5c90a	Run automatically format code blocks with Black (#3191)	2023-02-27 10:14:05 -05:00
Charlie Marsh	386ca7c9a1	Bump version to 0.0.253 (#3245)	2023-02-26 23:10:04 -05:00
Charlie Marsh	40c5abf16e	Avoid flagging Pylint logging rules with starred arguments (#3244)	2023-02-26 22:58:24 -05:00
Matthew Lloyd	7e7aec7d74	Expand the range of the COM812 autofix to include the preceding token (#3241) ... This prevents the UP034 autofix simultaneously stripping the parentheses from generators in the same linter pass, which causes a SyntaxError. Closes #3234. With this fix: ```python $ cat test.py the_first_one = next( (i for i in range(10) if i // 2 == 0) ) $ cargo run --bin ruff check test.py --no-cache --select UP034,COM812 --fix Finished dev [unoptimized + debuginfo] target(s) in 0.08s Running `target/debug/ruff check test.py --no-cache --select UP034,COM812 --fix` Found 1 error (1 fixed, 0 remaining). $ cat test.py the_first_one = next( i for i in range(10) if i // 2 == 0 ) ``` * Use format --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2023-02-27 03:47:07 +00:00
Ivan Gozali	4b5538f74e	[`pylint`] W0603: `global-statement` (#3227) ... Implements pylint rule [W0603: global-statement](https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/global-statement.html). Currently checks for global statement usage in a few StmtKinds (as tested in the `pylint` `global-statement` test case [here](b70d2abd7f/tests/functional/g/globals.py)): * Assign * AugAssign * ClassDef * FunctionDef | AsyncFunctionDef * Import * ImportFrom * Delete	2023-02-26 23:40:24 +00:00
Chris Chan	0b7d6b9097	Implement pylint's `else-if-used` rule (`PLR5501`) (#3231) ... Attempt to implement else-if-used https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/else-if-used.html Issue #970	2023-02-26 22:42:33 +00:00
Nick Pope	994e2e0903	Rename some `flake8-simplify` rules (#2915) ... Renames the following rules that stood out to me at a glance as needing better names: - `or-true` to `expr-or-true` - `and-false` to `expr-and-false` - `a-or-not-a` to `expr-or-not-expr` - `a-and-not-a` to `expr-and-not-expr` Related to #2902.	2023-02-26 22:35:15 +00:00
Luc Khai Hai	bc79f540e4	[flake8-django] DJ003, DJ006, DJ007 (#3236) ... Implements [flake8-django](https://github.com/rocioar/flake8-django) rules: - DJ03 - DJ06 - DJ07	2023-02-26 22:29:42 +00:00
Steve Dignam	3a78b59314	[flake8-pyi]: PYI011, PYI014 (#3238) ... Implement PYI011 and PYI014 with the latest changes: https://github.com/PyCQA/flake8-pyi/pull/326 https://github.com/PyCQA/flake8-pyi/issues/316 rel: https://github.com/charliermarsh/ruff/issues/848 rel: 4212bec43d/pyi.py (L718)	2023-02-26 22:11:58 +00:00
Edgar R. M	5f83851329	[pydocstyle]: Implement `ignore-decorators` (#3229)	2023-02-26 21:40:01 +00:00
Carlos Gonçalves	484ce7b8fc	feat(E275): add Missing whitespace after keyword (#3225)	2023-02-26 21:36:05 +00:00
Charlie Marsh	1c75071136	Implement basic rendering of remaining AST nodes (#3233)	2023-02-26 05:05:56 +00:00
Charlie Marsh	51bca19c1d	Add builders for common comment rendering (#3232)	2023-02-26 04:16:24 +00:00
Steve Dignam	a8a312e862	[flake8-pyi]: PYI009, PYI010, PYI021 (#3230) ... PYI009 and PYI010 are very similar, always use `...` in function and class bodies in stubs. PYI021 bans doc strings in stubs. I think all of these rules should be relatively straightforward to implement auto fixes for but can do that later once we get all the other rules added. rel: https://github.com/charliermarsh/ruff/issues/848	2023-02-25 22:29:04 -05:00
Ran Benita	33c31cda27	Add `noqa_row` to diagnostics JSON format (#3228) ... In ruff-lsp (https://github.com/charliermarsh/ruff-lsp/pull/76) we want to add a "Disable \<rule\> for this line" quickfix. However, finding the correct line into which the `noqa` comment should be inserted is non-trivial (multi-line strings for example). Ruff already has this info, so expose it in the JSON output for use by ruff-lsp.	2023-02-25 18:13:16 -05:00
Edgar R. M	cd9fbeb560	[bandit]: Do not treat "passed" as "password" for `S105`/`S106`/`S107` (#3222)	2023-02-25 15:32:53 -05:00
Jeong YunWon	84e96cdcd9	More enum work (#3212)	2023-02-25 11:40:16 -05:00
Charlie Marsh	248590224a	Avoid flagging logging-too-few-args with no arguments (#3220)	2023-02-24 21:57:49 -05:00
Charlie Marsh	bbc55cdb04	Allow ruff.toml file to be dot-prefixed (as .ruff.toml) (#3221)	2023-02-24 23:14:26 +00:00
Charlie Marsh	0694aee1b6	Avoid EXE001 and EXE002 errors from stdin input (#3218)	2023-02-24 22:55:32 +00:00
Charlie Marsh	a17b5c134a	Avoid rewriting any PEP 604 runtime annotations (#3217) ... Following `pyupgrade`, we'll just _never_ touch these. Closes #2981. Closes #3215.	2023-02-24 22:39:58 +00:00
Charlie Marsh	42f61535b5	Normalize treatment of aliased and unaliased imports (#3216)	2023-02-24 22:11:03 +00:00
Carlos Gonçalves	1c01b3c934	fix(docs): broken links inside Configuration.md (#3205)	2023-02-24 18:55:33 +00:00
monosans	24add5f56c	Avoid boolean-trap rules for ConfigParser get() methods (#3209)	2023-02-24 12:52:33 -05:00
Samuel Cormier-Iijima	0b7736ad79	[`flake8-tidy-imports`] fix autofix for relative imports (#3197)	2023-02-23 23:40:28 -05:00
Charlie Marsh	eef85067c8	Exclude globsets for --show-settings (#3201)	2023-02-24 04:23:00 +00:00
Jeong YunWon	da98fab4ae	Adapt is-macro for a few enums (#3182)	2023-02-24 04:06:56 +00:00
Charlie Marsh	0f37a98d91	Use then-some pattern for sometimes-fixable rules (#3199)	2023-02-24 03:57:14 +00:00
Charlie Marsh	f38624824d	Avoid autofixing some PT violations when comments are present (#3198)	2023-02-24 03:48:41 +00:00
Charlie Marsh	159422071e	Handle end-of-line comments on `excepthandler` and `alias` (#3196)	2023-02-23 22:35:39 -05:00
Charlie Marsh	6eaacf96be	Introduce a new CST element for slice segments (#3195)	2023-02-24 00:49:41 +00:00
Charlie Marsh	eb15371453	Make Locator available in AST-to-CST conversion pass (#3194)	2023-02-23 19:43:03 -05:00
Matt Nawara	198b301baf	[pycodestyle] trailing-whitespace, blank-line-contains-whitespace (W291, W293) (#3122)	2023-02-23 19:04:45 -05:00
Jeong YunWon	c8c575dd43	Adapt BoolLike to flags (#3175)	2023-02-23 16:31:46 -05:00
Jonathan Plasse	6e54cd8233	Normalize relative markdown links (#3190)	2023-02-23 16:24:31 -05:00
Charlie Marsh	bda2a0007a	Parenthesize numbers during attribute accesses (#3189)	2023-02-23 14:57:23 -05:00
Charlie Marsh	32d165b7ad	Implement complex literal formatting (#3186)	2023-02-23 19:09:33 +00:00
Charlie Marsh	ac79bf4ee9	Implement float literal formatting (#3184)	2023-02-23 14:02:23 -05:00
Charlie Marsh	376eab3a53	Implement integer literal formatting (#3183)	2023-02-23 18:31:56 +00:00
Charlie Marsh	08be7bd285	Add a TODO to string_literal (#3181)	2023-02-23 12:46:20 -05:00
Charlie Marsh	f5241451d8	Use `writeln` with --show-settings (#3180)	2023-02-23 17:23:31 +00:00
Charlie Marsh	09f8c487ea	Update RustPython to support *tuple annotations (#3178)	2023-02-23 16:58:38 +00:00
Charlie Marsh	1e7233a8eb	Add support for reformatting byte strings (#3176)	2023-02-23 16:50:24 +00:00
Charlie Marsh	f967f344fc	Add support for basic `Constant::Str` formatting (#3173) ... This PR enables us to apply the proper quotation marks, including support for escapes. There are some significant TODOs, especially around implicit concatenations like: ```py ( "abc" "def" ) ``` Which are represented as a single AST node, which requires us to tokenize _within_ the formatter to identify all the individual string parts.	2023-02-23 16:23:10 +00:00
Charlie Marsh	095f005bf4	Move RustPython vendored and helper code into its own crate (#3171)	2023-02-23 14:14:16 +00:00
Charlie Marsh	0f04aa2a5f	Bind star patterns in match statements (#3169)	2023-02-23 12:39:03 +00:00
Jonathan Plasse	ad7ba77fff	Fix ExceptionGroup F821 false positive (#3167)	2023-02-23 12:36:11 +00:00
Jeong YunWon	77d43795f8	Replace Autofix::is_enabled to result_like::BoolLike (#3165)	2023-02-23 07:29:13 -05:00
Jeong YunWon	4357f2be0f	Add Autofix::is_enabled() to remove repeative patterns (#3159)	2023-02-22 23:52:07 -05:00
Charlie Marsh	e5c1f95545	Check-in updated snapshot (#3161)	2023-02-23 03:42:27 +00:00
Charlie Marsh	227ff62a4e	Don't touch tuple brackets after `in` (#3160)	2023-02-23 03:10:24 +00:00
Charlie Marsh	d8e4902516	Un-modify `tupleassign` and `function2` tests (#3158) ... I manually changed these in #3080 and #3083 to get the tests passing (with notes around the deviations) -- but that's no longer necessary, now that we have proper testing that takes deviations into account.	2023-02-23 02:37:25 +00:00
Charlie Marsh	5fd827545b	Add a trailing newline to all .py.expect files (#3156) ... This just re-formats all the `.py.expect` files with Black, both to add a trailing newline and be doubly-certain that they're correctly formatted. I also ensured that we add a hard line break after each statement, and that we avoid including an extra newline in the generated Markdown (since the code should contain the exact expected newlines).	2023-02-23 02:29:27 +00:00
Matthew Lloyd	c1ddcb8a60	[flake8-pie] Unnecessary list comprehension, with autofix (PIE802) (#3149)	2023-02-22 20:58:45 -05:00
Charlie Marsh	21d02cd51f	Omit non-.py[i] files from module naming rules (#3153)	2023-02-23 00:38:46 +00:00
Charlie Marsh	b9bfb81e36	Move configuration out of README and into permanent docs (#3150)	2023-02-22 19:25:53 -05:00
Charlie Marsh	2d4fae45d9	Avoid flagging unfixable `TypedDict` and `NamedTuple` definitions (#3148)	2023-02-22 23:23:25 +00:00
Charlie Marsh	726adb7efc	Avoid suggesting 'is' for constant literals (#3146)	2023-02-22 22:37:22 +00:00