3da8b51dc1
[ty] Fix server version ( #19284 )
2025-07-14 09:06:34 +02:00
3ee3434187
Auto-generate environment variable references for ty ( #19205 )
...
## Summary
This PR mirrors the environment variable implementation we have in uv:
efc361223c/crates/uv-static/src/env_vars.rs (L6-L7)https://github.com/astral-sh/ty/issues/773 .
2025-07-08 10:48:31 -04:00
29927f2b59
Update Rust toolchain to 1.88 and MSRV to 1.86 ( #19011 )
2025-06-28 20:24:00 +02:00
23261a38a0
[ty] Add more benchmarks ( #18714 )
2025-06-18 13:41:38 +02:00
3a430fa6da
[ty] Allow overriding rules for specific files ( #18648 )
2025-06-15 14:27:39 +01:00
981bd70d39
Convert `Message::SyntaxError` to use `Diagnostic` internally ( #17784 )
...
## Summary
This PR is a first step toward integration of the new `Diagnostic` type
into ruff. There are two main changes:
- A new `UnifiedFile` enum wrapping `File` for red-knot and a
`SourceFile` for ruff
- ruff's `Message::SyntaxError` variant is now a `Diagnostic` instead of
a `SyntaxErrorMessage`
The second of these changes was mostly just a proof of concept for the
first, and it went pretty smoothly. Converting `DiagnosticMessage`s will
be most of the work in replacing `Message` entirely.
## Test Plan
Existing tests, which show no changes.
---------
Co-authored-by: Carl Meyer <carl@astral.sh>
Co-authored-by: Micha Reiser <micha@reiser.io>
2025-05-08 12:45:51 -04:00
067a8ac574
[ty] Default to latest supported python version ( #17938 )
2025-05-08 16:58:35 +02:00
4f890b2867
[ty] Update salsa ( #17937 )
...
## Summary
* Update salsa to pull in https://github.com/salsa-rs/salsa/pull/850 .
* Some refactoring of salsa event callbacks in various `Db`'s due to
https://github.com/salsa-rs/salsa/pull/849
closes https://github.com/astral-sh/ty/issues/108
## Test Plan
Ran `cargo run --bin ty -- -vvv` on a test file to make sure that salsa
Events are still logged.
2025-05-08 12:02:53 +02:00
e95130ad80
Introduce `TY_MAX_PARALLELISM` environment variable ( #17830 )
2025-05-04 16:27:15 +02:00
9c47b6dbb0
[red-knot] Detect version-related syntax errors ( #16379 )
...
## Summary
This PR extends version-related syntax error detection to red-knot. The
main changes here are:
1. Passing `ParseOptions` specifying a `PythonVersion` to parser calls
2. Adding a `python_version` method to the `Db` trait to make this
possible
3. Converting `UnsupportedSyntaxError`s to `Diagnostic`s
4. Updating existing mdtests to avoid unrelated syntax errors
My initial draft of (1) and (2) in #16090 instead tried passing a
`PythonVersion` down to every parser call, but @MichaReiser suggested
the `Db` approach instead
[here](https://github.com/astral-sh/ruff/pull/16090#discussion_r1969198407 ),
and I think it turned out much nicer.
All of the new `python_version` methods look like this:
```rust
fn python_version(&self) -> ruff_python_ast::PythonVersion {
Program::get(self).python_version(self)
}
```
with the exception of the `TestDb` in `ruff_db`, which hard-codes
`PythonVersion::latest()`.
## Test Plan
Existing mdtests, plus a new mdtest to see at least one of the new
diagnostics.
2025-04-17 14:00:30 -04:00
fb09d63e55
[red-knot] Prefix `Type::call` and `dunder_call` with `try` ( #16261 )
2025-02-20 09:05:04 +00:00
75015b0ed9
Attribute panics to the mdtests that cause them ( #15241 )
...
This updates the mdtest harness to catch any panics that occur during
type checking, and to display the panic message as an mdtest failure.
(We don't know which specific line causes the failure, so we attribute
panics to the first line of the test case.)
2025-01-03 13:45:56 -05:00
c3b6139f39
Upgrade salsa ( #15039 )
...
The only code change is that Salsa now requires the `Db` to implement
`Clone` to create "lightweight" snapshots.
2024-12-17 15:50:33 +00:00
59c0dacea0
Introduce `Diagnostic` trait ( #14130 )
2024-11-07 13:26:21 +01:00
dcfebaa4a8
[red-knot] use declared types in inference/checking ( #13335 )
...
Use declared types in inference and checking. This means several things:
* Imports prefer declarations over inference, when declarations are
available.
* When we encounter a binding, we check that the bound value's inferred
type is assignable to the live declarations of the bound symbol, if any.
* When we encounter a declaration, we check that the declared type is
assignable from the inferred type of the symbol from previous bindings,
if any.
* When we encounter a binding+declaration, we check that the inferred
type of the bound value is assignable to the declared type.
2024-09-17 08:11:06 -07:00
2abfab0f9b
Move Program and related structs to `red_knot_python_semantic` ( #12777 )
2024-08-09 11:50:45 +02:00
ffaa35eafe
Add test helper to setup tracing ( #12741 )
2024-08-09 07:04:04 +00:00
846f57fd15
Update salsa ( #12711 )
2024-08-06 13:17:39 +00:00
e91a0fe94a
[red-knot] Implement basic LSP server ( #12624 )
...
## Summary
This PR adds basic LSP implementation for the Red Knot project.
This is basically a fork of the existing `ruff_server` crate into a
`red_knot_server` crate. The following are the main differences:
1. The `Session` stores a map from workspace root to the corresponding
Red Knot database (`RootDatabase`).
2. The database is initialized with the newly implemented `LSPSystem`
(implementation of `System` trait)
3. The `LSPSystem` contains the server index corresponding to each
workspace and an underlying OS system implementation. For certain
methods, the system first checks if there's an open document in LSP
system and returns the information from that. Otherwise, it falls back
to the OS system to get that information. These methods are
`path_metadata`, `read_to_string` and `read_to_notebook`
4. Add `as_any_mut` method for `System`
**Why fork?**
Forking allows us to experiment with the functionalities that are
specific to Red Knot. The architecture is completely different and so
the requirements for an LSP implementation are different as well. For
example, Red Knot only supports a single workspace, so the LSP system
needs to map the multi-workspace support to each Red Knot instance. In
the end, the server code isn't too big, it will be easier to implement
Red Knot specific functionality without worrying about existing server
limitations and it shouldn't be difficult to port the existing server.
## Review
Most of the server files hasn't been changed. I'm going to list down the
files that have been changed along with highlight the specific part of
the file that's changed from the existing server code.
Changed files:
* Red Knot CLI implementation:
https://github.com/astral-sh/ruff/pull/12624/files#diff-579596339a29d3212a641232e674778c339b446de33b890c7fdad905b5eb50e1
* In
https://github.com/astral-sh/ruff/pull/12624/files#diff-b9a9041a8a2bace014bf3687c3ef0512f25e0541f112fad6131b14242f408db6 ,
server capabilities have been updated, dynamic capability registration
is removed
* In
https://github.com/astral-sh/ruff/pull/12624/files#diff-b9a9041a8a2bace014bf3687c3ef0512f25e0541f112fad6131b14242f408db6 ,
the API for `clear_diagnostics` now take in a `Url` instead of
`DocumentQuery` as the document version doesn't matter when clearing
diagnostics after a document is closed
*
[`did_close`](https://github.com/astral-sh/ruff/pull/12624/files#diff-9271370102a6f3be8defaca40c82485b0048731942520b491a3bdd2ee0e25493 ),
[`did_close_notebook`](https://github.com/astral-sh/ruff/pull/12624/files#diff-96fb53ffb12c1694356e17313e4bb37b3f0931e887878b5d7c896c19ff60283b ),
[`did_open`](https://github.com/astral-sh/ruff/pull/12624/files#diff-60e852cf1aa771e993131cabf98eb4c467963a8328f10eccdb43b3e8f0f1fb12 ),
[`did_open_notebook`](https://github.com/astral-sh/ruff/pull/12624/files#diff-ac356eb5e36c3b2c1c135eda9dfbcab5c12574d1cb77c71f7da8dbcfcfb2d2f1 )
are updated to open / close file from the corresponding Red Knot
workspace
* The [diagnostic
handler](https://github.com/astral-sh/ruff/pull/12624/files#diff-4475f318fd0290d0292834569a7df5699debdcc0a453b411b8c3d329f1b879d9 )
is updated to request diagnostics from Red Knot
* The [`Session::new`] method in
https://github.com/astral-sh/ruff/pull/12624/files#diff-55c96201296200c1cab37c8b0407b6c733381374b94be7ae50563bfe95264e4d
is updated to construct the Red Knot databases for each workspace. It
also contains the `index_mut` and `MutIndexGuard` implementation
* And, `LSPSystem` implementation is in
https://github.com/astral-sh/ruff/pull/12624/files#diff-4ed62bd359c43b0bf1a13f04349dcd954966934bb8d544de7813f974182b489e
## Test Plan
First, configure VS Code to use the `red_knot` binary
1. Build the `red_knot` binary by `cargo build`
2. Update the VS Code extension to specify the path to this binary
```json
{
"ruff.path": ["/path/to/ruff/target/debug/red_knot"]
}
```
3. Restart VS Code
Now, open a file containing red-knot specific diagnostics, close the
file and validate that diagnostics disappear.
2024-08-06 11:27:30 +00:00
e18b4e42d3
[red-knot] Upgrade to the *new* *new* salsa ( #12406 )
2024-07-29 07:21:24 +00:00
f0fc6a95fe
[red-knot] Lazy package file discovery ( #12452 )
...
Co-authored-by: Carl Meyer <carl@astral.sh>
2024-07-23 08:47:15 +00:00
40d9324f5a
[red-knot] Improved file watching ( #12382 )
2024-07-23 08:18:59 +02:00
91338ae902
[red-knot] Add basic workspace support ( #12318 )
2024-07-17 11:34:21 +02:00
5b21922420
[red-knot] Add more stress tests for module resolver invalidation ( #12272 )
2024-07-10 14:34:06 +00:00
ac04380f36
[red-knot] Rename `FileSystem` to `System` ( #12214 )
2024-07-09 07:20:51 +00:00
e2e0889a30
[red-knot] Add very basic benchmark ( #12182 )
2024-07-04 15:29:00 +00:00
1d73d60bd3
[red-knot]: Add a VendoredFileSystem implementation ( #11863 )
...
Co-authored-by: Micha Reiser <micha@reiser.io>
2024-06-18 15:43:39 +00:00
98b13b9844
red-knot: Add a method to resolve a file for an arbitrary `VfsPath` ( #11826 )
...
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
2024-06-18 12:03:30 +00:00
d4dd96d1f4
red-knot: `source_text`, `line_index`, and `parsed_module` queries ( #11822 )
2024-06-13 07:37:02 +00:00
efbf7b14b5
red-knot[salsa part 2]: Setup semantic DB and Jar ( #11837 )
...
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
2024-06-13 08:00:51 +01:00
93973b96cb
red-knot: `VfsFile` input ingredient and a `Vfs` ( #11802 )
2024-06-12 07:06:15 +00:00
Micha Reiser
Charlie Marsh
Brent Westbrook
David Peter
Douglas Creager
Carl Meyer
Dhruv Manilawala
Alex Waygood