Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
13,105 Commits 504 Branches 393 Tags 279 MiB
Commit Graph

7 Commits

Author SHA1 Message Date
Takayuki Maeda 692b7d7f0c
[`ruff`] Skip autofix for keyword and `__debug__` path params (#20960) 
<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->

Fixes #20941

Skip autofix for keyword and __debug__ path params

## Test Plan

<!-- How was it tested? -->

I added two test cases to
crates/ruff_linter/resources/test/fixtures/fastapi/FAST003.py.
 2025-10-20 16:37:20 -07:00
Dan Parizher 537ec5f012
[`fastapi`] Fix false positives for path parameters that FastAPI doesn't recognize (`FAST003`) (#20687) 
## Summary

Fixes #20680

---------

Co-authored-by: Brent Westbrook <brentrwestbrook@gmail.com>
 2025-10-09 16:10:21 -04:00
Dan Parizher 0ff0c70302
[`fastapi`] Fix false positive for paths with spaces around parameters (`FAST003`) (#20077) 
## Summary

Fixes #20060
 2025-08-29 13:40:25 +00:00
Denys Kyslytsyn e677863787
[`fastapi`] Avoid false positive for class dependencies (`FAST003`) (#18271) 
<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

Closes #17226.

This PR updates the `FAST003` rule to correctly handle [FastAPI class
dependencies](https://fastapi.tiangolo.com/tutorial/dependencies/classes-as-dependencies/).
Specifically, if a path parameter is declared in either:

- a `pydantic.BaseModel` used as a dependency, or  
- the `__init__` method of a class used as a dependency,  

then `FAST003` will no longer incorrectly report it as unused.

FastAPI allows a shortcut when using annotated class dependencies -
`Depends` can be called without arguments, e.g.:

```python
class MyParams(BaseModel):
    my_id: int

@router.get("/{my_id}")
def get_id(params: Annotated[MyParams, Depends()]): ...
```
This PR ensures that such usage is properly supported by the linter.

Note: Support for dataclasses is not included in this PR. Let me know if
you’d like it to be added.

## Test Plan

Added relevant test cases to the `FAST003.py` fixture.
 2025-06-02 14:34:50 -04:00
InSync 6f35a4d8d5
[`fastapi`] Handle parameters with `Depends` correctly (`FAST003`) (#15364) 
Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
Co-authored-by: Micha Reiser <micha@reiser.io>
 2025-01-13 08:51:02 +00:00
Charlie Marsh 44d916fb4e
Respect FastAPI aliases in route definitions (#13394) 
## Summary

Closes https://github.com/astral-sh/ruff/issues/13263
 2024-09-18 12:06:49 -04:00
Matthieu LAURENT f121f8b31b
[`fastapi`] Implement `fast-api-unused-path-parameter` (`FAST003`) (#12638) 
This adds the `fast-api-unused-path-parameter` lint rule, as described
in #12632.

I'm still pretty new to rust, so the code can probably be improved, feel
free to tell me if there's any changes i should make.

Also, i needed to add the `add_parameter` edit function, not sure if it
was in the scope of the PR or if i should've made another one.
 2024-08-16 01:46:35 +00:00