907047bf4b
[red-knot] Add tests for member lookup on union types ( #14296 )
...
## Summary
- Write tests for member lookups on union types
- Remove TODO comment
part of: #14022
## Test Plan
New MD tests
2024-11-12 14:11:55 +01:00
13a1483f1e
[`flake8-pyi`] Add "replace with `Self`" fix (`PYI019`) ( #14238 )
...
Co-authored-by: Micha Reiser <micha@reiser.io>
2024-11-12 11:13:15 +00:00
be69f61b3e
[`flake8-simplify`] Infer "unknown" truthiness for literal iterables whose items are all unpacks (`SIM222`) ( #14263 )
...
## Summary
Resolves #14237 .
## Test Plan
`cargo nextest run` and `cargo insta test`.
---------
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
2024-11-11 15:23:34 -05:00
f1f3bd1cd3
[red-knot] Review remaining 'possibly unbound' call sites ( #14284 )
...
## Summary
- Emit diagnostics when looking up (possibly) unbound attributes
- More explicit test assertions for unbound symbols
- Review remaining call sites of `Symbol::ignore_possibly_unbound`. Most
of them are something like `builtins_symbol(self.db,
"Ellipsis").ignore_possibly_unbound().unwrap_or(Type::Unknown)` which
look okay to me, unless we want to emit additional diagnostics. There is
one additional case in enum literal handling, which has a TODO comment
anyway.
part of #14022
## Test Plan
New MD tests for (possibly) unbound attributes.
2024-11-11 20:48:49 +01:00
3bef23669f
[red-knot] Diagnostic for possibly unbound imports ( #14281 )
...
## Summary
This adds a new diagnostic when possibly unbound symbols are imported.
The `TODO` comment had a question mark, do I'm not sure if this is
really something that we want.
This does not touch the un*declared* case, yet.
relates to: #14022
## Test Plan
Updated already existing tests with new diagnostics
2024-11-11 20:26:01 +01:00
f82ee8ea59
[flake8-markupsafe] Adds Implementation for MS001 via RUF035 ( #14224 )
...
Co-authored-by: Micha Reiser <micha@reiser.io>
2024-11-11 18:30:03 +00:00
b8a65182dd
[red-knot] Symbol API improvements, part 2 ( #14276 )
...
## Summary
Apart from one small functional change, this is mostly a refactoring of
the `Symbol` API:
- Rename `as_type` to the more explicit `ignore_possibly_unbound`, no
functional change
- Remove `unwrap_or_unknown` in favor of the more explicit
`.ignore_possibly_unbound().unwrap_or(Type::Unknown)`, no functional
change
- Consistently call it "possibly unbound" (not "may be unbound")
- Rename `replace_unbound_with` to `or_fall_back_to` and properly handle
boundness of the fall back. This is the only functional change (did not
have any impact on existing tests).
relates to: #14022
## Test Plan
New unit tests for `Symbol::or_fall_back_to`
---------
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
2024-11-11 15:24:27 +01:00
fc15d8a3bd
[red-knot] Infer `Literal` types from comparisons with `sys.version_info` ( #14244 )
2024-11-11 13:58:16 +00:00
b3b5c19105
Minor refactoring of some flake-pyi rules ( #14275 )
...
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
2024-11-11 13:10:48 +00:00
f8aae9b1d6
[`flake8-pyi`] Mark fix as unsafe when type annotation contains comments for `duplicate-literal-member` (`PYI062`) ( #14268 )
2024-11-11 12:48:14 +00:00
9180635171
[red-knot] Cleanup some `KnownClass` APIs ( #14269 )
2024-11-11 11:54:42 +00:00
3ef4b3bf32
[red-knot] Shorten the paths for some mdtest files ( #14267 )
2024-11-11 11:34:33 +00:00
5a3886c8b5
[`perflint`] implement quick-fix for `manual-list-comprehension` (`PERF401`) ( #13919 )
...
Co-authored-by: Micha Reiser <micha@reiser.io>
2024-11-11 11:17:02 +00:00
813ec23ecd
[red-knot] Improve mdtest output ( #14213 )
2024-11-11 11:03:41 +00:00
13883414af
Add "Notebook behavior" section for `F704`, `PLE1142` ( #14266 )
...
## Summary
Move the relevant contents into "Notebook behavior" section similar to
other rules.
2024-11-11 10:54:28 +00:00
84d4f114ef
Use bitshift consistently for bitflag definitions ( #14265 )
2024-11-11 10:20:17 +00:00
1c586b29e2
Update dependency mkdocs-redirects to v1.2.2 ( #14252 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 10:11:22 +00:00
d76a8518c2
Update dependency uuid to v11.0.3 ( #14254 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 10:11:12 +00:00
5f0ee2670a
Update cloudflare/wrangler-action action to v3.12.1 ( #14261 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 09:56:12 +00:00
f8ca6c3316
Update NPM Development dependencies ( #14259 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 09:55:43 +00:00
ba7b023f26
Update Rust crate tempfile to v3.14.0 ( #14260 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 09:48:51 +00:00
e947d163b2
Update Rust crate thiserror to v2 ( #14262 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micha Reiser <micha@reiser.io>
2024-11-11 09:46:09 +00:00
1cf4d2ff69
Update dependency ruff to v0.7.3 ( #14253 )
...
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://docs.astral.sh/ruff )
([source](https://redirect.github.com/astral-sh/ruff ),
[changelog](https://redirect.github.com/astral-sh/ruff/blob/main/CHANGELOG.md ))
| `==0.7.2` -> `==0.7.3` |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>astral-sh/ruff (ruff)</summary>
###
[`v0.7.3`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#073 )
[Compare
Source](https://redirect.github.com/astral-sh/ruff/compare/0.7.2...0.7.3 )
##### Preview features
- Formatter: Disallow single-line implicit concatenated strings
([#​13928](https://redirect.github.com/astral-sh/ruff/pull/13928 ))
- \[`flake8-pyi`] Include all Python file types for `PYI006` and
`PYI066`
([#​14059](https://redirect.github.com/astral-sh/ruff/pull/14059 ))
- \[`flake8-simplify`] Implement `split-of-static-string` (`SIM905`)
([#​14008](https://redirect.github.com/astral-sh/ruff/pull/14008 ))
- \[`refurb`] Implement `subclass-builtin` (`FURB189`)
([#​14105](https://redirect.github.com/astral-sh/ruff/pull/14105 ))
- \[`ruff`] Improve diagnostic messages and docs (`RUF031`, `RUF032`,
`RUF034`)
([#​14068](https://redirect.github.com/astral-sh/ruff/pull/14068 ))
##### Rule changes
- Detect items that hash to same value in duplicate sets (`B033`,
`PLC0208`)
([#​14064](https://redirect.github.com/astral-sh/ruff/pull/14064 ))
- \[`eradicate`] Better detection of IntelliJ language injection
comments (`ERA001`)
([#​14094](https://redirect.github.com/astral-sh/ruff/pull/14094 ))
- \[`flake8-pyi`] Add autofix for `docstring-in-stub` (`PYI021`)
([#​14150](https://redirect.github.com/astral-sh/ruff/pull/14150 ))
- \[`flake8-pyi`] Update `duplicate-literal-member` (`PYI062`) to alawys
provide an autofix
([#​14188](https://redirect.github.com/astral-sh/ruff/pull/14188 ))
- \[`pyflakes`] Detect items that hash to same value in duplicate
dictionaries (`F601`)
([#​14065](https://redirect.github.com/astral-sh/ruff/pull/14065 ))
- \[`ruff`] Fix false positive for decorators (`RUF028`)
([#​14061](https://redirect.github.com/astral-sh/ruff/pull/14061 ))
##### Bug fixes
- Avoid parsing joint rule codes as distinct codes in `# noqa`
([#​12809](https://redirect.github.com/astral-sh/ruff/pull/12809 ))
- \[`eradicate`] ignore `# language=` in commented-out-code rule
(ERA001)
([#​14069](https://redirect.github.com/astral-sh/ruff/pull/14069 ))
- \[`flake8-bugbear`] - do not run `mutable-argument-default` on stubs
(`B006`)
([#​14058](https://redirect.github.com/astral-sh/ruff/pull/14058 ))
- \[`flake8-builtins`] Skip lambda expressions in
`builtin-argument-shadowing (A002)`
([#​14144](https://redirect.github.com/astral-sh/ruff/pull/14144 ))
- \[`flake8-comprehension`] Also remove trailing comma while fixing
`C409` and `C419`
([#​14097](https://redirect.github.com/astral-sh/ruff/pull/14097 ))
- \[`flake8-simplify`] Allow `open` without context manager in `return`
statement (`SIM115`)
([#​14066](https://redirect.github.com/astral-sh/ruff/pull/14066 ))
- \[`pylint`] Respect hash-equivalent literals in `iteration-over-set`
(`PLC0208`)
([#​14063](https://redirect.github.com/astral-sh/ruff/pull/14063 ))
- \[`pylint`] Update known dunder methods for Python 3.13 (`PLW3201`)
([#​14146](https://redirect.github.com/astral-sh/ruff/pull/14146 ))
- \[`pyupgrade`] - ignore kwarg unpacking for `UP044`
([#​14053](https://redirect.github.com/astral-sh/ruff/pull/14053 ))
- \[`refurb`] Parse more exotic decimal strings in
`verbose-decimal-constructor` (`FURB157`)
([#​14098](https://redirect.github.com/astral-sh/ruff/pull/14098 ))
##### Documentation
- Add links to missing related options within rule documentations
([#​13971](https://redirect.github.com/astral-sh/ruff/pull/13971 ))
- Add rule short code to mkdocs tags to allow searching via rule codes
([#​14040](https://redirect.github.com/astral-sh/ruff/pull/14040 ))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ).
View the [repository job
log](https://developer.mend.io/github/astral-sh/ruff ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOS43LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImludGVybmFsIl19-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 08:17:22 +00:00
2308522f38
Update pre-commit dependencies ( #14256 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[astral-sh/ruff-pre-commit](https://redirect.github.com/astral-sh/ruff-pre-commit )
| repository | patch | `v0.7.2` -> `v0.7.3` |
| [crate-ci/typos](https://redirect.github.com/crate-ci/typos ) |
repository | patch | `v1.27.0` -> `v1.27.3` |
Note: The `pre-commit` manager in Renovate is not supported by the
`pre-commit` maintainers or community. Please do not report any problems
there, instead [create a Discussion in the Renovate
repository](https://redirect.github.com/renovatebot/renovate/discussions/new )
if you have any questions.
---
### Release Notes
<details>
<summary>astral-sh/ruff-pre-commit (astral-sh/ruff-pre-commit)</summary>
###
[`v0.7.3`](https://redirect.github.com/astral-sh/ruff-pre-commit/releases/tag/v0.7.3 )
[Compare
Source](https://redirect.github.com/astral-sh/ruff-pre-commit/compare/v0.7.2...v0.7.3 )
See: https://github.com/astral-sh/ruff/releases/tag/0.7.3
</details>
<details>
<summary>crate-ci/typos (crate-ci/typos)</summary>
###
[`v1.27.3`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.27.3 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.27.2...v1.27.3 )
#### \[1.27.3] - 2024-11-08
##### Fixes
- Don't correct `alloced`
- Don't correct `registor`, a more domain specific variant of `register`
###
[`v1.27.2`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.27.2 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.27.1...v1.27.2 )
#### \[1.27.2] - 2024-11-06
##### Fixes
- Correct `fand`
###
[`v1.27.1`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.27.1 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.27.0...v1.27.1 )
#### \[1.27.1] - 2024-11-06
##### Fixes
- Correct `alingment` as `alignment`, rather than `alinement`
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ).
View the [repository job
log](https://developer.mend.io/github/astral-sh/ruff ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOS43LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImludGVybmFsIl19-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 08:17:07 +00:00
438f3d967b
[red-knot] is_disjoint_from: tests for function/module literals ( #14264 )
...
## Summary
Add unit tests for `is_disjoint_from` for function and module literals
as a follow-up to #14210 .
Ref: https://github.com/astral-sh/ruff/pull/14210/files#r1835069885
2024-11-11 09:14:26 +01:00
5bf4759cff
Detect permutations in redundant open modes ( #14255 )
...
## Summary
Closes https://github.com/astral-sh/ruff/issues/14235 .
2024-11-10 22:48:30 -05:00
2e9e96338e
Update Rust crate url to v2.5.3 ( #14251 )
2024-11-10 19:47:14 -05:00
5fa7ace1f5
Update Rust crate matchit to v0.8.5 ( #14250 )
2024-11-10 19:47:09 -05:00
704868ca83
Update Rust crate libc to v0.2.162 ( #14249 )
2024-11-10 19:47:02 -05:00
dc71c8a484
Update Rust crate hashbrown to v0.15.1 ( #14247 )
2024-11-10 19:46:55 -05:00
2499297392
Update Rust crate is-macro to v0.3.7 ( #14248 )
2024-11-10 19:46:48 -05:00
7b9189bb2c
Update Rust crate anyhow to v1.0.93 ( #14246 )
2024-11-10 19:46:40 -05:00
d4cf61d98b
Implement `shallow-copy-environ / W1507` ( #14241 )
...
<!--
Thank you for contributing to Ruff! To help us out with reviewing,
please consider the following:
- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->
## Summary
<!-- What's the purpose of the change? What does it do, and why? -->
Related to #970 . Implement [`shallow-copy-environ /
W1507`](https://pylint.readthedocs.io/en/stable/user_guide/messages/warning/shallow-copy-environ.html ).
## Test Plan
<!-- How was it tested? -->
Unit test
---------
Co-authored-by: Simon Brugman <sbrugman@users.noreply.github.com>
Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
2024-11-10 22:58:02 +00:00
5d91ba0b10
FBT001: exclude boolean operators ( #14203 )
...
Fixes #14202
## Summary
Exclude rule FBT001 for boolean operators.
## Test Plan
Updated existing `FBT.py` test.
2024-11-10 22:40:37 +00:00
a7e9f0c4b9
[red-knot] follow-ups to typevar types ( #14232 )
2024-11-09 20:18:32 -08:00
c7d48e10e6
Detect empty implicit namespace packages ( #14236 )
...
## Summary
The implicit namespace package rule currently fails to detect cases like
the following:
```text
foo/
├── __init__.py
└── bar/
└── baz/
└── __init__.py
```
The problem is that we detect a root at `foo`, and then an independent
root at `baz`. We _would_ detect that `bar` is an implicit namespace
package, but it doesn't contain any files! So we never check it, and
have no place to raise the diagnostic.
This PR adds detection for these kinds of nested packages, and augments
the `INP` rule to flag the `__init__.py` file above with a specialized
message. As a side effect, I've introduced a dedicated `PackageRoot`
struct which we can pass around in lieu of Yet Another `Path`.
For now, I'm only enabling this in preview (and the approach doesn't
affect any other rules). It's a bug fix, but it may end up expanding the
rule.
Closes https://github.com/astral-sh/ruff/issues/13519 .
2024-11-09 22:03:34 -05:00
94dee2a36d
Avoid applying PEP 646 rewrites in invalid contexts ( #14234 )
...
## Summary
Closes https://github.com/astral-sh/ruff/issues/14231 .
2024-11-09 15:47:28 -05:00
555a5c9319
[`refurb`] Avoid triggering `hardcoded-string-charset` for reordered sets ( #14233 )
...
## Summary
It's only safe to enforce the `x in "1234567890"` case if `x` is exactly
one character, since the set on the right has been reordered as compared
to `string.digits`. We can't know if `x` is exactly one character unless
it's a literal. And if it's a literal, well, it's kind of silly code in
the first place?
Closes https://github.com/astral-sh/ruff/issues/13802 .
2024-11-09 15:31:26 -05:00
1279c20ee1
Avoid using `typing.Self` in stub files pre-Python 3.11 ( #14230 )
...
## Summary
See:
https://github.com/astral-sh/ruff/pull/14217#discussion_r1835340869 .
This means we're recommending `typing_extensions` in non-stubs pre-3.11,
which may not be a valid project dependency, but that's a separate issue
(https://github.com/astral-sh/ruff/issues/9761 ).
2024-11-09 13:17:36 -05:00
ce3af27f59
Avoid treating lowercase letters as `# noqa` codes ( #14229 )
...
## Summary
An oversight from the original implementation.
Closes https://github.com/astral-sh/ruff/issues/14228 .
2024-11-09 12:49:35 -05:00
71da1d6df5
Fix `await-outside-async` to allow `await` at the top-level scope of a notebook ( #14225 )
...
## Summary
<!-- What's the purpose of the change? What does it do, and why? -->
Fix `await-outside-async` to allow `await` at the top-level scope of a
notebook.
```python
# foo.ipynb
await asyncio.sleep(1) # should be allowed
```
## Test Plan
<!-- How was it tested? -->
A unit test
2024-11-09 12:44:48 -05:00
e598240f04
[red-knot] More `Type` constructors ( #14227 )
2024-11-09 16:57:11 +00:00
c9b84e2a85
[`ruff`] Do not report when `Optional` has no type arguments (`RUF013`) ( #14181 )
...
## Summary
Resolves #13833 .
## Test Plan
`cargo nextest run` and `cargo insta test`.
---------
Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
2024-11-09 08:48:56 -05:00
d3f1c8e536
[red-knot] Add `Type` constructors for `Instance`, `ClassLiteral` and `SubclassOf` variants ( #14215 )
...
## Summary
Reduces some repetetiveness and verbosity at callsites. Addresses
@carljm's review comments at
https://github.com/astral-sh/ruff/pull/14155/files#r1833252458
## Test Plan
`cargo test -p red_knot_python_semantic`
2024-11-09 09:10:00 +00:00
eea6b31980
[`flake8-pyi`] Add "replace with `Self`" fix (`PYI034`) ( #14217 )
...
## Summary
Resolves #14184 .
## Test Plan
`cargo nextest run` and `cargo insta test`.
2024-11-09 02:11:38 +00:00
b8dc780bdc
[`refurb`] Further special cases added to `verbose-decimal-constructor (FURB157)` ( #14216 )
...
This PR accounts for further subtleties in `Decimal` parsing:
- Strings which are empty modulo underscores and surrounding whitespace
are skipped
- `Decimal("-0")` is skipped
- `Decimal("{integer literal that is longer than 640 digits}")` are
skipped (see linked issue for explanation)
NB: The snapshot did not need to be updated since the new test cases are
"Ok" instances and added below the diff.
Closes #14204
2024-11-08 21:08:22 -05:00
93fdf7ed36
Fix miscellaneous issues in `await-outside-async detection` ( #14218 )
...
## Summary
Closes https://github.com/astral-sh/ruff/issues/14167 .
2024-11-08 21:07:13 -05:00
b19f388249
[`refurb`] Use `UserString` instead of non-existent `UserStr` ( #14209 )
...
## Summary
The class name is UserString, not a UserStr, see
https://docs.python.org/3.9/library/collections.html#collections.UserString
2024-11-08 20:54:18 -05:00
de947deee7
[red-knot] Consolidate detection of cyclically defined classes ( #14207 )
2024-11-08 22:17:56 +00:00
c0c4ae14ac
[red-knot] make KnownClass::is_singleton a const fn ( #14211 )
...
Follow-up from missed review comment on
https://github.com/astral-sh/ruff/pull/14182
2024-11-08 13:37:25 -08:00
David Peter
InSync
David Salvisberg
Alex Waygood
Simon Brugman
w0nder1ng
Dhruv Manilawala
renovate[bot]
Charlie Marsh
Harutaka Kawamura
Randolf Scholz
Carl Meyer
Dylan
Michal Čihař