Micha Reiser
12177a42e3
Set durabilities for low-durability fields on high-durability inputs ( #12627 )
2024-08-02 19:42:34 +02:00
Micha Reiser
dfb08856eb
Fix file watcher stop data race ( #12626 )
2024-08-02 19:02:49 +02:00
Auguste Lalande
94d817e1a5
[`pydoclint`] Add `docstring-missing-yields` amd `docstring-extraneous-yields` (`DOC402`, `DOC403`) ( #12538 )
2024-08-02 17:55:42 +01:00
ember91
9296bd4e3f
Fix a typo ( #12633 )
...
Co-authored-by: Emil Berg <emil.berg@ericsson.com>
2024-08-02 16:39:27 +01:00
Micha Reiser
da824ba316
Release Ruff 0.5.6 ( #12629 )
...
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
2024-08-02 17:35:14 +02:00
Micha Reiser
012198a1b0
Enable notebooks by default in preview mode ( #12621 )
2024-08-02 13:36:53 +00:00
Alex Waygood
fbab04fbe1
[red-knot] Allow multiple `site-packages` search paths ( #12609 )
2024-08-02 13:33:19 +00:00
Dhruv Manilawala
9aa43d5f91
Separate `red_knot` into CLI and `red_knot_workspace` crates ( #12623 )
...
## Summary
This PR separates the current `red_knot` crate into two crates:
1. `red_knot` - This will be similar to the `ruff` crate, it'll act as
the CLI crate
2. `red_knot_workspace` - This includes everything except for the CLI
functionality from the existing `red_knot` crate
Note that the code related to the file watcher is in
`red_knot_workspace` for now but might be required to extract it out in
the future.
The main motivation for this change is so that we can have a `red_knot
server` command. This makes it easier to test the server out without
making any changes in the VS Code extension. All we need is to specify
the `red_knot` executable path in `ruff.path` extension setting.
## Test Plan
- `cargo build`
- `cargo clippy --workspace --all-targets --all-features`
- `cargo shear --fix`
2024-08-02 11:24:36 +00:00
Micha Reiser
966563c79b
Add tests for hard and soft links ( #12590 )
2024-08-02 10:14:28 +00:00
Micha Reiser
27edadec29
Make server panic hook more error resilient ( #12610 )
2024-08-02 12:10:06 +02:00
InSync
2e2b1b460f
Fix a typo in `docs/editors/settings.md` ( #12614 )
...
Diff:
```diff
-- `false: Same as`off\`
+- `false`: Same as `off`
```
2024-08-01 11:23:55 -05:00
Charlie Marsh
a3e67abf4c
Add newlines before comments in E305 ( #12606 )
...
## Summary
There's still a problem here. Given:
```python
class Class():
pass
# comment
# another comment
a = 1
```
We only add one newline before `a = 1` on the first pass, because
`max_precedling_blank_lines` is 1... We then add the second newline on
the second pass, so it ends up in the right state, but the logic is
clearly wonky.
Closes https://github.com/astral-sh/ruff/issues/11508 .
2024-07-31 23:11:00 -04:00
Carl Meyer
ee0518e8f7
[red-knot] implement attribute of union ( #12601 )
...
I hit this `todo!` trying to run type inference over some real modules.
Since it's a one-liner to implement it, I just did that rather than
changing to `Type::Unknown`.
2024-07-31 19:45:24 -07:00
Charlie Marsh
d774a3bd48
Avoid unused async when context manager includes `TaskGroup` ( #12605 )
...
## Summary
Closes https://github.com/astral-sh/ruff/issues/12354 .
2024-08-01 02:12:43 +00:00
Charlie Marsh
7e6b19048e
Don't attach comments with mismatched indents ( #12604 )
...
## Summary
Given:
```python
def test_update():
pass
# comment
def test_clientmodel():
pass
```
We don't want `# comment` to be attached to `def test_clientmodel()`.
Closes https://github.com/astral-sh/ruff/issues/12589 .
2024-07-31 22:09:05 -04:00
Charlie Marsh
8e383b9587
Respect start index in `unnecessary-list-index-lookup` ( #12603 )
...
## Summary
Closes https://github.com/astral-sh/ruff/issues/12594 .
2024-08-01 01:21:15 +00:00
github-actions[bot]
3f49ab126f
Sync vendored typeshed stubs ( #12602 )
2024-08-01 01:44:56 +01:00
Chris Krycho
c1bc7f4dee
Remove `ecosystem_ci` flag from Ruff CLI ( #12596 )
...
## Summary
@zanieb noticed while we were discussing #12595 that this flag is now
unnecessary, so remove it and the flags which reference it.
## Test Plan
Question for maintainers: is there a test to add *or* remove here? (I’ve
opened this as a draft PR with that in view!)
2024-07-31 11:40:03 -05:00
Bowen Liang
a44d579f21
Add Dify to Ruff users ( #12593 )
...
## Summary
<!-- What's the purpose of the change? What does it do, and why? -->
- Add the popular LLM Ops project Dify to the user list in Readme, as
Dify introduced Ruff for lining since Feb 2024 in
https://github.com/langgenius/dify/pull/2366
2024-07-31 08:56:52 -04:00
Alex Waygood
a3900d2b0b
[`pyflakes`] Fix preview-mode bugs in `F401` when attempting to autofix unused first-party submodule imports in an `__init__.py` file ( #12569 )
2024-07-31 13:34:30 +01:00
Alex Waygood
83b1c48a93
Make setting and retrieving pydocstyle settings less tedious ( #12582 )
2024-07-31 10:39:33 +01:00
Micha Reiser
138e70bd5c
Upgrade to Rust 1.80 ( #12586 )
2024-07-30 19:18:08 +00:00
Eero Vaher
ee103ffb25
Fix an argument name in B905 description ( #12588 )
...
The description of `zip-without-explicit-strict` erroneously mentions a
non-existing `check` argument for `zip()`.
2024-07-30 14:40:56 -04:00
Micha Reiser
18f87b9497
Flaky file watching tests, add debug assertions ( #12587 )
2024-07-30 18:09:55 +00:00
Micha Reiser
adc8d4e1e7
File watch events: Add dynamic wait period before writing new changes ( #12585 )
2024-07-30 19:18:43 +02:00
Alex Waygood
90db361199
Consider more stdlib decorators to be property-like ( #12583 )
2024-07-30 17:18:23 +00:00
Alex Waygood
4738135801
Improve consistency between linter rules in determining whether a function is property ( #12581 )
2024-07-30 17:42:04 +01:00
Micha Reiser
264cd750e9
Add delay between updating a file ( #12576 )
2024-07-30 18:31:29 +02:00
Alex Waygood
7a4419a2a5
Improve handling of metaclasses in various linter rules ( #12579 )
2024-07-30 14:48:36 +01:00
Alex Waygood
ac1666d6e2
Remove several incorrect uses of `map_callable()` ( #12580 )
2024-07-30 14:30:25 +01:00
epenet
459c85ba27
[`flake8-return`] Exempt cached properties and other property-like decorators from explicit return rule (`RET501`) ( #12563 )
...
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
2024-07-30 11:06:28 +00:00
Alex Waygood
aaa56eb0bd
Fix NFKC normalization bug when removing unused imports ( #12571 )
2024-07-30 09:54:35 +00:00
Dhruv Manilawala
f3c14a4276
Keep track of deleted cell for reorder change request ( #12575 )
...
## Summary
This PR fixes a bug where the server wouldn't retain the cell content in
case of a reorder change request.
As mentioned in
https://github.com/astral-sh/ruff/issues/12573#issuecomment-2257819298 ,
this change request is modeled as (a) remove these cell URIs and (b) add
these cell URIs. The cell content isn't provided. But, the way we've
modeled the `NotebookCell` (it contains the underlying `TextDocument`),
we need to keep track of the deleted cells to get the content.
This is not an ideal solution and a better long term solution would be
to model it as per the spec but that is a big structural change and will
affect multiple parts of the server. Modeling as per the spec would also
avoid bugs like https://github.com/astral-sh/ruff/pull/11864 . For
context, that model would add complexity per
https://github.com/astral-sh/ruff/pull/11206#discussion_r1600165481 .
fixes : #12573
## Test Plan
This video shows the before and after the bug is fixed:
https://github.com/user-attachments/assets/2fcad4b5-f9af-4776-8640-4cd1fa16e325
2024-07-30 09:51:26 +00:00
Alex Waygood
3169d408fa
[red-knot] Fix typos in the module resolver ( #12574 )
2024-07-30 09:38:38 +00:00
Micha Reiser
a2286c8e47
Set Durability to 'HIGH' for most inputs and third-party libraries ( #12566 )
2024-07-30 09:03:59 +00:00
Piotr Osiewicz
fb9f566f56
Use `$/logTrace` for server trace logs in Zed and VS Code ( #12564 )
...
## Summary
This pull request adds support for logging via `$/logTrace` RPC
messages. It also enables that code path for when a client is Zed editor
or VS Code (as there's no way for us to generically tell whether a client prefers
`$/logTrace` over stderr.
Related to: #12523
## Test Plan
I've built Ruff from this branch and tested it manually with Zed.
---------
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
2024-07-30 08:32:20 +05:30
Micha Reiser
381bd1ff4a
Delete left over debug statement ( #12567 )
2024-07-29 16:16:12 +02:00
Micha Reiser
2f54d05d97
Remove `salsa::report_untracked_read` when finding the dynamic module resolution paths ( #12509 )
2024-07-29 09:31:29 +00:00
Micha Reiser
e18b4e42d3
[red-knot] Upgrade to the *new* *new* salsa ( #12406 )
2024-07-29 07:21:24 +00:00
Dhruv Manilawala
9495331a5f
Recommend client config for `trace` setting in Neovim ( #12562 )
2024-07-29 06:14:34 +00:00
renovate[bot]
e1076db7d0
Update CodSpeedHQ/action action to v3 ( #12559 )
2024-07-29 07:37:02 +02:00
renovate[bot]
1986c9e8e2
Update NPM Development dependencies ( #12556 )
2024-07-28 22:17:44 -04:00
renovate[bot]
d7e80dc955
Update pre-commit dependencies ( #12555 )
2024-07-28 22:17:34 -04:00
renovate[bot]
87d09f77cd
Update Rust crate imperative to v1.0.6 ( #12552 )
2024-07-28 22:17:28 -04:00
renovate[bot]
bd37ef13b8
Update Rust crate bstr to v1.10.0 ( #12557 )
2024-07-28 22:17:11 -04:00
renovate[bot]
ec23c974db
Update Rust crate toml to v0.8.16 ( #12554 )
2024-07-28 22:17:01 -04:00
renovate[bot]
122e5ab428
Update Rust crate serde_json to v1.0.121 ( #12553 )
2024-07-28 22:16:55 -04:00
renovate[bot]
2f2149aca8
Update Rust crate env_logger to v0.11.5 ( #12550 )
2024-07-28 22:16:49 -04:00
renovate[bot]
9d5c31e7da
Update Rust crate imara-diff to v0.1.7 ( #12551 )
2024-07-28 22:16:42 -04:00
renovate[bot]
25f3ad6238
Update Rust crate clap to v4.5.11 ( #12549 )
2024-07-28 22:16:36 -04:00