7440e54ec6
Avoid allocating in lex_decimal ( #7252 )
2023-09-11 06:37:25 +00:00
0357e801ed
Avoid F401 panic with noqa import name ( #7260 )
...
Closes https://github.com/astral-sh/ruff/issues/7244 .
2023-09-10 16:31:25 +00:00
69d0caabe7
fix D417 error with function docstrings with dashed lines ( #7251 )
...
## Summary
Fix https://github.com/astral-sh/ruff/issues/7250 , False positive D417
for docstrings with dashed lines.
## Test Plan
Tested on the example in https://github.com/astral-sh/ruff/issues/7250
2023-09-10 17:28:44 +01:00
9cb5ce750e
Remove IO based lints from linter benchmark ( #7240 )
2023-09-08 13:39:50 +02:00
0a07a2ca62
Extract string part and normalized string ( #7219 )
2023-09-08 12:56:55 +02:00
47a253fb62
Add PreviewMode option to formatter
...
## Summary
This PR adds the `--preview` and `--no-preview` options to the `format` command (hidden) and passes it through to the formatte.
## Test Plan
I added the `dbg(f.options().preview())` statement in `FormatNodeRule::fmt` and verified that the option gets correctly passed to the formatter.
2023-09-08 12:04:28 +02:00
d9544a2d37
Disable default criterion features ( #7241 )
2023-09-08 10:03:14 +00:00
41f0aad7b3
Add FString support to binary like formatting
...
## Summary
This is the last part of the string - binary like formatting. It adds support for handling fstrings the same as "regular" strings.
## Test Plan
I added a test for both binary and comparison.
Small improvements across several projects
**This PR**
| project | similarity index | total files | changed files |
|--------------|------------------:|------------------:|------------------:|
| cpython | 0.76083 | 1789 | 1632 |
| django | 0.99966 | 2760 | 58 |
| **transformers** | 0.99929 | 2587 | 454 |
| twine | 1.00000 | 33 | 0 |
| typeshed | 0.99978 | 3496 | 2173 |
| **warehouse** | 0.99825 | 648 | 22 |
| **zulip** | 0.99950 | 1437 | 27 |
**Base**
| project | similarity index | total files | changed files |
|--------------|------------------:|------------------:|------------------:|
| cpython | 0.76083 | 1789 | 1632 |
| django | 0.99966 | 2760 | 58 |
| transformers | 0.99928 | 2587 | 454 |
| twine | 1.00000 | 33 | 0 |
| typeshed | 0.99978 | 3496 | 2173 |
| warehouse | 0.99824 | 648 | 22 |
| zulip | 0.99948 | 1437 | 28 |
<!-- How was it tested? -->
2023-09-08 11:48:57 +02:00
05951dd338
Fix inconsistent `expr_lambda` formatting ( #6318 )
2023-09-08 09:40:58 +00:00
c260762900
Formatter: Implicit concatenation in compare expressions
...
## Summary
This PR implements the logic for breaking implicit concatenated strings before compare expressions by building on top of #7145
The main change is a new `BinaryLike` enum that has the `BinaryExpression` and `CompareExpression` variants. Supporting both variants requires some downstream changes but doesn't introduce any new concepts.
## Test Plan
I added a few more tests. The compatibility improvements are minor but we now perfectly match black on twine 🥳
**PR**
| project | similarity index | total files | changed files |
|--------------|------------------:|------------------:|------------------:|
| cpython | 0.76083 | 1789 | 1632 |
| django | 0.99966 | 2760 | 58 |
| transformers | 0.99928 | 2587 | 454 |
| **twine** | 1.00000 | 33 | 0 | <-- improved
| typeshed | 0.99978 | 3496 | 2173 |
| **warehouse** | 0.99824 | 648 | 22 | <-- improved
| zulip | 0.99948 | 1437 | 28 |
**Base**
| project | similarity index | total files | changed files |
|--------------|------------------:|------------------:|------------------:|
| cpython | 0.76083 | 1789 | 1633 |
| django | 0.99966 | 2760 | 58 |
| transformers | 0.99928 | 2587 | 454 |
| twine | 0.99982 | 33 | 1 |
| typeshed | 0.99978 | 3496 | 2173 |
| warehouse | 0.99823 | 648 | 23 |
| zulip | 0.99948 | 1437 | 28 |
2023-09-08 11:32:20 +02:00
1d5c4b0a14
Show header for formatter comment decoration info ( #7228 )
...
Show header for formatter comment decoration info
**Summary** Show a header in the formatter comment decoration debug
output that shows which node is preceding/following/enclosing
(https://github.com/astral-sh/ruff/pull/6813#issuecomment-1708119550 ). I
kept this intentionally condensed to make it easy to use this is a small
sidebar without vertical scrolling.
```console
$ cargo run --bin ruff_python_formatter -- --emit stdout --print-comments scratch.py
# Comment decoration: Range, Preceding, Following, Enclosing, Comment
17..20, Some((ParameterWithDefault, 6..10)), None, (Parameters, 5..22), "# a"
44..47, Some((StmtExpr, 28..39)), Some((StmtExpr, 52..60)), (StmtFunctionDef, 0..60), "# b"
77..80, None, None, (ExprList, 71..82), "# c"
{
Node {
kind: ParameterWithDefault,
range: 6..10,
source: `x=[]`,
}: {
...
```
**Test Plan** It's debug output.
2023-09-08 09:25:06 +00:00
a352f2f092
Preserve generator parentheses in single argument call expressions ( #7226 )
2023-09-08 10:53:34 +02:00
e376c3ff7e
Split implicit concatenated strings before binary expressions ( #7145 )
2023-09-08 06:51:26 +00:00
9671922e40
Do not use code location for Gitlab fingerprints. ( #7203 )
2023-09-08 08:25:26 +02:00
45f9fca228
Reuse locator in formatter comments ( #7227 )
...
**Summary** The comment visitor used to rebuild the locator for every
comment. Instead, we now keep the locator on the builder. Follow-up to
#6813 .
**Test Plan** No formatting changes.
2023-09-07 20:08:28 +02:00
6661be2c30
Use full range for SIM105 fixes ( #7221 )
...
Avoids inserting an accidental extra newline after the fix _and_
addresses the case of a trailing semicolon.
2023-09-07 16:16:43 +01:00
97f945651d
Change SIM118 to delete `.keys()` rather than replace expression ( #7223 )
...
Also improves the suggestion text. Closes
https://github.com/astral-sh/ruff/issues/7200 .
2023-09-07 16:16:24 +01:00
5cea43731e
Add required space for FLY002 fixes ( #7222 )
...
Closes https://github.com/astral-sh/ruff/issues/7197 .
2023-09-07 14:32:43 +00:00
7971e0b0ee
Add `extend-ignore-names` for `flake8-self` ( #7194 )
...
## Summary
Add a configuration option to extend the list of names that can be
accessed without triggering SLF001.
Fixes issue #7018
## Test Plan
Manually tested by creating a python file (`test.py`):
```python
def foo(obj):
obj._meta
```
and a `ruff.toml` file:
```toml
select = ["SLF"]
[flake8-self]
extend-ignore-names = ["_meta"]
```
Then running `cargo run -p ruff_cli -- check test.py --no-cache` (once
with the `extend-ignore-names` line comment out) to see if the
configuration option works.
---------
Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
2023-09-07 13:41:22 +00:00
842ff0212e
Add Lexer emoji test case ( #7213 )
2023-09-07 10:02:50 +00:00
f1a4eb9c28
Use the unicode-ident crate ( #7212 )
2023-09-07 08:19:25 +00:00
041cdb95e0
Update identifier Unicode character validation to match Python spec ( #7209 )
...
Co-authored-by: Micha Reiser <micha@reiser.io>
2023-09-07 07:08:42 +00:00
fda48afc23
Add required space to C416 fix ( #7204 )
...
Closes https://github.com/astral-sh/ruff/issues/7196 .
2023-09-06 16:25:02 +00:00
c1af1c291d
Add required space to UP006 and UP007 fixes ( #7202 )
...
We're removing a set of brackets here so we need to pad the fix.
Closes https://github.com/astral-sh/ruff/issues/7201 .
2023-09-06 16:06:02 +00:00
171b66cb43
Lexer: Add skip whitespace fastpath ( #7184 )
2023-09-06 16:14:01 +02:00
fa0b6f4813
Avoid attempting to fix SIM105 violations with multi-statement lines ( #7191 )
...
I may revisit this and fix it "properly", but so rare that it's worth
disabling for now: https://github.com/astral-sh/ruff/issues/7123 .
2023-09-06 13:35:46 +00:00
eab85aea1a
Use structured types for C417 comprehension target ( #7190 )
...
Rather than manually joining the arguments as a comma-separated string,
and treating that comma-separated string as a name.
2023-09-06 13:20:04 +00:00
5b31524920
Parenthesize C417 targets if necessary ( #7189 )
...
Closes https://github.com/astral-sh/ruff/issues/7121 .
2023-09-06 12:56:47 +00:00
6d0469638c
Avoid attempting to fix NPY001 with overridden builtins ( #7187 )
2023-09-06 12:24:37 +00:00
29ba2bb943
Add required space when fixing C404 ( #7185 )
2023-09-06 13:05:39 +01:00
f0ea40a68d
Restructure signatures of `flake8_comprehensions` fixers ( #7186 )
2023-09-06 12:04:50 +00:00
a3a531e0d4
Add alpha instructions to the `ruff_python_formatter` README ( #7064 )
2023-09-06 11:55:16 +00:00
b3e8eca871
Rename `PLR1714` to `repeated-equality-comparison` ( #7182 )
2023-09-06 12:46:48 +01:00
447b7cb0e2
Formatter: Show preceding, following and enclosing nodes of comments, Attempt 2 ( #6813 )
2023-09-06 12:26:13 +02:00
e3114a144c
Ignore single quote docstrings with newline escape ( #7173 )
2023-09-06 10:51:50 +02:00
2e58ad437e
build: add libcst from crates ( #7179 )
...
Co-authored-by: Micha Reiser <micha@reiser.io>
2023-09-06 08:24:28 +00:00
04f2842e4f
Move `ExprConstant::kind` to `StringConstant::unicode` ( #7180 )
2023-09-06 07:39:25 +00:00
31990b8d3f
Checker: Remove unnecessary unreachable ( #7181 )
2023-09-06 07:21:03 +00:00
5f59101811
Memoize text width ( #6552 )
2023-09-06 07:10:13 +00:00
fa6bff0078
Add inline documentation for `Ipy*` AST nodes ( #7178 )
2023-09-06 12:07:34 +05:30
ea7c394817
Copy the starred argument as is for `PLW3301` autofix ( #7177 )
2023-09-06 08:57:05 +05:30
264d9159f8
Add required space when fixing UP024 ( #7171 )
2023-09-05 17:37:09 +00:00
37dfb205b1
Remove autofix for ambiguous unicode rules ( #7168 )
2023-09-05 17:22:18 +00:00
f8e4e1d562
Fix named expression precedence in generator ( #7170 )
2023-09-05 17:06:57 +00:00
89be850b73
Add required space when fixing SIM300 ( #7167 )
2023-09-05 17:00:07 +00:00
d68041ba24
Fix B006 when function docstring is followed by whitespace but no newline ( #7160 )
2023-09-05 11:10:57 -05:00
b60b37e866
Split within `not`, rather than outside of `not`, for PT018 ( #7151 )
2023-09-05 14:50:16 +00:00
5a95edab45
Use ruff line-length in format_dev ( #6870 )
2023-09-05 16:19:17 +02:00
1adde24133
Rename parser mode from `Jupyter` to `Ipython` ( #7153 )
2023-09-05 14:12:26 +00:00
e02d76f070
Use insta_cmd ( #6737 )
2023-09-05 12:21:27 +00:00
Micha Reiser
Charlie Marsh
Ely Ronnen
qdegraaf
konsti
Greger
Jaap Roes
Victor Hugo Gomes
Tom Kuson
Manuel Martinez
Dhruv Manilawala
Zanie Blue