Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,810 Commits 522 Branches 394 Tags 312 MiB
Commit Graph

7810 Commits

Author SHA1 Message Date
Charlie Marsh f1a5e53f06
Enable isort-style `required-imports` enforcement (#1762) 
In isort, this is called `add-imports`, but I prefer the declarative
name.

The idea is that by adding the following to your `pyproject.toml`, you
can ensure that the import is included in all files:

```toml
[tool.ruff.isort]
required-imports = ["from __future__ import annotations"]
```

I mostly reverse-engineered isort's logic for making decisions, though I
made some slight tweaks that I think are preferable. A few comments:

- Like isort, we don't enforce this on empty files (like empty
`__init__.py`).
- Like isort, we require that the import is at the top-level.
- isort will skip any docstrings, and any comments on the first three
lines (I think, based on testing). Ruff places the import after the last
docstring or comment in the file preamble (that is: after the last
docstring or comment that comes before the _first_ non-docstring and
non-comment).

Resolves #1700.
 2023-01-10 18:12:57 -05:00
Charlie Marsh 1e94e0221f
Disable doctests (#1772) 
We don't have any doctests, but `cargo test --all` spends more than half
the time on doctests? A little confusing, but this brings the test time
from > 4s to < 2s on my machine.
 2023-01-10 15:10:16 -05:00
Martin Fischer 543865c96b
Generate RuleCode::origin() via macro (#1770) 2023-01-10 13:20:43 -05:00
Maksudul Haque b8e3f0bc13
[`flake8-bandit`] Add Rule for `S508` (snmp insecure version) & `S509` (snmp weak cryptography) (#1771) 
ref: https://github.com/charliermarsh/ruff/issues/1646

Co-authored-by: messense <messense@icloud.com>
Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
 2023-01-10 13:13:54 -05:00
Charlie Marsh 643cedb200
Move CONTRIBUTING.md to top-level (#1768) 2023-01-10 07:38:12 -05:00
Charlie Marsh 91620c378a
Disable release builds on CI (#1761) 2023-01-10 07:33:03 -05:00
Harutaka Kawamura b732135795
Do not autofix PT004 and PT005 (#1763) 
As @edgarrmondragon commented in
https://github.com/charliermarsh/ruff/pull/1740#issuecomment-1376230550,
just renaming fixture doesn't work.
 2023-01-10 07:24:16 -05:00
messense 9384a081f9
Implement flake8-simplify SIM112 (#1764) 
Ref #998
 2023-01-10 07:24:01 -05:00
Charlie Marsh edab268d50 Bump version to 0.0.217 2023-01-09 23:26:22 -05:00
Charlie Marsh e4fad70a57
Update documentation to match latest terminology (#1760) 
Closes #1759.
 2023-01-09 21:10:47 -05:00
Charlie Marsh 1a09fff991
Update rule-generation `scripts` to match latest conventions (#1758) 
Resolves #1755.
 2023-01-09 19:55:46 -05:00
Charlie Marsh b85105d2ec
Add a helper for any-like operations (#1757) 2023-01-09 19:34:33 -05:00
Charlie Marsh f7ac28a935
Omit `sys.version_info` and `sys.platform` checks from ternary rule (#1756) 
Resolves #1753.
 2023-01-09 19:22:34 -05:00
Charlie Marsh 9532f342a6
Enable project-specific typing module re-exports (#1754) 
Resolves #1744.
 2023-01-09 18:17:50 -05:00
Mohamed Daahir 0ee37aa0aa
Cache build artifacts using Swatinem/rust-cache@v1 (#1750) 
This GitHub Action caches build artifacts in addition to dependencies
which halves the CI duration time.

Resolves #1752.
 2023-01-09 15:35:32 -05:00
Charlie Marsh 8a26c8b4e0 Fix wasm builds 2023-01-09 12:58:07 -05:00
Charlie Marsh 2cb59b0f45
Use dedicated warnings for flake8-to-ruff (#1748) 2023-01-09 12:48:06 -05:00
Charlie Marsh 2729f3d207
Add support for defining extra builtins (#1747) 
Resolves #1745.
 2023-01-09 12:24:28 -05:00
Charlie Marsh 59155ce9f6
Rename `checks` and `plugins` to `rules` (#1739) 2023-01-09 01:39:51 -05:00
Charlie Marsh caf6c65de7 Bump version to 0.0.216 2023-01-09 01:14:28 -05:00
Matt Oberle 147d594b38
Add isort.force-sort-within-sections setting (#1635) 
This commit is a first attempt at addressing issue #1003.

The default `isort` behavior is `force-sort-within-sections = false`,
which places `from X import Y` statements after `import X` statements.

When `force-sort-within-sections = true` all imports are sorted by
module name.

When module names are equivalent, the `import` statement comes before
the `from` statement.
 2023-01-09 01:06:48 -05:00
Charlie Marsh f18078a1eb
Allow unused arguments for empty methods with docstrings (#1742) 
Resolves #1741.
 2023-01-09 00:34:07 -05:00
Harutaka Kawamura fe4eb13601
Autofix PT004, PT005, PT024, and PT025 (#1740) 2023-01-08 22:41:00 -05:00
Charlie Marsh 161ab05533
Rename more local usages of `check` to `diagnostic` (#1738) 2023-01-08 18:10:08 -05:00
Charlie Marsh 2c537e24cc
Move violation structs out of `registry.rs` (#1728) 2023-01-08 17:54:20 -05:00
Charlie Marsh 0fe349b5f8
Rename `CheckCategory` to `RuleOrigin` (#1726) 2023-01-08 17:50:18 -05:00
Charlie Marsh 09dc3c7225
Rename `Check` to `Diagnostic` (#1725) 
Along with:

- `CheckKind` -> `DiagnosticKind`
- `CheckCode` -> `RuleCode`
- `CheckCodePrefix` -> `RuleCodePrefix`
 2023-01-08 17:46:20 -05:00
Harutaka Kawamura 498134b7ee
Audit unittest assert methods (#1736) 
I ran the following code in Python 3.10 to automatically generate a list
of enums.

```python
import unittest

print(
    ",\n".join(
        sorted(
            m.removeprefix("assert") if m != "assert_" else "Underscore"
            for m in dir(unittest.TestCase)
            if m.startswith("assert")
        )
    )
)
```
 2023-01-08 16:21:34 -05:00
Charlie Marsh 0152814a00 Bump version to 0.0.215 2023-01-07 22:17:29 -05:00
Harutaka Kawamura 0b3fab256b
Remove `assertNotContains` (#1729) 
`unittest.TestCase` doens't have a method named `assertNotContains`.
 2023-01-07 22:15:48 -05:00
Chammika Mannakkara 212ce4d331
buf-fix: flake8_simplify SIM212 (#1732) 
bug-fix in #1717

Use the correct `IfExprWithTwistedArms` struct.
 2023-01-07 22:03:48 -05:00
Charlie Marsh 491b1e4968
Move RUFF_CACHE_DIR to Clap's env support (#1733) 2023-01-07 22:01:27 -05:00
Charlie Marsh 8b01b53d89
Move RUFF_CACHE_DIR to Clap's env support (#1733) 2023-01-07 22:01:20 -05:00
messense f9a5867d3e
Add `RUFF_FORMAT` environment variable support (#1731) 
Resolves #1716
 2023-01-07 21:54:19 -05:00
Harutaka Kawamura 4149627f19
Add more unittest assert methods to PT009 (#1730) 2023-01-07 21:52:48 -05:00
Charlie Marsh 7d24146df7
Implement `--isolated` CLI flag (#1727) 
Closes #1724.
 2023-01-07 18:43:58 -05:00
Charlie Marsh 1c6ef3666c
Treat failures to fix TypedDict conversions as debug logs (#1723) 
This also allows us to flag the error, even if we can't fix it.

Closes #1212.
 2023-01-07 17:51:45 -05:00
Charlie Marsh 16d933fcf5
Respect isort:skip action comment (#1722) 
Resolves: #1718.
 2023-01-07 17:30:18 -05:00
Charlie Marsh a9cc56b2ac
Add `ComparableExpr` hierarchy for comparing expressions (#1721) 2023-01-07 17:29:21 -05:00
Charlie Marsh 4de6c26ff9
Automatically remove duplicate dictionary keys (#1710) 
For now, to be safe, we're only removing keys with duplicate _values_.

See: #1647.
 2023-01-07 16:16:42 -05:00
Charlie Marsh 98856e05d6 Fix clippy errors 2023-01-07 15:49:59 -05:00
Charlie Marsh edf46c06d0 Bump version to 0.0.214 2023-01-07 15:34:45 -05:00
Chammika Mannakkara 9cfce61f36
flake8_simplify : SIM210, SIM211, SIM212 (#1717) 2023-01-07 15:32:34 -05:00
Charlie Marsh bdb9a4d1a7
Update CONTRIBUTING.md to point to violations.rs (#1720) 2023-01-07 15:20:21 -05:00
Martin Fischer 82e0c0ced6 structs 9/9: Run cargo test and cargo insta accept 2023-01-07 15:14:58 -05:00
Martin Fischer 6a723b50c7 structs 8/9: Run cargo fix and cargo fmt 2023-01-07 15:14:58 -05:00
Martin Fischer 6208eb7bbf structs 7/9: Manually fix errors introduced in the previous commit 2023-01-07 15:14:58 -05:00
Martin Fischer 43db446dfa structs 6/9: Automatically change CheckKind::* to violations::* 
The changes in this commit were generated by running:

for f in $(find src -name '*.rs'); do sed -Ei 's/use crate::registry::.*;/\0use crate::violations;/g' $f; done
for f in $(find src -name '*.rs'); do sed -Ei 's/CheckKind::([A-Z])/violations::\1/g' $f; done
git checkout src/registry.rs src/lib.rs src/lib_wasm.rs src/violations.rs
cargo +nightly fmt
 2023-01-07 15:14:58 -05:00
Martin Fischer 3c8fdbf107 structs 5/9: Make Check::new call into() on the passed kind 2023-01-07 15:14:58 -05:00
Martin Fischer 54fb47ea6a structs 4/9: Implement define_rule_mapping! 2023-01-07 15:14:58 -05:00