Commit Graph

1744 Commits

Author SHA1 Message Date
Greger 9671922e40
Do not use code location for Gitlab fingerprints. (#7203) 2023-09-08 08:25:26 +02:00
Charlie Marsh 6661be2c30
Use full range for SIM105 fixes (#7221)
Avoids inserting an accidental extra newline after the fix _and_
addresses the case of a trailing semicolon.
2023-09-07 16:16:43 +01:00
Charlie Marsh 97f945651d
Change SIM118 to delete `.keys()` rather than replace expression (#7223)
Also improves the suggestion text. Closes
https://github.com/astral-sh/ruff/issues/7200.
2023-09-07 16:16:24 +01:00
Charlie Marsh 5cea43731e
Add required space for FLY002 fixes (#7222)
Closes https://github.com/astral-sh/ruff/issues/7197.
2023-09-07 14:32:43 +00:00
Jaap Roes 7971e0b0ee
Add `extend-ignore-names` for `flake8-self` (#7194)
## Summary

Add a configuration option to extend the list of names that can be
accessed without triggering SLF001.

Fixes issue #7018

## Test Plan

Manually tested by creating a python file (`test.py`):

```python
def foo(obj):
    obj._meta
```

and a `ruff.toml` file:

```toml
select = ["SLF"]

[flake8-self]
extend-ignore-names = ["_meta"]
```

Then running `cargo run -p ruff_cli -- check test.py --no-cache` (once
with the `extend-ignore-names` line comment out) to see if the
configuration option works.

---------

Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
2023-09-07 13:41:22 +00:00
Charlie Marsh fda48afc23
Add required space to C416 fix (#7204)
Closes https://github.com/astral-sh/ruff/issues/7196.
2023-09-06 16:25:02 +00:00
Charlie Marsh c1af1c291d
Add required space to UP006 and UP007 fixes (#7202)
We're removing a set of brackets here so we need to pad the fix.

Closes https://github.com/astral-sh/ruff/issues/7201.
2023-09-06 16:06:02 +00:00
Charlie Marsh fa0b6f4813
Avoid attempting to fix SIM105 violations with multi-statement lines (#7191)
I may revisit this and fix it "properly", but so rare that it's worth
disabling for now: https://github.com/astral-sh/ruff/issues/7123.
2023-09-06 13:35:46 +00:00
Charlie Marsh eab85aea1a
Use structured types for C417 comprehension target (#7190)
Rather than manually joining the arguments as a comma-separated string,
and treating that comma-separated string as a name.
2023-09-06 13:20:04 +00:00
Charlie Marsh 5b31524920
Parenthesize C417 targets if necessary (#7189)
Closes https://github.com/astral-sh/ruff/issues/7121.
2023-09-06 12:56:47 +00:00
Charlie Marsh 6d0469638c
Avoid attempting to fix NPY001 with overridden builtins (#7187) 2023-09-06 12:24:37 +00:00
Charlie Marsh 29ba2bb943
Add required space when fixing C404 (#7185) 2023-09-06 13:05:39 +01:00
Charlie Marsh f0ea40a68d
Restructure signatures of `flake8_comprehensions` fixers (#7186) 2023-09-06 12:04:50 +00:00
Tom Kuson b3e8eca871
Rename `PLR1714` to `repeated-equality-comparison` (#7182) 2023-09-06 12:46:48 +01:00
konsti e3114a144c
Ignore single quote docstrings with newline escape (#7173) 2023-09-06 10:51:50 +02:00
Dhruv Manilawala 04f2842e4f
Move `ExprConstant::kind` to `StringConstant::unicode` (#7180) 2023-09-06 07:39:25 +00:00
Micha Reiser 31990b8d3f
Checker: Remove unnecessary unreachable (#7181) 2023-09-06 07:21:03 +00:00
Dhruv Manilawala ea7c394817
Copy the starred argument as is for `PLW3301` autofix (#7177) 2023-09-06 08:57:05 +05:30
Charlie Marsh 264d9159f8
Add required space when fixing UP024 (#7171) 2023-09-05 17:37:09 +00:00
Charlie Marsh 37dfb205b1
Remove autofix for ambiguous unicode rules (#7168) 2023-09-05 17:22:18 +00:00
Charlie Marsh f8e4e1d562
Fix named expression precedence in generator (#7170) 2023-09-05 17:06:57 +00:00
Charlie Marsh 89be850b73
Add required space when fixing SIM300 (#7167) 2023-09-05 17:00:07 +00:00
Zanie Blue d68041ba24
Fix B006 when function docstring is followed by whitespace but no newline (#7160) 2023-09-05 11:10:57 -05:00
Charlie Marsh b60b37e866
Split within `not`, rather than outside of `not`, for PT018 (#7151) 2023-09-05 14:50:16 +00:00
Charlie Marsh 7ead2c17b1
Add required space when fixing C402 (#7152) 2023-09-05 12:19:33 +00:00
Charlie Marsh e428099e4c
Add required space when fixing SIM118 (#7150) 2023-09-05 11:51:34 +00:00
Charlie Marsh 7a83fd9926
Insert required space when fixing B013 (#7148) 2023-09-05 12:49:11 +01:00
Charlie Marsh e8f78fa2cf
Avoid fixing UP022 when `capture_output` is provided (#7149) 2023-09-05 11:44:17 +00:00
Charlie Marsh 955501f267
Use generator for UP007 autofix (#7137) 2023-09-05 11:41:53 +00:00
Charlie Marsh 5ec73a6137
Avoid triggering N806 on `TypeAlias` assignments (#7119) 2023-09-04 08:44:28 +00:00
Dhruv Manilawala 1067261a55
Make `SourceKind` a required parameter (#7013) 2023-09-04 07:45:59 +00:00
Charlie Marsh 834566f34f
Retain parentheses when fixing `SIM210` (#7118) 2023-09-03 22:39:23 +00:00
Charlie Marsh a56121672c
Add parentheses when simplifying conditions in SIM222 (#7117) 2023-09-03 22:35:59 +00:00
Charlie Marsh c004e03395
Add space after return when inlining number for RET504 (#7116) 2023-09-03 21:33:41 +00:00
Charlie Marsh b57ddd54d2
Support parenthesized expressions in UP028 (#7114) 2023-09-03 21:20:09 +00:00
Charlie Marsh c7217e34d7
Avoid adding duplicate `text` keyword to `subprocess.run` (#7112) 2023-09-03 21:17:04 +00:00
Charlie Marsh d70247959c
Avoid adding duplicate `capture_output` keyword to `subprocess.run` (#7113) 2023-09-03 21:14:56 +00:00
Charlie Marsh 911d4f2918
Handle parenthesized calls in PD002 (#7111) 2023-09-03 21:03:55 +00:00
Charlie Marsh d9cf31f355
Expand F841 fixes to handle parenthesized targets (#7110) 2023-09-03 21:00:44 +00:00
Charlie Marsh 9c3b2c3c3c
Parenthesize expressins when converting to B009 (#7091) 2023-09-03 17:50:38 +01:00
Charlie Marsh 37d244d178
Add newline if B006 fix is at end-of-file (#7090) 2023-09-03 17:35:59 +01:00
Charlie Marsh dbb34804a4
Change `Option<Result>` to `Result<Option>` in importer (#7089) 2023-09-03 16:23:42 +00:00
Charlie Marsh 3c7486817b
Use symbol import for NPY003 replacement (#7083) 2023-09-03 16:53:28 +01:00
Charlie Marsh 3c3c5b5c57
Support length-2 lists in dictionary comprehension rewrites (#7081) 2023-09-03 13:34:10 +00:00
Charlie Marsh b0d171ac19
Supported starred exceptions in length-one tuple detection (#7080) 2023-09-03 13:31:13 +00:00
Charlie Marsh b70dde4a77
Avoid attempting to fix invalid `Optional` annotations (#7079) 2023-09-03 13:23:36 +00:00
Dhruv Manilawala 4eaa412370
Update LibCST (#7062)
## Summary

This PR updates the revision of `LibCST` dependency to 9c263aa897
inorder to fix https://github.com/astral-sh/ruff/issues/4899

## Test Plan

The test case including the carriage return (`\r`) character was added for
`F504` and then `cargo test`.

fixes: #4899
2023-09-03 09:11:24 +05:30
Charlie Marsh 45680bbb44
Avoid duplicate fixes for multi-import imports in RUF017 (#7063)
If a user has `import collections, functools, operator`, and we try to
import from `functools` and `operator`, we end up adding two identical
synthetic edits to preserve that import statement. We need to dedupe
them.

Closes https://github.com/astral-sh/ruff/issues/7059.
2023-09-02 12:58:18 +01:00
Justin Prieto 71ff6f911d
Fix `getattr` calls on int literals (#7057) 2023-09-02 11:45:35 +00:00
Charlie Marsh 2f3a950f6f
Bump version to 0.0.287 (#7038) 2023-09-01 17:32:26 +01:00