Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ruff/crates/ruff_linter/resources/test/fixtures/pyupgrade
History
Dhruv Manilawala b021b5babe
Use `Tokens` from parsed type annotation or parsed source (#11740) 
## Summary

This PR fixes a bug where the checker would require the tokens for an
invalid offset w.r.t. the source code.

Taking the source code from the linked issue as an example:
```py
relese_version :"0.0is 64"
```

Now, this isn't really a valid type annotation but that's what this PR
is fixing. Regardless of whether it's valid or not, Ruff shouldn't
panic.

The checker would visit the parsed type annotation (`0.0is 64`) and try
to detect any violations. Certain rule logic requests the tokens for the
same but it would fail because the lexer would only have the `String`
token considering original source code. This worked before because the
lexer was invoked again for each rule logic.

The solution is to store the parsed type annotation on the checker if
it's in a typing context and use the tokens from that instead if it's
available. This is enforced by creating a new API on the checker to get
the tokens.

But, this means that there are two ways to get the tokens via the
checker API. I want to restrict this in a follow-up PR (#11741) to only
expose `tokens` and `comment_ranges` as methods and restrict access to
the parsed source code.

fixes: #11736 

## Test Plan

- [x] Add a test case for `F632` rule and update the snapshot
- [x] Check all affected rules
- [x] No ecosystem changes
 		2024-06-05 07:50:33 +00:00
..
UP001.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP003.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP004.py Improve handling of builtin symbols in linter rules (#10919) 2024-04-16 11:37:31 +01:00
UP005.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP006_0.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP006_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP006_2.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP006_3.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP007.py Fix unnecessary parentheses in UP007 fix (#8610) 2023-11-10 19:15:09 -05:00
UP008.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_0.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_2.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_3.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_4.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_5.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_6.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_7.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_8.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_9.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP009_10.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP010.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP011.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP012.py Use `Tokens` from parsed type annotation or parsed source (#11740) 2024-06-05 07:50:33 +00:00
UP013.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP014.py Avoid triggering `NamedTuple` rewrite with starred annotation (#8434) 2023-11-02 03:30:52 +00:00
UP015.py Don't suggest replacing `builtin.open()` with `Path.open()` if the latter doesn't support all options (#7637) 2023-09-26 09:07:35 +00:00
UP015_1.py Use `Tokens` from parsed type annotation or parsed source (#11740) 2024-06-05 07:50:33 +00:00
UP017.py Avoid failures due to non-deterministic binding ordering (#10478) 2024-03-19 18:01:33 +00:00
UP018.py [`pyupgrade`] Detect literals with unary operators (`UP018`) (#10060) 2024-02-20 18:21:06 +00:00
UP019.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP020.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP021.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP022.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP023.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP024_0.py Treat `os.error` as an `OSError` alias (#7582) 2023-09-21 21:18:14 +00:00
UP024_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP024_2.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP024_3.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP024_4.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP025.py Remove special pre-visit for module docstrings (#9261) 2023-12-23 10:03:12 -05:00
UP026.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP027.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP028_0.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP028_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP029.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP030_0.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP030_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP031_0.py Use `Tokens` from parsed type annotation or parsed source (#11740) 2024-06-05 07:50:33 +00:00
UP031_1.py [UP031] When encountering `"%s" % var` offer unsafe fix (#11019) 2024-04-22 08:40:51 -07:00
UP032_0.py Use `Tokens` from parsed type annotation or parsed source (#11740) 2024-06-05 07:50:33 +00:00
UP032_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP032_2.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP032_3.py Avoid converting f-strings within Django `gettext` calls (#7898) 2023-10-10 16:31:09 +00:00
UP033_0.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP033_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP034.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP035.py Update UP035 for Python 3.13 and the latest version of typing_extensions (#11693) 2024-06-02 22:59:48 +01:00
UP036_0.py Make tests aware that py313 is the latest supported Python version (#11690) 2024-06-02 13:06:04 +00:00
UP036_1.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP036_2.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP036_3.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP036_4.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP036_5.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP037_0.py Mark quotes as unnecessary for non-evaluated annotations (#11485) 2024-05-22 15:44:31 -04:00
UP037_1.py Mark quotes as unnecessary for non-evaluated annotations (#11485) 2024-05-22 15:44:31 -04:00
UP038.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP039.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00
UP040.py [`pyupgrade`] Support `TypeAliasType` in `UP040` (#11530) 2024-05-26 19:05:35 +00:00
UP040.pyi Update `non-pep695-type-alias` to require `--unsafe-fixes` outside of stub files (#7836) 2023-10-06 14:56:40 -05:00
UP041.py Add pyupgrade `UP041` to replace `TimeoutError` aliases (#8476) 2023-11-03 17:24:47 +00:00
UP042.py [`pyupgrade`] Replace `str, Enum` with `StrEnum` (`UP042`) (#10713) 2024-04-06 01:56:28 +00:00
future_annotations.py Rename `ruff` crate to `ruff_linter` (#7529) 2023-09-20 08:38:27 +02:00