mirror of https://github.com/astral-sh/ruff
60132da7bb
## Summary This PR refactors the error-handling cases around Jupyter notebooks to use errors rather than `Box<Diagnostics>`, which creates some oddities in the downstream handling. So, instead of formatting errors as diagnostics _eagerly_ (in the notebook methods), we now return errors and convert those errors to diagnostics at the last possible moment (in `diagnostics.rs`). This is more ergonomic, as errors can be composed and reported-on in different ways, whereas diagnostics require a `Printer`, etc. See, e.g., https://github.com/astral-sh/ruff/pull/7013#discussion_r1311136301. ## Test Plan Ran `cargo run` over a Python file labeled with a `.ipynb` suffix, and saw: ``` foo.ipynb:1:1: E999 SyntaxError: Expected a Jupyter Notebook, which must be internally stored as JSON, but found a Python source file: expected value at line 1 column 1 ``` |
||
|---|---|---|
| .. | ||
| bin | ||
| commands | ||
| args.rs | ||
| cache.rs | ||
| diagnostics.rs | ||
| lib.rs | ||
| panic.rs | ||
| printer.rs | ||
| resolve.rs | ||
| stdin.rs | ||