ruff/crates/ty_python_semantic at 0d4f7dde9967704767d8515aadcf8c94353dde35 - ruff

mirror of https://github.com/astral-sh/ruff synced 2026-01-10 08:04:26 -05:00

Files

David Peter 0d4f7dde99 [ty] Treat __new__ as a static method (#20212 )

## Summary

Pull this out of https://github.com/astral-sh/ruff/pull/18473 as an
isolated change to make sure it has no adverse effects.

The wrong behavior is observable on `main` for something like
```py
class C:
    def __new__(cls) -> "C":
        cls.x = 1

C.x  # previously: Attribute `x` can only be accessed on instances
     # now:        Type `<class 'C'>` has no attribute `x`
```
where we currently treat `x` as an *instance* attribute (because we
consider `__new__` to be a normal function and `cls` to be the "self"
attribute). With this PR, we do not consider `x` to be an attribute,
neither on the class nor on instances of `C`. If this turns out to be an
important feature, we should add it intentionally, instead of
accidentally.

## Test Plan

Ecosystem checks.

2025-09-03 19:55:20 +02:00