mirror of
https://github.com/astral-sh/ruff
synced 2026-01-21 21:40:51 -05:00
3c1c1e1dd3
This commit series refactors ruff to decouple "rules" from "rule codes", in order to: 1. Make our code more readable by changing e.g. RuleCode::UP004 to Rule::UselessObjectInheritance. 2. Let us cleanly map multiple codes to one rule, for example: [UP004] in pyupgrade, [R0205] in pylint and [PIE792] in flake8-pie all refer to the rule UselessObjectInheritance but ruff currently only associates that rule with the UP004 code (since the implementation was initially modeled after pyupgrade). 3. Let us cleanly map one code to multiple rules, for example: [C0103] from pylint encompasses N801, N802 and N803 from pep8-naming. The latter two steps are not yet implemented by this commit series but this refactoring enables us to introduce such a mapping. Such a mapping would also let us expand flake8_to_ruff to support e.g. pylint. After the next commit which just does some renaming the following four commits remove all trait derivations from the Rule (previously RuleCode) enum that depend on the variant names to guarantee that they are not used anywhere anymore so that we can rename all of these variants in the eigth and final commit without breaking anything. While the plan very much is to also surface these human-friendly names more in the user interface this is not yet done in this commit series, which does not change anything about the UI: it's purely a refactor. [UP004]: pyupgrade doesn't actually assign codes to its messages. [R0205]: https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/useless-object-inheritance.html [PIE792]: https://github.com/sbdchd/flake8-pie#pie792-no-inherit-object [C0103]: https://pylint.pycqa.org/en/latest/user_guide/messages/convention/invalid-name.html