mirror of
https://github.com/astral-sh/ruff
synced 2026-01-22 14:00:51 -05:00
c9dff5c7d5
## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
45 lines
1.2 KiB
Rust
45 lines
1.2 KiB
Rust
use ruff_python_ast::AnyNodeRef;
|
|
use ruff_python_ast::ExprSet;
|
|
use ruff_text_size::Ranged;
|
|
|
|
use crate::expression::parentheses::{NeedsParentheses, OptionalParentheses, parenthesized};
|
|
use crate::prelude::*;
|
|
|
|
#[derive(Default)]
|
|
pub struct FormatExprSet;
|
|
|
|
impl FormatNodeRule<ExprSet> for FormatExprSet {
|
|
fn fmt_fields(&self, item: &ExprSet, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let ExprSet {
|
|
range: _,
|
|
node_index: _,
|
|
elts,
|
|
} = item;
|
|
// That would be a dict expression
|
|
assert!(!elts.is_empty());
|
|
// Avoid second mutable borrow of f
|
|
let joined = format_with(|f: &mut PyFormatter| {
|
|
f.join_comma_separated(item.end())
|
|
.nodes(elts.iter())
|
|
.finish()
|
|
});
|
|
|
|
let comments = f.context().comments().clone();
|
|
let dangling = comments.dangling(item);
|
|
|
|
parenthesized("{", &joined, "}")
|
|
.with_dangling_comments(dangling)
|
|
.fmt(f)
|
|
}
|
|
}
|
|
|
|
impl NeedsParentheses for ExprSet {
|
|
fn needs_parentheses(
|
|
&self,
|
|
_parent: AnyNodeRef,
|
|
_context: &PyFormatContext,
|
|
) -> OptionalParentheses {
|
|
OptionalParentheses::Never
|
|
}
|
|
}
|