Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-22 05:51:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
556abf4bd37101218334d2664a83872a3c76e1fa
ruff/crates/ruff_python_formatter/tests/snapshots
History
Charlie Marsh 4c53bfe896 Add formatter support for call and class definition Arguments (#6274) 
## Summary

This PR leverages the `Arguments` AST node introduced in #6259 in the
formatter, which ensures that we correctly handle trailing comments in
calls, like:

```python
f(
  1,
  # comment
)

pass
```

(Previously, this was treated as a leading comment on `pass`.)

This also allows us to unify the argument handling across calls and
class definitions.

## Test Plan

A bunch of new fixture tests, plus improved Black compatibility.
2023-08-02 11:54:22 -04:00
..
black_compatibility@conditional_expression.py.snap
Format expr generator exp (#5804)
2023-07-19 13:01:58 +02:00
black_compatibility@miscellaneous__blackd_diff.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__debug_visitor.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@miscellaneous__decorators.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
black_compatibility@miscellaneous__docstring_no_string_normalization.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__docstring_preview_no_string_normalization.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@miscellaneous__force_pyi.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@miscellaneous__long_strings_flag_disabled.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@miscellaneous__power_op_newline.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__string_quotes.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@py_38__pep_570.py.snap
Format lambda expression (#5806)
2023-07-19 11:47:56 +00:00
black_compatibility@py_39__pep_572_py39.py.snap
Format SetComp (#5774)
2023-07-15 15:50:47 +01:00
black_compatibility@py_39__python39.py.snap
Remove parentheses around some walrus operators (#6173)
2023-07-29 10:06:26 -04:00
black_compatibility@py_310__pattern_matching_complex.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_310__pattern_matching_extras.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@py_310__pattern_matching_generic.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@py_310__pattern_matching_simple.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_310__pattern_matching_style.py.snap
Don't add a magic trailing comma for a single entry (#5463)
2023-07-03 21:48:44 +02:00
black_compatibility@py_310__pep_572_py310.py.snap
Format expr generator exp (#5804)
2023-07-19 13:01:58 +02:00
black_compatibility@py_310__remove_newline_after_match.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_312__type_aliases.py.snap
Type alias stub for formatter (#5880)
2023-07-19 17:28:07 +02:00
black_compatibility@py_312__type_params.py.snap
Type alias stub for formatter (#5880)
2023-07-19 17:28:07 +02:00
black_compatibility@simple_cases__attribute_access_on_number_literals.py.snap
Format numeric constants (#5972)
2023-07-24 07:04:40 +00:00
black_compatibility@simple_cases__comment_after_escaped_newline.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__comments2.py.snap
Format bytes string (#6166)
2023-07-31 10:46:40 +02:00
black_compatibility@simple_cases__comments4.py.snap
Pass parent to NeedsParentheses (#5708)
2023-07-13 08:57:29 +02:00
black_compatibility@simple_cases__comments6.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
black_compatibility@simple_cases__comments9.py.snap
Remove newline-insertion logic from JoinNodesBuilder (#6205)
2023-07-31 16:58:15 -04:00
black_compatibility@simple_cases__comments_non_breaking_space.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__composition_no_trailing_comma.py.snap
Respect indent when measuring with MeasureMode::AllLines (#6120)
2023-07-27 10:22:13 -04:00
black_compatibility@simple_cases__composition.py.snap
Respect indent when measuring with MeasureMode::AllLines (#6120)
2023-07-27 10:22:13 -04:00
black_compatibility@simple_cases__docstring_preview.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@simple_cases__docstring.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__empty_lines.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@simple_cases__expression.py.snap
Format bytes string (#6166)
2023-07-31 10:46:40 +02:00
black_compatibility@simple_cases__fmtonoff2.py.snap
Format assert statement (#5168)
2023-07-14 09:01:33 +02:00
black_compatibility@simple_cases__fmtonoff3.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtonoff4.py.snap
Don't add a magic trailing comma for a single entry (#5463)
2023-07-03 21:48:44 +02:00
black_compatibility@simple_cases__fmtonoff5.py.snap
Pass parent to NeedsParentheses (#5708)
2023-07-13 08:57:29 +02:00
black_compatibility@simple_cases__fmtonoff.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@simple_cases__fmtskip2.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip3.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip5.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
black_compatibility@simple_cases__fmtskip7.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip8.py.snap
Rewrite placement logic (#6040)
2023-07-26 16:21:23 +00:00
black_compatibility@simple_cases__fmtskip.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__function2.py.snap
Add empty lines before nested functions and classes (#6206)
2023-08-01 15:30:59 +00:00
black_compatibility@simple_cases__function.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@simple_cases__ignore_pyi.py.snap
Rewrite placement logic (#6040)
2023-07-26 16:21:23 +00:00
black_compatibility@simple_cases__import_spacing.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__multiline_consecutive_open_parentheses_ignore.py.snap
Type alias stub for formatter (#5880)
2023-07-19 17:28:07 +02:00
black_compatibility@simple_cases__power_op_spacing.py.snap
Format lambda expression (#5806)
2023-07-19 11:47:56 +00:00
black_compatibility@simple_cases__remove_await_parens.py.snap
Format ExprYield/ExprYieldFrom (#5921)
2023-07-21 12:07:51 +00:00
black_compatibility@simple_cases__remove_except_parens.py.snap
Format raise statement (#5595)
2023-07-10 21:23:49 +02:00
black_compatibility@simple_cases__remove_for_brackets.py.snap
Format lambda expression (#5806)
2023-07-19 11:47:56 +00:00
black_compatibility@simple_cases__remove_parens.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
black_compatibility@simple_cases__return_annotation_brackets.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@simple_cases__torture.py.snap
Format assert statement (#5168)
2023-07-14 09:01:33 +02:00
black_compatibility@simple_cases__trailing_comma_optional_parens3.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__trailing_commas_in_leading_parts.py.snap
Format assert statement (#5168)
2023-07-14 09:01:33 +02:00
black_compatibility@simple_cases__tupleassign.py.snap
Format bytes string (#6166)
2023-07-31 10:46:40 +02:00
black_compatibility@simple_cases__whitespace.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
format@carriage_return__string.py.snap
Normalize '\r' in string literals to '\n'
2023-06-30 10:13:23 +02:00
format@expression__annotated_assign.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
format@expression__attribute.py.snap
Placement refactor (#6034)
2023-07-25 11:49:05 +02:00
format@expression__binary_implicit_string.py.snap
Prefer breaking the implicit string concatenation over breaking before % (#5947)
2023-07-24 18:30:42 +02:00
format@expression__binary.py.snap
Avoid line break before for in comprehension if outer expression expands (#5912)
2023-07-20 10:07:22 +00:00
format@expression__boolean_operation.py.snap
Format call expressions (without call chaining) (#5341)
2023-06-27 09:29:40 +00:00
format@expression__bytes.py.snap
Format bytes string (#6166)
2023-07-31 10:46:40 +02:00
format@expression__call.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@expression__compare.py.snap
Cover Black's is_aritmetic_like formatting (#5738)
2023-07-14 17:54:58 +02:00
format@expression__dict_comp.py.snap
Avoid line break before for in comprehension if outer expression expands (#5912)
2023-07-20 10:07:22 +00:00
format@expression__dict.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@expression__generator_exp.py.snap
Format expr generator exp (#5804)
2023-07-19 13:01:58 +02:00
format@expression__if.py.snap
Fix find_only_token_in_range with expression parentheses (#5645)
2023-07-10 15:55:19 +02:00
format@expression__joined_string.py.snap
format ExprJoinedStr (#5932)
2023-08-01 08:26:30 +02:00
format@expression__lambda.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@expression__list_comp.py.snap
Update TupleParentheses usage (#5810)
2023-07-24 14:44:36 +00:00
format@expression__list.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@expression__named_expr.py.snap
Remove parentheses around some walrus operators (#6173)
2023-07-29 10:06:26 -04:00
format@expression__set_comp.py.snap
Avoid line break before for in comprehension if outer expression expands (#5912)
2023-07-20 10:07:22 +00:00
format@expression__slice.py.snap
Improve slice formatting (#5922)
2023-07-20 15:05:18 +00:00
format@expression__starred.py.snap
Placement refactor (#6034)
2023-07-25 11:49:05 +02:00
format@expression__string.py.snap
Fix formatting of trailing unescaped quotes in raw triple quoted strings (#6202)
2023-07-31 19:25:16 +02:00
format@expression__tuple.py.snap
Format raise statement (#5595)
2023-07-10 21:23:49 +02:00
format@expression__unary.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
format@expression__yield_from.py.snap
Format ExprYield/ExprYieldFrom (#5921)
2023-07-21 12:07:51 +00:00
format@expression__yield.py.snap
Format ExprYield/ExprYieldFrom (#5921)
2023-07-21 12:07:51 +00:00
format@skip_magic_trailing_comma.py.snap
Don't format trailing comma for lambda arguments (#5946)
2023-07-27 10:22:13 -04:00
format@statement__ann_assign.py.snap
Fix StmtAnnAssign formatting by mirroring StmtAssign (#5732)
2023-07-13 10:51:25 +00:00
format@statement__assert.py.snap
Format assert statement (#5168)
2023-07-14 09:01:33 +02:00
format@statement__assign.py.snap
Properly group assignment targets (#5728)
2023-07-13 16:00:49 +02:00
format@statement__aug_assign.py.snap
Fix StmtAnnAssign formatting by mirroring StmtAssign (#5732)
2023-07-13 10:51:25 +00:00
format@statement__break.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00
format@statement__class_definition.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@statement__delete.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@statement__for.py.snap
Pass parent to NeedsParentheses (#5708)
2023-07-13 08:57:29 +02:00
format@statement__function.py.snap
Add empty lines before nested functions and classes (#6206)
2023-08-01 15:30:59 +00:00
format@statement__global.py.snap
Add global and nonlocal formatting (#6170)
2023-07-29 14:39:42 +00:00
format@statement__if.py.snap
Add empty lines before nested functions and classes (#6206)
2023-08-01 15:30:59 +00:00
format@statement__import_from.py.snap
Preserve end-of-line comments on import-from statements (#6216)
2023-08-01 18:58:05 +00:00
format@statement__import.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
format@statement__nonlocal.py.snap
Add global and nonlocal formatting (#6170)
2023-07-29 14:39:42 +00:00
format@statement__raise.py.snap
Add formatter support for call and class definition Arguments (#6274)
2023-08-02 11:54:22 -04:00
format@statement__try.py.snap
Add empty lines before nested functions and classes (#6206)
2023-08-01 15:30:59 +00:00
format@statement__type_alias.py.snap
Type alias stub for formatter (#5880)
2023-07-19 17:28:07 +02:00
format@statement__while.py.snap
Pass parent to NeedsParentheses (#5708)
2023-07-13 08:57:29 +02:00
format@statement__with.py.snap
Fix formatter with-statement after-as own line comment instability (#6033)
2023-07-24 18:12:07 +00:00
format@trivia.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00