mirror of
https://github.com/astral-sh/ruff
synced 2026-01-08 15:14:19 -05:00
5f26411577
While we ran the `pr-comment` workflow on `completed` workflows (i.e. instead of `success`, it can have failed) we used the default artifact download behavior which required `success` workflows (https://github.com/dawidd6/action-download-artifact) which meant that if any jobs failed the ecosystem checks would not be reported. For example, a successful ecosystem run at https://github.com/astral-sh/ruff/actions/runs/6672033727/job/18135290880 was not posted at https://github.com/astral-sh/ruff/actions/runs/6672153598/job/18135534008 because no artifacts met the success criterion. You can see this is "valid" with a manual dispatch at https://github.com/astral-sh/ruff/actions/runs/6672278055/job/18135883849 but it pulls from the latest commit rather than the one with the failed one mentioned above so you can't see verification it'll work for failed jobs. Another manual dispatch at https://github.com/astral-sh/ruff/actions/runs/6672349316/job/18136082917 shows it works great for successful jobs still.