mirror of
https://github.com/astral-sh/ruff
synced 2026-01-22 22:10:48 -05:00
c9dff5c7d5
## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
69 lines
2.0 KiB
Rust
69 lines
2.0 KiB
Rust
use ruff_formatter::write;
|
|
use ruff_python_ast::StmtDelete;
|
|
use ruff_text_size::Ranged;
|
|
|
|
use crate::builders::{PyFormatterExtensions, parenthesize_if_expands};
|
|
use crate::comments::{SourceComment, dangling_node_comments};
|
|
use crate::expression::maybe_parenthesize_expression;
|
|
use crate::expression::parentheses::Parenthesize;
|
|
use crate::{has_skip_comment, prelude::*};
|
|
|
|
#[derive(Default)]
|
|
pub struct FormatStmtDelete;
|
|
|
|
impl FormatNodeRule<StmtDelete> for FormatStmtDelete {
|
|
fn fmt_fields(&self, item: &StmtDelete, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let StmtDelete {
|
|
range: _,
|
|
node_index: _,
|
|
targets,
|
|
} = item;
|
|
|
|
write!(f, [token("del"), space()])?;
|
|
|
|
match targets.as_slice() {
|
|
[] => {
|
|
write!(
|
|
f,
|
|
[
|
|
// Handle special case of delete statements without targets.
|
|
// ```
|
|
// del (
|
|
// # Dangling comment
|
|
// )
|
|
token("("),
|
|
block_indent(&dangling_node_comments(item)),
|
|
token(")"),
|
|
]
|
|
)
|
|
}
|
|
[single] => {
|
|
write!(
|
|
f,
|
|
[maybe_parenthesize_expression(
|
|
single,
|
|
item,
|
|
Parenthesize::IfBreaks
|
|
)]
|
|
)
|
|
}
|
|
targets => {
|
|
let item = format_with(|f| {
|
|
f.join_comma_separated(item.end())
|
|
.nodes(targets.iter())
|
|
.finish()
|
|
});
|
|
parenthesize_if_expands(&item).fmt(f)
|
|
}
|
|
}
|
|
}
|
|
|
|
fn is_suppressed(
|
|
&self,
|
|
trailing_comments: &[SourceComment],
|
|
context: &PyFormatContext,
|
|
) -> bool {
|
|
has_skip_comment(trailing_comments, context.source())
|
|
}
|
|
}
|