Files
ruff/crates/ruff_server
Jane Lewis 791f6a1820 ruff server: Closing an untitled, unsaved notebook document no longer throws an error (#11942)
## Summary

Fixes #11651.
Fixes #11851.

We were double-closing a notebook document from the index, once in
`textDocument/didClose` and then in the `notebookDocument/didClose`
handler. The second time this happens, taking a snapshot fails.

I've rewritten how we handle snapshots for closing notebooks / notebook
cells so that any failure is simply logged instead of propagating
upwards. This implementation works consistently even if we don't receive
`textDocument/didClose` notifications for each specific cell, since they
get closed (and the diagnostics get cleared) in the notebook document
removal process.

## Test Plan

1. Open an untitled, unsaved notebook with the `Create: New Jupyter
Notebook` command from the VS Code command palette (`Ctrl/Cmd + Shift +
P`)
2. Without saving the document, close it.
3. No error popup should appear.
4. Run the debug command (`Ruff: print debug information`) to confirm
that there are no open documents
2024-06-21 10:53:30 -07:00
..

The Ruff Language Server

Welcome!

ruff server is a language server that powers Ruff's editor integrations.

The job of the language server is to listen for requests from the client (in this case, the code editor of your choice) and call into Ruff's linter and formatter crates to construct real-time diagnostics or formatted code, which is then sent back to the client. It also tracks configuration files in your editor's workspace, and will refresh its in-memory configuration whenever those files are modified.

Setup

We have specific setup instructions depending on your editor. If you don't see your editor on this list and would like a setup guide, please open an issue.

If you're transferring your configuration from ruff-lsp, regardless of editor, there are several settings which have changed or are no longer available. See the migration guide for more.

VS Code

Install the Ruff extension from the VS Code Marketplace.

As this server is still in Beta, you will need to enable the "Native Server" extension setting, either in the settings UI:

A screenshot showing an enabled "Native Server" extension setting in the VS Code settings view

Or in your settings.json:

{
  "ruff.nativeServer": true
}

From there, you can configure Ruff to format Python code on-save with:

{
  "[python]": {
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "charliermarsh.ruff"
  }
}

For more, see Configuring VS Code in the Ruff extension documentation.

By default, the extension will run against the ruff binary that it discovers in your environment. If you don't have ruff installed, the extension will fall back to a bundled version of the binary.

Neovim

See the Neovim setup guide.

Helix

See the Helix setup guide.

Vim

See the Vim setup guide.

Kate

See the Kate setup guide.

Contributing

If you're interested in contributing to ruff server - well, first of all, thank you! Second of all, you might find the contribution guide to be a useful resource.

Finally, don't hesitate to reach out on Discord if you have questions.