mirror of https://github.com/astral-sh/ruff synced 2026-01-10 08:04:26 -05:00

Files

Dan Parizher 474b00568a [parser] Fix panic when parsing IPython escape command expressions (#21480 )

## Summary

Fixes a panic when parsing IPython escape commands with `Help` kind
(`?`) in expression contexts. The parser now reports an error instead of
panicking.

Fixes #21465.

## Problem

The parser panicked with `unreachable!()` in
`parse_ipython_escape_command_expression` when encountering escape
commands with `Help` kind (`?`) in expression contexts, where only
`Magic` (`%`) and `Shell` (`!`) are allowed.

## Approach

Replaced the `unreachable!()` panic with error handling that adds a
`ParseErrorType::OtherError` and continues parsing, returning a valid
AST node with the error attached.

## Test Plan

Added `test_ipython_escape_command_in_with_statement` and
`test_ipython_help_escape_command_as_expression` to verify the fix.

---------

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

2025-11-24 05:40:27 +00:00

resources

[parser] Fix panic when parsing IPython escape command expressions (#21480 )

2025-11-24 05:40:27 +00:00

src

[parser] Fix panic when parsing IPython escape command expressions (#21480 )

2025-11-24 05:40:27 +00:00

tests

[parser] Fix panic when parsing IPython escape command expressions (#21480 )

2025-11-24 05:40:27 +00:00

Cargo.toml

[ty] Add environment variable to dump Salsa memory usage stats (#18928 )

2025-06-26 21:27:51 +00:00

CONTRIBUTING.md

Update usage instructions and lockfile for py-fuzzer script (#20940 )

2025-10-17 15:57:17 +01:00

README.md

Add basic docs for the parser crate (#11199 )

2024-04-29 17:08:07 +00:00

README.md

Ruff Python Parser

Ruff's Python parser is a hand-written recursive descent parser which can parse Python source code into an Abstract Syntax Tree (AST). It also utilizes the Pratt parsing technique to parse expressions with different precedence.

Try out the parser in the playground.

Python version support

The parser supports the latest Python syntax, which is currently Python 3.12. It does not throw syntax errors if it encounters a syntax feature that is not supported by the target-version. This will be fixed in a future release (see https://github.com/astral-sh/ruff/issues/6591).

Contributing

Refer to the contributing guidelines to get started and GitHub issues with the parser label for issues that need help.