Brent Westbrook 2643dc5b7a Rename `Diagnostic::syntax_error` methods, separate `Ord` implementation (#19179) ... ## Summary This PR addresses some additional feedback on #19053: - Renaming the `syntax_error` methods to `invalid_syntax` to match the lint id - Moving the standalone `diagnostic_from_violation` function to `Violation::into_diagnostic` - Removing the `Ord` and `PartialOrd` implementations from `Diagnostic` in favor of `Diagnostic::start_ordering` ## Test Plan Existing tests ## Additional Follow-ups Besides these, I also put the following comments on my todo list, but they seemed like they might be big enough to have their own PRs: - [Use `LintId::IOError` for IO errors](https://github.com/astral-sh/ruff/pull/19053#discussion_r2189425922) - [Move `Fix` and `Edit`](https://github.com/astral-sh/ruff/pull/19053#discussion_r2189448647) - [Avoid so many unwraps](https://github.com/astral-sh/ruff/pull/19053#discussion_r2189465980)		2025-07-08 09:54:19 -04:00
..
resources/test/fixtures	Rename `ruff_cli` crate to `ruff` (#9557)	2024-01-16 17:47:01 -05:00
src	Rename `Diagnostic::syntax_error` methods, separate `Ord` implementation (#19179)	2025-07-08 09:54:19 -04:00
tests	Combine `OldDiagnostic` and `Diagnostic` (#19053)	2025-07-03 13:01:09 -04:00
Cargo.toml	Bump 0.12.2 (#19126)	2025-07-03 12:27:24 -04:00
build.rs	Use `#[expect(lint)]` over `#[allow(lint)]` where possible (#17822)	2025-05-03 21:20:31 +02:00