ruff/crates/ty_python_semantic at 9664474c5172c996a0fe5b9053e14a345629e166 - ruff

mirror of https://github.com/astral-sh/ruff synced 2026-01-08 15:14:19 -05:00

Files

Carl Meyer 9664474c51 [ty] rollback preferring declared type on invalid TypedDict creation (#21169 )

## Summary

Discussion with @ibraheemdev clarified that
https://github.com/astral-sh/ruff/pull/21168 was incorrect. In a case of
failed inference of a dict literal as a `TypedDict`, we should store the
context-less inferred type of the dict literal as the type of the dict
literal expression itself; the fallback to declared type should happen
at the level of the overall assignment definition.

The reason the latter isn't working yet is because currently we
(wrongly) consider a homogeneous dict type as assignable to a
`TypedDict`, so we don't actually consider the assignment itself as
failed. So the "bug" I observed (and tried to fix) will naturally be
fixed by implementing TypedDict assignability rules.

Rollback https://github.com/astral-sh/ruff/pull/21168 except for the
tests, and modify the tests to include TODOs as needed.

## Test Plan

Updated mdtests.

2025-10-31 12:06:47 -04:00