Brent Westbrook
71f8389f61
Fix syntax error false positives on parenthesized context managers ( #20846 )
...
This PR resolves the issue noticed in
https://github.com/astral-sh/ruff/pull/20777#discussion_r2417233227 .
Namely, cases like this were being flagged as syntax errors despite
being perfectly valid on Python 3.8:
```pycon
Python 3.8.20 (default, Oct 2 2024, 16:34:12)
[Clang 18.1.8 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> with (open("foo.txt", "w")): ...
...
Ellipsis
>>> with (open("foo.txt", "w")) as f: print(f)
...
<_io.TextIOWrapper name='foo.txt' mode='w' encoding='UTF-8'>
```
The second of these was already allowed but not the first:
```shell
> ruff check --target-version py38 --ignore ALL - <<EOF
with (open("foo.txt", "w")): ...
with (open("foo.txt", "w")) as f: print(f)
EOF
invalid-syntax: Cannot use parentheses within a `with` statement on Python 3.8 (syntax was added in Python 3.9)
--> -:1:6
|
1 | with (open("foo.txt", "w")): ...
| ^
2 | with (open("foo.txt", "w")) as f: print(f)
|
Found 1 error.
```
There was some discussion of related cases in
https://github.com/astral-sh/ruff/pull/16523#discussion_r1984657793 , but
it seems I overlooked the single-element case when flagging tuples. As
suggested in the other thread, we can just check if there's more than
one element or a trailing comma, which will cause the tuple parsing on
<=3.8 and avoid the false positives.
2025-10-13 14:13:27 -04:00
..
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-05-07 14:11:35 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-30 15:04:00 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-30 15:04:00 -04:00
2024-06-03 18:23:50 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-19 16:46:15 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-05 13:19:09 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-06-17 06:47:00 +00:00
2024-06-17 06:47:00 +00:00
2024-06-17 06:47:00 +00:00
2024-06-17 06:47:00 +00:00
2024-04-18 17:57:39 +05:30
2025-03-29 12:07:20 -04:00
2025-03-29 12:07:20 -04:00
2025-03-29 12:07:20 -04:00
2025-03-29 12:07:20 -04:00
2025-03-29 12:07:20 -04:00
2025-03-29 12:07:20 -04:00
2025-03-29 12:07:20 -04:00
2025-03-17 11:17:27 +00:00
2025-03-17 11:17:27 +00:00
2025-03-05 17:08:18 +00:00
2025-03-17 11:17:27 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-05 17:08:18 +00:00
2025-03-17 11:17:27 +00:00
2024-04-18 17:57:39 +05:30
2025-03-29 12:07:20 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-03 17:55:37 -04:00
2025-04-03 17:55:37 -04:00
2025-03-21 15:06:22 -04:00
2025-03-04 16:50:09 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-29 07:55:30 -05:00
2025-04-29 07:55:30 -05:00
2025-06-16 11:44:42 -05:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-13 15:55:17 -04:00
2024-04-18 17:57:39 +05:30
2024-04-23 04:19:05 +00:00
2024-04-23 04:19:05 +00:00
2024-04-23 04:19:05 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-05 13:19:09 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-09-16 15:53:28 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-08 08:55:43 -04:00
2025-04-08 08:55:43 -04:00
2025-04-08 08:55:43 -04:00
2025-04-08 08:56:25 -04:00
2025-04-08 08:55:43 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-09-25 13:52:24 -04:00
2024-04-18 17:57:39 +05:30
2025-03-26 12:27:16 -04:00
2025-03-06 11:57:20 -05:00
2025-03-06 11:57:20 -05:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-02-27 10:23:15 -05:00
2024-06-03 18:23:50 +05:30
2024-06-03 18:23:50 +05:30
2024-06-03 18:23:50 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-06-03 18:23:50 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-03 17:32:39 -04:00
2024-04-18 17:57:39 +05:30
2025-09-24 19:32:55 +00:00
2025-03-14 15:06:42 -04:00
2025-03-14 15:06:42 -04:00
2025-04-08 12:50:52 -04:00
2024-04-19 11:36:26 +00:00
2025-04-24 16:11:46 -04:00
2025-04-24 16:11:46 -04:00
2025-04-24 16:11:46 -04:00
2025-04-24 16:11:46 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-14 15:20:44 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-17 08:54:55 -04:00
2025-03-06 12:18:13 -05:00
2025-03-18 11:12:15 -04:00
2025-03-05 13:46:43 +00:00
2024-12-19 13:36:32 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-21 14:45:25 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-04-02 08:38:25 -04:00
2025-04-02 08:38:25 -04:00
2025-04-02 08:38:25 -04:00
2025-03-29 12:35:47 -04:00
2025-03-14 14:51:34 +00:00
2025-03-14 14:51:34 +00:00
2025-05-30 15:00:56 -05:00
2025-05-30 15:00:56 -05:00
2025-05-30 15:00:56 -05:00
2025-05-30 15:00:56 -05:00
2025-05-30 15:00:56 -05:00
2025-05-30 15:00:56 -05:00
2025-05-30 15:00:56 -05:00
2025-07-27 12:41:03 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-12-10 17:50:55 -06:00
2025-10-13 14:13:27 -04:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2025-03-04 16:53:38 +00:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-26 09:47:29 +02:00
2024-04-26 09:47:29 +02:00
2024-04-26 09:47:29 +02:00
2024-04-26 09:47:29 +02:00
2024-04-18 17:57:39 +05:30
2024-04-26 09:47:29 +02:00
2024-04-26 09:47:29 +02:00
2024-06-26 08:10:35 +05:30
2025-03-04 17:20:10 +00:00
2025-03-14 15:06:42 -04:00
2025-03-14 15:06:42 -04:00
2025-03-14 15:06:42 -04:00
2024-04-18 17:57:39 +05:30
2025-02-28 17:13:46 -05:00
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-04-18 17:57:39 +05:30
2024-06-06 08:59:56 +00:00
2024-04-18 17:57:39 +05:30
2025-03-29 12:07:20 -04:00
2025-09-03 10:13:05 -04:00