Brent Westbrook 96f3c8d1ab Convert `OldDiagnostic::noqa_code` to an `Option<String>` (#18946) ... ## Summary I think this should be the last step before combining `OldDiagnostic` and `ruff_db::Diagnostic`. We can't store a `NoqaCode` on `ruff_db::Diagnostic`, so I converted the `noqa_code` field to an `Option<String>` and then propagated this change to all of the callers. I tried to use `&str` everywhere it was possible, so I think the remaining `to_string` calls are necessary. I spent some time trying to convert _everything_ to `&str` but ran into lifetime issues, especially in the `FixTable`. Maybe we can take another look at that if it causes a performance regression, but hopefully these paths aren't too hot. We also avoid some `to_string` calls, so it might even out a bit too. ## Test Plan Existing tests --------- Co-authored-by: Micha Reiser <micha@reiser.io>		2025-06-27 11:36:55 -04:00
..
lib.rs	Convert `OldDiagnostic::noqa_code` to an `Option<String>` (#18946)	2025-06-27 11:36:55 -04:00