From 259a835ab6ea51ba03f1d37bef075920d06f3b2d Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Fri, 10 Nov 2023 13:50:59 -0500 Subject: [PATCH] pep440-rs: don't allocate when retrieving a version number It's not clear whether these routines are used in any hot path so I don't know whether this will have a perf improvement, but there's really no reason not to do this. --- crates/pep440-rs/src/version.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/pep440-rs/src/version.rs b/crates/pep440-rs/src/version.rs index e292ab215..f2b0dd145 100644 --- a/crates/pep440-rs/src/version.rs +++ b/crates/pep440-rs/src/version.rs @@ -355,17 +355,17 @@ impl PyVersion { #[getter] #[allow(clippy::get_first)] pub fn major(&self) -> u32 { - self.release().get(0).copied().unwrap_or_default() + self.0.release.get(0).copied().unwrap_or_default() } /// The second item of release or 0 if unavailable. #[getter] pub fn minor(&self) -> u32 { - self.release().get(1).copied().unwrap_or_default() + self.0.release.get(1).copied().unwrap_or_default() } /// The third item of release or 0 if unavailable. #[getter] pub fn micro(&self) -> u32 { - self.release().get(2).copied().unwrap_or_default() + self.0.release.get(2).copied().unwrap_or_default() } /// Parses a PEP 440 version string