Python
/
uv
mirror of https://github.com/astral-sh/uv
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove TODO around atomic writes (#11710) 

## Summary

We chatted about this a bit on Discord, and I think it's not required.
This commit is contained in:
Charlie Marsh 2025-02-22 12:12:12 -10:00 committed by GitHub
parent efc8d94e65
commit 3fe2882fd5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/uv-fs/src/lib.rs
View File

@ -117,8 +117,6 @@ pub fn replace_symlink(src: impl AsRef<Path>, dst: impl AsRef<Path>) -> std::io:
/// Create a symlink at `dst` pointing to `src`, replacing any existing symlink if necessary. /// Create a symlink at `dst` pointing to `src`, replacing any existing symlink if necessary.
/// ///
/// On Unix, this method creates a temporary file, then moves it into place. /// On Unix, this method creates a temporary file, then moves it into place.
///
/// TODO(charlie): Consider using the `rust-atomicwrites` crate.
#[cfg(unix)] #[cfg(unix)]
pub fn replace_symlink(src: impl AsRef<Path>, dst: impl AsRef<Path>) -> std::io::Result<()> { pub fn replace_symlink(src: impl AsRef<Path>, dst: impl AsRef<Path>) -> std::io::Result<()> {
// Attempt to create the symlink directly. // Attempt to create the symlink directly.