Python
/
uv
mirror of https://github.com/astral-sh/uv
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve styling of `requires-python` warnings (#8240) 

Extends #7959

While I was looking at that message, I noticed I didn't love the
readability of the existing message and opted to follow-up with a change
to them both.
This commit is contained in:
Zanie Blue 2024-10-16 13:08:21 -05:00 committed by GitHub
parent d5b5b82409
commit 6ac5859b1a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/uv/src/commands/project/lock.rs
View File

@ -334,9 +334,9 @@ async fn do_lock(
if requires_python.is_unbounded() { if requires_python.is_unbounded() {
let default = let default =
RequiresPython::greater_than_equal_version(&interpreter.python_minor_version()); RequiresPython::greater_than_equal_version(&interpreter.python_minor_version());
warn_user_once!("The workspace `requires-python` value does not contain a lower bound: `{requires_python}`. Set a lower bound to indicate the minimum compatible Python version (e.g., `{default}`)."); warn_user_once!("The workspace `requires-python` value (`{requires_python}`) does not contain a lower bound. Add a lower bound to indicate the minimum compatible Python version (e.g., `{default}`).");
} else if requires_python.is_exact_without_patch() { } else if requires_python.is_exact_without_patch() {
warn_user_once!("The workspace `requires-python` value contains an exact match without a patch version: `{requires_python}`. When omitted, the patch version is implicitly `0`, e.g., `{requires_python}.0`. Did you mean `{requires_python}.*`?"); warn_user_once!("The workspace `requires-python` value (`{requires_python}`) contains an exact match without a patch version. When omitted, the patch version is implicitly `0` (e.g., `{requires_python}.0`). Did you mean `{requires_python}.*`?");
} }
requires_python requires_python
} else { } else {

8
crates/uv/tests/it/lock.rs
View File

@ -3530,7 +3530,7 @@ fn lock_requires_python_exact() -> Result<()> {
----- stderr ----- ----- stderr -----
Using CPython 3.12.[X] Using CPython 3.12.[X]
warning: The workspace `requires-python` value contains an exact match without a patch version: `==3.12`. When omitted, the patch version is implicitly `0`, e.g., `==3.12.[X]`. Did you mean `==3.12.*`? warning: The workspace `requires-python` value (`==3.12`) contains an exact match without a patch version. When omitted, the patch version is implicitly `0` (e.g., `==3.12.[X]`). Did you mean `==3.12.*`?
Resolved 2 packages in [TIME] Resolved 2 packages in [TIME]
"###); "###);
@ -3587,7 +3587,7 @@ fn lock_requires_python_exact() -> Result<()> {
----- stderr ----- ----- stderr -----
Using CPython 3.12.[X] Using CPython 3.12.[X]
warning: The workspace `requires-python` value contains an exact match without a patch version: `==3.12`. When omitted, the patch version is implicitly `0`, e.g., `==3.12.[X]`. Did you mean `==3.12.*`? warning: The workspace `requires-python` value (`==3.12`) contains an exact match without a patch version. When omitted, the patch version is implicitly `0` (e.g., `==3.12.[X]`). Did you mean `==3.12.*`?
Resolved 2 packages in [TIME] Resolved 2 packages in [TIME]
"###); "###);
@ -4139,7 +4139,7 @@ fn lock_requires_python_unbounded() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
warning: The workspace `requires-python` value does not contain a lower bound: `<=3.12`. Set a lower bound to indicate the minimum compatible Python version (e.g., `>=3.11`). warning: The workspace `requires-python` value (`<=3.12`) does not contain a lower bound. Add a lower bound to indicate the minimum compatible Python version (e.g., `>=3.11`).
Resolved 2 packages in [TIME] Resolved 2 packages in [TIME]
"###); "###);
@ -4186,7 +4186,7 @@ fn lock_requires_python_unbounded() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
warning: The workspace `requires-python` value does not contain a lower bound: `<=3.12`. Set a lower bound to indicate the minimum compatible Python version (e.g., `>=3.11`). warning: The workspace `requires-python` value (`<=3.12`) does not contain a lower bound. Add a lower bound to indicate the minimum compatible Python version (e.g., `>=3.11`).
Resolved 2 packages in [TIME] Resolved 2 packages in [TIME]
"###); "###);