Python
/
uv
mirror of https://github.com/astral-sh/uv
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove TODOs around caching workspace discovery (#12510) 

## Summary

This happened!
This commit is contained in:
Charlie Marsh 2025-03-27 12:25:09 -04:00 committed by GitHub
parent 882e2f9d3f
commit 7cb85fa08f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/uv-distribution/src/metadata/build_requires.rs
View File

@ -48,8 +48,6 @@ impl BuildRequires {
..Default::default() ..Default::default()
}, },
}; };
// TODO(konsti): Cache workspace discovery.
let Some(project_workspace) = let Some(project_workspace) =
ProjectWorkspace::from_maybe_project_root(install_path, &discovery, cache).await? ProjectWorkspace::from_maybe_project_root(install_path, &discovery, cache).await?
else { else {

6
crates/uv-distribution/src/metadata/requires_dist.rs
View File

@ -51,8 +51,7 @@ impl RequiresDist {
sources: SourceStrategy, sources: SourceStrategy,
cache: &WorkspaceCache, cache: &WorkspaceCache,
) -> Result<Self, MetadataError> { ) -> Result<Self, MetadataError> {
// TODO(konsti): Cache workspace discovery. let discovery = DiscoveryOptions {
let discovery_options = DiscoveryOptions {
stop_discovery_at: git_member.map(|git_member| { stop_discovery_at: git_member.map(|git_member| {
git_member git_member
.fetch_root .fetch_root
@ -66,8 +65,7 @@ impl RequiresDist {
}, },
}; };
let Some(project_workspace) = let Some(project_workspace) =
ProjectWorkspace::from_maybe_project_root(install_path, &discovery_options, cache) ProjectWorkspace::from_maybe_project_root(install_path, &discovery, cache).await?
.await?
else { else {
return Ok(Self::from_metadata23(metadata)); return Ok(Self::from_metadata23(metadata));
}; };