From ac9ce853cf1111d709bfffc839cb3477b69a6ffe Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Sun, 10 Nov 2024 17:55:22 -0500 Subject: [PATCH] Remove some unused public methods (#8993) ## Summary Notice these in an unrelated refactor. --- crates/uv-distribution-types/src/resolution.rs | 13 ------------- crates/uv-distribution/src/error.rs | 2 -- crates/uv-resolver/src/resolution/graph.rs | 4 ++-- 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/crates/uv-distribution-types/src/resolution.rs b/crates/uv-distribution-types/src/resolution.rs index 5c61a1e06..7c97223c1 100644 --- a/crates/uv-distribution-types/src/resolution.rs +++ b/crates/uv-distribution-types/src/resolution.rs @@ -28,14 +28,6 @@ impl Resolution { } } - /// Return the remote distribution for the given package name, if it exists. - pub fn get_remote(&self, package_name: &PackageName) -> Option<&Dist> { - match self.packages.get(package_name)? { - ResolvedDist::Installable(dist) => Some(dist), - ResolvedDist::Installed(_) => None, - } - } - /// Return the hashes for the given package name, if they exist. pub fn get_hashes(&self, package_name: &PackageName) -> &[HashDigest] { self.hashes.get(package_name).map_or(&[], Vec::as_slice) @@ -61,11 +53,6 @@ impl Resolution { self.packages.is_empty() } - /// Return the set of [`Requirement`]s that this resolution represents. - pub fn requirements(&self) -> impl Iterator + '_ { - self.packages.values().map(Requirement::from) - } - /// Return the [`ResolutionDiagnostic`]s that were produced during resolution. pub fn diagnostics(&self) -> &[ResolutionDiagnostic] { &self.diagnostics diff --git a/crates/uv-distribution/src/error.rs b/crates/uv-distribution/src/error.rs index 0975a7163..a68bc5dac 100644 --- a/crates/uv-distribution/src/error.rs +++ b/crates/uv-distribution/src/error.rs @@ -53,8 +53,6 @@ pub enum Error { // Build error #[error(transparent)] Build(anyhow::Error), - #[error("Failed to build editable: `{0}`")] - BuildEditable(String, #[source] anyhow::Error), #[error("Built wheel has an invalid filename")] WheelFilename(#[from] WheelFilenameError), #[error("Package metadata name `{metadata}` does not match given name `{given}`")] diff --git a/crates/uv-resolver/src/resolution/graph.rs b/crates/uv-resolver/src/resolution/graph.rs index b4cf97a0c..5c693c218 100644 --- a/crates/uv-resolver/src/resolution/graph.rs +++ b/crates/uv-resolver/src/resolution/graph.rs @@ -777,8 +777,8 @@ pub struct ConflictingDistributionError { impl std::error::Error for ConflictingDistributionError {} -impl std::fmt::Display for ConflictingDistributionError { - fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { +impl Display for ConflictingDistributionError { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { let ConflictingDistributionError { ref name, ref version1,