Python/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv synced 2026-01-22 05:50:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Prioritize PATH over py --list-paths in Windows selection (#2057)

Browse Source 
`uv --system` is failing in GitHub Actions, because `py --list-paths`
returns all the pre-cached Pythons:

```
-V:3.12 *        C:\hostedtoolcache\windows\Python\3.12.2\x64\python.exe
-V:3.12-32       C:\hostedtoolcache\windows\Python\3.12.2\x86\python.exe
-V:3.11          C:\hostedtoolcache\windows\Python\3.11.8\x64\python.exe
-V:3.11-32       C:\hostedtoolcache\windows\Python\3.11.8\x86\python.exe
-V:3.10          C:\hostedtoolcache\windows\Python\3.10.11\x64\python.exe
-V:3.10-32       C:\hostedtoolcache\windows\Python\3.10.11\x86\python.exe
-V:3.9           C:\hostedtoolcache\windows\Python\3.9.13\x64\python.exe
-V:3.9-32        C:\hostedtoolcache\windows\Python\3.9.13\x86\python.exe
-V:3.8           C:\hostedtoolcache\windows\Python\3.8.10\x64\python.exe
-V:3.8-32        C:\hostedtoolcache\windows\Python\3.8.10\x86\python.exe
-V:3.7           C:\hostedtoolcache\windows\Python\3.7.9\x64\python.exe
-V:3.7-32        C:\hostedtoolcache\windows\Python\3.7.9\x86\python.exe
```

So, our default selector returns the first entry here. But none of these
are actually in `PATH` except the one that the user installed via
`actions/setup-python@v5` -- that's the point of the action, that it
puts the correct versions in `PATH`.

It seems to me like we should prioritize `PATH` over `py --list-paths`.
Is there a good reason not to do this?

Closes: https://github.com/astral-sh/uv/issues/2056
This commit is contained in:
Charlie Marsh
2024-02-29 10:06:29 -05:00
committed by GitHub
parent 0fbfa11013
commit b983ff4fa7
3 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.github/workflows/system-install.yml vendored
View File

@@ -67,8 +67,9 @@ jobs:
steps:
- uses: actions/checkout@v4
# - name: "Install Python"
# run: choco install python
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: "Install Rust toolchain"
run: rustup show
@@ -82,7 +83,7 @@ jobs:
run: echo $(which python)
- name: "Validate global Python install"
run: py -3.12 ./scripts/check_system_python.py --uv ./target/debug/uv
run: py -3.10 ./scripts/check_system_python.py --uv ./target/debug/uv
install-pyenv:
name: "Install Python using pyenv"