Python
/
uv
mirror of https://github.com/astral-sh/uv
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix error leading to out-of-bound panic in `uv-pep508` (#8282) 

Resolves #8281.

## Summary


[`Cursor.slice()`](d930367f8c/crates/uv-pep508/src/cursor.rs (L39))
expects a start index and a length, but it is instead [given a start
index and an end
index](d930367f8c/crates/uv-pep508/src/lib.rs (L936)).

## Test plan

A new "leading whitespace" test is added to `tests.rs`.
This commit is contained in:
InSync 2024-10-17 12:22:58 +00:00 committed by GitHub
parent 7eed0bcd23
commit d2e3026160
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/uv-pep508/src/lib.rs
View File

@ -933,7 +933,7 @@ fn parse_pep508_requirement<T: Pep508Url>(
//
// See: https://github.com/pypa/pip/blob/111eed14b6e9fba7c78a5ec2b7594812d17b5d2b/src/pip/_internal/utils/filetypes.py#L8
if requirement_kind.is_none() {
if looks_like_archive(cursor.slice(name_start, name_end)) {
if looks_like_archive(cursor.slice(name_start, name_end - name_start)) {
let clone = cursor.clone().at(start);
return Err(Pep508Error {
message: Pep508ErrorSource::UnsupportedRequirement("URL requirement must be preceded by a package name. Add the name of the package before the URL (e.g., `package_name @ https://...`).".to_string()),

6
crates/uv-pep508/src/tests.rs
View File

@ -116,6 +116,12 @@ fn basic_examples() {
assert_eq!(requests, expected);
}
#[test]
fn leading_whitespace() {
let numpy = Requirement::<Url>::from_str(" numpy").unwrap();
assert_eq!(numpy.name.as_ref(), "numpy");
}
#[test]
fn parenthesized_single() {
let numpy = Requirement::<Url>::from_str("numpy ( >=1.19 )").unwrap();