From f44aba0a968a2bfa84a9532ce0c0e78e4ccf0ab2 Mon Sep 17 00:00:00 2001 From: Zanie Blue Date: Tue, 4 Mar 2025 08:36:20 -0600 Subject: [PATCH] Run the Docker build workflow when we touch project or toolchain metadata (#11938) I noticed that https://github.com/astral-sh/uv/pull/11936 did not run the Docker builds, nor did #11934 We should run these when the relevant files change so there aren't surprises at release time! Updates the `build-binaries` workflow to include toolchain version changes and `.cargo/config.toml` changes too. --- .github/workflows/build-binaries.yml | 8 ++++++-- .github/workflows/build-docker.yml | 11 +++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml index 6079a21da..8c4122a00 100644 --- a/.github/workflows/build-binaries.yml +++ b/.github/workflows/build-binaries.yml @@ -14,11 +14,15 @@ on: type: string pull_request: paths: - # When we change project metadata, we want to ensure that the maturin builds still work. + # We want to ensure that the maturin builds still work when we change + # Project metadata - pyproject.toml - Cargo.toml + - .cargo/config.toml + # Toolchain or dependency versions - Cargo.lock - # And when we change this workflow itself... + - rust-toolchain.toml + # And the workflow itself - .github/workflows/build-binaries.yml concurrency: diff --git a/.github/workflows/build-docker.yml b/.github/workflows/build-docker.yml index 00c2e5a1e..4170cf335 100644 --- a/.github/workflows/build-docker.yml +++ b/.github/workflows/build-docker.yml @@ -15,6 +15,17 @@ on: type: string pull_request: paths: + # We want to ensure that the maturin builds still work when we change + # Project metadata + - pyproject.toml + - Cargo.toml + - .cargo/config.toml + # Toolchain or dependency versions + - Cargo.lock + - rust-toolchain.toml + # The Dockerfile itself + - Dockerfile + # And the workflow itself - .github/workflows/build-docker.yml env: