Python
/
uv
mirror of https://github.com/astral-sh/uv
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid allocating a max-size buffer (#1123) 

This seems potentially-dangerous with no upside.
This commit is contained in:
Charlie Marsh 2024-01-26 06:27:19 -08:00 committed by GitHub
parent 39021263dd
commit f946d46273
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/puffin-extract/src/lib.rs
View File

@ -50,9 +50,12 @@ pub async fn unzip_no_seek<R: tokio::io::AsyncRead + Unpin>(
fs_err::tokio::create_dir_all(parent).await?; fs_err::tokio::create_dir_all(parent).await?;
} }
let file = fs_err::tokio::File::create(path).await?; let file = fs_err::tokio::File::create(path).await?;
let size = let mut writer =
usize::try_from(entry.reader().entry().uncompressed_size()).unwrap_or(usize::MAX); if let Ok(size) = usize::try_from(entry.reader().entry().uncompressed_size()) {
let mut writer = tokio::io::BufWriter::with_capacity(size, file); tokio::io::BufWriter::with_capacity(size, file)
} else {
tokio::io::BufWriter::new(file)
};
let mut reader = entry.reader_mut().compat(); let mut reader = entry.reader_mut().compat();
tokio::io::copy(&mut reader, &mut writer).await?; tokio::io::copy(&mut reader, &mut writer).await?;
} }